Re: [PATCH] Fix PR52298

2012-02-24 Thread Richard Guenther
On Thu, 23 Feb 2012, Ulrich Weigand wrote: > Richard Guenther wrote: > > > PR tree-optimization/52298 > > * tree-vect-stmts.c (vectorizable_store): Properly use > > STMT_VINFO_DR_STEP instead of DR_STEP when vectorizing > > outer loops. > > (vectorizable_load): Likewise. > >

Re: [PATCH 5/5] dump_file whitespace nitpicks

2012-02-24 Thread Richard Guenther
On Thu, Feb 23, 2012 at 7:21 PM, Bernhard Reutner-Fischer wrote: > gcc/ChangeLog: > > 2012-02-23  Bernhard Reutner-Fischer   > >        * tree-into-ssa (update_ssa): Avoid trailing whitespace in >        dump_file. >        * tree-ssa-sccvn.c (print_scc): Ditto. Ok. Thanks, Richard. > Signed-of

Re: [PATCH 4/5] make_phi_node can be static

2012-02-24 Thread Richard Guenther
On Thu, Feb 23, 2012 at 7:21 PM, Bernhard Reutner-Fischer wrote: > gcc/ChangeLog: > > 2012-02-23  Bernhard Reutner-Fischer   > >        * tree-phinodes.c (make_phi_node): Mark static. >        * tree-flow.h (make_phi_node): Remove extern decl. >        * doc/gimple.texi (make_phi_node): Remove doc

Re: [PR51752] publication safety violations in loop invariant motion pass

2012-02-24 Thread Richard Guenther
On Thu, Feb 23, 2012 at 10:11 PM, Aldy Hernandez wrote: > On 02/23/12 12:19, Aldy Hernandez wrote: > >> about hit me. Instead now I save all loads in a function and iterate >> through them in a brute force way. I'd like to rewrite this into a hash >> of some sort, but before I go any further I'm i

RE: spill failure after IF-CASE-2 transformation

2012-02-24 Thread Henderson, Stuart
>I think this is a fairly reasonable minimal fix. For 4.8 we could >experiment whether to always do this, regardless of s_r_c_f_m_p. > >Ok if bootstrapped and tested on a primary target (i.e. linux) and >tested on Blackfin. > > >Bernd Thanks again, Bernd. Forwarding to gcc-patches to give people

Re: [PATCH 3/5] tree-if-conv: Commentary typo fix

2012-02-24 Thread Bernhard Reutner-Fischer
On Thu, Feb 23, 2012 at 07:21:29PM +0100, Bernhard Reutner-Fischer wrote: >gcc/ChangeLog: > >2012-02-23 Bernhard Reutner-Fischer > > * tree-if-conv (predicate_scalar_phi): Commentary typo fix. Applied to trunk as obvious as r184546. > >Signed-off-by: Bernhard Reutner-Fischer >--- > gcc/t

Re: [PATCH, i386, Android] Enable __ANDROID__ macro for Android i386 target

2012-02-24 Thread Ilya Enkovich
> On Wed, Feb 22, 2012 at 6:59 AM, Ilya Enkovich wrote: >> Hello, >> >> Here is a one-line fix to enable __ANDROID__ macro on i386 Android >> target. OK for trunk? >> >> Thanks, >> Ilya >> -- >> >> 2012-02-22  Enkovich Ilya   >> >>        * gcc/config/i386/gnu-user.h (TARGET_OS_CPP_BUILTINS): Add

Re: [PATCH, i386, Android] Enable exceptions and RTTI by default for Android

2012-02-24 Thread Ilya Enkovich
> On Wed, Feb 22, 2012 at 3:57 PM, Ilya Enkovich wrote: >> Hello, >> >> Here is a simple patch which enables exceptions and RTTI by default >> for Android target. OK for trunk? > > Err - isn't that the default?  Thus, simply delete the bogus spec? > > Richard. > > Hi, Is following patch OK or it'

[PATCH] Fix PR52361 (a bit)

2012-02-24 Thread Richard Guenther
This avoids redundant verify_gimple_in_cfg calls (the original idea was to always verify gimple when we verify SSA form). Scheduled for a bootstrap/regtest. Richard. 2012-02-24 Richard Guenther PR middle-end/52361 * passes.c (execute_function_todo): When verifying SSA form

Re: [PATCH, i386, Android] Enable exceptions and RTTI by default for Android

2012-02-24 Thread Richard Guenther
On Fri, Feb 24, 2012 at 11:22 AM, Ilya Enkovich wrote: >> On Wed, Feb 22, 2012 at 3:57 PM, Ilya Enkovich >> wrote: >>> Hello, >>> >>> Here is a simple patch which enables exceptions and RTTI by default >>> for Android target. OK for trunk? >> >> Err - isn't that the default?  Thus, simply delete

[PATCH] Fix PR52355

2012-02-24 Thread Richard Guenther
This fixes PR52355 by extending the existing folding of &a[i] - &a[j] to cover multi-dimensional array access and non-equal base. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2012-02-24 Richard Guenther PR middle-end/52355 * fold-const.c (fold_addr

[PATCH] Some more speedups for PR52361

2012-02-24 Thread Richard Guenther
I noticed that checking time is dominated by walk_gimple_op and walk_tree, not so much by the core worker. walk_gimple_op can be micro-optimized a bit and the simple predicate is_gimple_reg_type can be trivially inlined. Bootstrap & testing in progress. That was what is low-hanging. Richard.

Re: [PATCH] Adjust 'malloc' attribute documentation to match implementation

2012-02-24 Thread Richard Guenther
On Tue, Feb 21, 2012 at 4:02 PM, Tijl Coosemans wrote: > On Tuesday 21 February 2012 10:19:15 Richard Guenther wrote: >> On Mon, Feb 20, 2012 at 8:55 PM, Tijl Coosemans wrote: >>> On Monday 9 January 2012 10:05:08 Richard Guenther wrote: Since GCC 4.4 applying the malloc attribute to realloc

Re: [PR51752] publication safety violations in loop invariant motion pass

2012-02-24 Thread Torvald Riegel
On Fri, 2012-02-24 at 09:58 +0100, Richard Guenther wrote: > On Thu, Feb 23, 2012 at 10:11 PM, Aldy Hernandez wrote: > > On 02/23/12 12:19, Aldy Hernandez wrote: > > > >> about hit me. Instead now I save all loads in a function and iterate > >> through them in a brute force way. I'd like to rewrit

Re: [PATCH] Fix PR52298

2012-02-24 Thread Ulrich Weigand
Richard Guenther wrote: > On Thu, 23 Feb 2012, Ulrich Weigand wrote: > > The assert in question looks like: > > > > if (nested_in_vect_loop > > && (TREE_INT_CST_LOW (STMT_VINFO_DR_STEP (stmt_info)) > > % GET_MODE_SIZE (TYPE_MODE (vectype)) != 0)) > > { > > gcc_assert (

Re: [PATCH, i386, Android] -mandroid support for i386 target

2012-02-24 Thread Ilya Enkovich
> On Wed, Feb 22, 2012 at 6:54 AM, Ilya Enkovich wrote: >> Hello, >> >> This patch adds -mandroid support to i386 target. OK for trunk? >> >> Thanks, >> Ilya >> -- >> >> 2012-02-22  Enkovich Ilya   >> >>        * config/i386/gnu-user.h (LINUX_TARGET_CC1_SPEC): New. > > I don't think you should def

Re: [PATCH, i386, Android] Enable __ANDROID__ macro for Android i386 target

2012-02-24 Thread H.J. Lu
On Fri, Feb 24, 2012 at 1:51 AM, Ilya Enkovich wrote: >> On Wed, Feb 22, 2012 at 6:59 AM, Ilya Enkovich >> wrote: >>> Hello, >>> >>> Here is a one-line fix to enable __ANDROID__ macro on i386 Android >>> target. OK for trunk? >>> >>> Thanks, >>> Ilya >>> -- >>> >>> 2012-02-22  Enkovich Ilya   >>

Re: [PATCH, i386, Android] -mandroid support for i386 target

2012-02-24 Thread H.J. Lu
On Fri, Feb 24, 2012 at 7:17 AM, Ilya Enkovich wrote: >> On Wed, Feb 22, 2012 at 6:54 AM, Ilya Enkovich >> wrote: >>> Hello, >>> >>> This patch adds -mandroid support to i386 target. OK for trunk? >>> >>> Thanks, >>> Ilya >>> -- >>> >>> 2012-02-22  Enkovich Ilya   >>> >>>        * config/i386/gn

[testsuite] Skip gcc.target/mips/interrupt_handler-[23].c on IRIX (PR target/50580)

2012-02-24 Thread Rainer Orth
Looking closer into the gcc.target/mips/interrupt_handler-[23].c failures FAIL: gcc.target/mips/interrupt_handler-2.c scan-assembler \\t.cfi_restore 64\\n FAIL: gcc.target/mips/interrupt_handler-2.c scan-assembler \\t.cfi_restore 65\\n and many more for interrupt_handler-3.c, I now unde

Re: PATCH: PR target/52364: The unnecessary second form in *movabs_[12]

2012-02-24 Thread Uros Bizjak
On Fri, Feb 24, 2012 at 5:58 AM, H.J. Lu wrote: > The second form is redundant in > > ;; Stores and loads of ax to arbitrary constant address. > ;; We fake an second form of instruction to force reload to load address > ;; into register when rax is not available > (define_insn "*movabs_1" >  [(se

Re: [patch] Fix cygwin ada install [was Re: Yet another issue with gcc current trunk with ada on cygwin]

2012-02-24 Thread Dave Korn
On 22/02/2012 16:25, Pascal Obry wrote: > Dave, > >> Pascal, ping? > > Sorry for the delay, these message has fallen into the crack! No problem, I had plenty to be getting on with in the meantime :) > Anyway, with these explanations I'm ok with the patch. Thanks. Committed revision 1845

Re: [patch i386]: Add support of delegitimize of UNSPEC_PCREL plus displacement

2012-02-24 Thread Richard Henderson
On 02/23/12 09:12, Kai Tietz wrote: > 2012-02-23 Kai Tietz > > * config/i386/i386.c (ix86_delegitimize_address): Handle > UNSPEC_PCREL plus displacement. Ok. r~

[PATCH] genattrtab: avoid NULL-deref on error

2012-02-24 Thread Jim Meyering
This fixes a coverity-spotted issue. A NULL "et" could be dereferenced after the diagnostic is issued. 2012-02-24 Jim Meyering genattrtab: avoid NULL-deref on error * genattrtab.c (gen_attr): Avoid NULL-deref after diagnosing absence of an defin_enum call. diff --git

Re: [PR51752] publication safety violations in loop invariant motion pass

2012-02-24 Thread Aldy Hernandez
On 02/24/12 07:10, Torvald Riegel wrote: On Fri, 2012-02-24 at 09:58 +0100, Richard Guenther wrote: On Thu, Feb 23, 2012 at 10:11 PM, Aldy Hernandez wrote: On 02/23/12 12:19, Aldy Hernandez wrote: about hit me. Instead now I save all loads in a function and iterate through them in a brute fo

Re: PATCH: PR target/52364: The unnecessary second form in *movabs_[12]

2012-02-24 Thread H.J. Lu
On Fri, Feb 24, 2012 at 8:11 AM, Uros Bizjak wrote: > On Fri, Feb 24, 2012 at 5:58 AM, H.J. Lu wrote: > >> The second form is redundant in >> >> ;; Stores and loads of ax to arbitrary constant address. >> ;; We fake an second form of instruction to force reload to load address >> ;; into register

[PATCH v2] genattrtab: avoid NULL-deref on error

2012-02-24 Thread Jim Meyering
This is the same as the preceding patch, but fixes s/defin_enum/define_enum/ in the ChangeLog comment: 2012-02-24 Jim Meyering * genattrtab.c (gen_attr): Avoid NULL-deref after diagnosing absence of an define_enum call. diff --git a/gcc/genattrtab.c b/gcc/genattrtab.c index 4a

[lra] patch for S390 bootstrap.

2012-02-24 Thread Vladimir Makarov
The following patch fixes some bugs preventing S390x bootstrap. The patch is still not fixing the S390 bootstrap yet but I am working on it. The patch was successfully bootstrapped on x86/x86-64. Committed as rev. 184561. 2012-02-24 Vladimir Makarov * lra-assigns.c (improve_inherit

[PATCH] simulate-thread tweaks and fixes

2012-02-24 Thread Andrew MacLeod
I've been toying with the simulate-thread framework a bit. With the timeout threshold is back to where it originally was, the spectre of huge log files when an infinite loop happens is back. This patch has the following modifications: 1) An instruction count threshold has been added. Th

[libgo] Fix typo in libgo/runtime/go-nosys.c

2012-02-24 Thread Rainer Orth
Mainline bootstrap on x86_64-unknown-linux-gnu (CentOS 5.6) was failing due to a trivial typo. Fixed as follows. Rainer diff --git a/libgo/runtime/go-nosys.c b/libgo/runtime/go-nosys.c --- a/libgo/runtime/go-nosys.c +++ b/libgo/runtime/go-nosys.c @@ -52,7 +52,7 @@ faccessat (int fd __at

Re: [PATCH] simulate-thread tweaks and fixes

2012-02-24 Thread Jack Howarth
rwin11.3.0 === gcc tests === Schedule of variations: unix/-m32 unix/-m64 Running target unix/-m32 Using /sw/share/dejagnu/baseboards/unix.exp as board description file for target. Using /sw/share/dejagnu/config/unix.exp as generic interface file for target. Using /sw/src/fink.

Ping #1: [Patch,AVR] Fix/hack around spill fail ICE PR52148

2012-02-24 Thread Georg-Johann Lay
http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00956.html Georg-Johann Lay wrote: > Spill failure PR52148 occurs for movmem insn that allocates 2 of AVR's 3 > pointer registers. Register allocator is at it's limits and the patch tries to > cure the situation by replacing > > (match_operand:HI 0 "re

Ping #1: [Patch,AVR]: Add builtins.def and fix some ICE, add tests

2012-02-24 Thread Georg-Johann Lay
http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00843.html Georg-Johann Lay wrote: > This patch introduces a new file builtins.def that is used as central registry > to hold built-ins' information. > > The file is used by defining DEF_BUILTIN macre and then including the file as > described in the h

Re: [PATCH] simulate-thread tweaks and fixes

2012-02-24 Thread Mike Stump
On Feb 24, 2012, at 9:38 AM, Andrew MacLeod wrote: > I've been toying with the simulate-thread framework a bit. > OK for mainline? Ok. Don't know why you ask... I'd ask you if I wanted to make a change to the file... Anyway, I reviewed it, and didn't spot anything bad.

Re: [PATCH] simulate-thread tweaks and fixes

2012-02-24 Thread Andrew MacLeod
On 02/24/2012 02:10 PM, Mike Stump wrote: On Feb 24, 2012, at 9:38 AM, Andrew MacLeod wrote: I've been toying with the simulate-thread framework a bit. OK for mainline? Ok. Don't know why you ask... I'd ask you if I wanted to make a change to the file... Anyway, I reviewed it, and didn't sp

PATCH: PR target/52352: [x32] - Wrong code to access addresses 0x80000000 to 0xFFFFFFFF using registers

2012-02-24 Thread H.J. Lu
Hi, This patches enables *movabs_1 and *movabs_2 only for TARGET_LP64 since x32 doesn't need 64bit address. OK for trunk? Thanks. H.J. --- 2012-02-24 H.J. Lu PR target/52352 * config/i386/i386.md (*movabs_1): Enable only for TARGET_LP64. (*movabs_2): Likewise

Re: Simulator testing for sh and sh64

2012-02-24 Thread Thomas Schwinge
Hi! On Fri, 24 Feb 2012 00:08:00 +0900, Kaz Kojima wrote: > Thomas Schwinge wrote: > > /scratch/tschwing/FM_sh64-elf/src/gcc-mainline/libgcc/libgcc2.c: In > > function '__powisf2': > > /scratch/tschwing/FM_sh64-elf/src/gcc-mainline/libgcc/libgcc2.c:1779:1: > > error: unrecognizable ins

Re: [PATCH] [RFC, GCC 4.8] Optimize conditional moves from adjacent memory locations

2012-02-24 Thread William J. Schmidt
On Fri, 2012-02-10 at 15:46 -0500, Michael Meissner wrote: > I was looking at the routelookup EEMBC benchmark and it has code of the form: > >while ( this_node->cmpbit > next_node->cmpbit ) > { > this_node = next_node; > > if ( proute->dst_addr & (0x1 << this_node->cmpbit) ) >

Re: [PATCH, i386, Android] Enable exceptions and RTTI by default for Android

2012-02-24 Thread Jing Yu
My comment is(was) not on the format of the patch. Instead, I am thinking whether Android toolchain customer, which is Android AOSP, wants this patch. I don't know the scenario behind this patch. I think the question behind this patch is, if RTTI and exceptions are enabled by default, who is suppo

Re: Simulator testing for sh and sh64

2012-02-24 Thread Oleg Endo
Hello, On Fri, 2012-02-24 at 22:23 +0100, Thomas Schwinge wrote: > Confirming that this patch makes GCC trunk buildable again. > > Comparing to the 4.6 testsuite results, with trunk there are about 700 > new execution failures in g++, gcc, libstdc++, about 100 ``compilation > failed to produce e

[google][4.6]Bug fix to function reordering plugin to check presence of elf.h

2012-02-24 Thread Sriraman Tallam
function_reordering_plugin.c includes which is not available on non-ELF platforms building a cross-compiler. This patch checks for before including it. Otherwise, it redefines the macros used. This is safe because the macros will not change. For context, this linker plugin itself is only availab

Re: [libgo] Fix typo in libgo/runtime/go-nosys.c

2012-02-24 Thread Ian Lance Taylor
Rainer Orth writes: > Mainline bootstrap on x86_64-unknown-linux-gnu (CentOS 5.6) was failing > due to a trivial typo. Fixed as follows. Whoops. Thanks. Committed. Ian

[PATCH] backport r184555 to gcc-4_6-branch

2012-02-24 Thread Jack Howarth
The attached patch is a backport of r184555 to the gcc-4_6-branch to fix PR52179 so that boehm-gc functions properly with darwin11 and later's default usage of -pie in the linker. This fixes PR49461 properly and allows the previous hack of passing -no_pie to SYSTEMSPEC to be removed. Bootstra

[PATCH 1/2] mips: Add R4600 scheduling support for imul and idiv

2012-02-24 Thread Matt Turner
The r4600_imul and r4600_idiv reservations were correct for si, but there were no *_di reservations. See page 4 of http://www.sgistuff.net/hardware/other/documents/R4600_Prod_OV.pdf 2012-02-24 Matt Turner * config/mips/4600.md (r4600_imul_si): Rename from r4600_imul. (r4600_im

Miscellaneous mips, arm, and alpha patches

2012-02-24 Thread Matt Turner
Hi, Following this email are five rather trivial patches that I've had sitting around while waiting for my grad school and the Free Software Foundation to decide it's okay for me to contribute. I don't have copyright assignment for gcc yet, but I thought I would pipeline this process and try to ge

[PATCH] alpha: add bypasses for fmul/fadd/fcmov -> fst/ftoi

2012-02-24 Thread Matt Turner
See section 2.5.3 (page 28) of http://download.majix.org/dec/comp_guide_v2.pdf 2012-02-24 Matt Turner * config/alpha/ev6.md: (define_bypass "ev6_fmul,ev6_fadd"): New. (define_bypass "ev6_fcmov"): New. --- gcc/config/alpha/ev6.md |4 1 files changed, 4 insertions(+), 0

[PATCH 2/2] mips: Add R4700 scheduling support

2012-02-24 Thread Matt Turner
The R4700 is identical to the R4600 except for the integer and floating-point multiplication costs. See page 4 of http://datasheets.chipdb.org/IDT/MIPS/79RV4700.pdf 2012-02-24 Matt Turner * config/mips/4600.md (r4700_imul_si): New. (r4700_imul_di): New. (r4700_fmul_sin

[PATCH] arm: Fix iwmmxt shift and logical intrinsics (PR 35294).

2012-02-24 Thread Matt Turner
PR 36798 and 36966 are duplicates. 2012-02-24 Matt Turner PR target/35294 * config/arm/arm.c (arm_expand_builtin): Wire up missing intrinsics. --- gcc/config/arm/arm.c | 62 +- 1 files changed, 61 insertions(+), 1 delet

[PATCH] arm: add _mm_empty to mmintrin.h for source compatibility

2012-02-24 Thread Matt Turner
The x86/amd64 mmintrin.h provides the _mm_empty intrinsic for the 'emms' MMX instruction. Although ARM does not need such an instruction, we should provide an empty _mm_empty function nonetheless for source compatibility. 2012-02-24 Matt Turner * config/arm/mmintrin.h (_mm_empty): New.

Re: [PATCH] backport r184555 to gcc-4_6-branch

2012-02-24 Thread Mike Stump
On Feb 24, 2012, at 6:45 PM, Jack Howarth wrote: > The attached patch is a backport of r184555 to the gcc-4_6-branch to fix > PR52179 > so that boehm-gc functions properly with darwin11 and later's default usage > of -pie > in the linker. This fixes PR49461 properly and allows the previous hac

Re: [google][4.6]Bug fix to function reordering plugin to check presence of elf.h

2012-02-24 Thread Xinliang David Li
ok. David On Fri, Feb 24, 2012 at 4:19 PM, Sriraman Tallam wrote: > function_reordering_plugin.c includes which is not available > on non-ELF platforms building a cross-compiler. This patch checks for > before including it. Otherwise, it redefines the macros used. > This is safe because the ma