Re: [patch] 19/n: trans-mem: middle end/misc patches (LAST PATCH)

2011-11-07 Thread Aldy Hernandez
I can certainly move this to expand_call_stmt() if you prefer. Do you have an objection to the RTL walk? This isn't my code, but I'm open to suggestions on an alternative to implement. It just catched my eye... moving it to expand_call_stmt would be nice indeed, but I was suggesting to add

Re: [PATCH] Add an intermediate coverage format for gcov

2011-11-07 Thread Mike Stump
On Nov 6, 2011, at 11:04 PM, Sharad Singhai wrote: > Sorry about the delay. I have updated the patch to output demangled > names under a new option (-m) and added a test case. I like it, now you just need a gcov type person to like it. :-)

Re: [patch tree-optimization 2/2]: Branch-cost optimizations

2011-11-07 Thread Kai Tietz
2011/11/7 Richard Guenther : > On Sun, Nov 6, 2011 at 11:17 PM, Kai Tietz wrote: >> Hello, >> >> the second patch extends the tree-ssa-ifcombine pass so, that it chains up >> simple if-and/or-if patterns via associative bitwise-and/or operations.   >> This allows for example optimization for case

Re: [patch] 19/n: trans-mem: middle end/misc patches (LAST PATCH)

2011-11-07 Thread Richard Henderson
On 11/07/2011 01:44 AM, Richard Guenther wrote: > It just catched my eye... moving it to expand_call_stmt would be nice > indeed, but I was suggesting to add that note where we produce the > CALL rtx, not sure if that's reasonably straight-forward (I suppose there > was a reason to go with the hac

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-07 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > > I also wonder if instead of a new pass control-dependent DCE can be > taught of this? It could. I'm not sure it really buys us anything except maybe being able to reuse the pdom & control-dependency analysis. It actually more naturally belongs

Re: [patch] 19/n: trans-mem: middle end/misc patches (LAST PATCH)

2011-11-07 Thread Richard Henderson
On 11/07/2011 08:04 AM, Aldy Hernandez wrote: > @@ -1812,6 +1844,8 @@ expand_call_stmt (gimple stmt) >bool builtin_p; >size_t i; > > + mark_transaction_restart_calls (stmt); > + >if (gimple_call_internal_p (stmt)) > { >expand_internal_call (stmt); You're calling it too

Re: [rs6000] Fix PR 50906, eh_frame and other woes

2011-11-07 Thread Joseph S. Myers
On Mon, 7 Nov 2011, Alan Modra wrote: > On Mon, Nov 07, 2011 at 10:53:51AM +0100, Olivier Hainque wrote: > > Another bug we're running into here is an unwarranted move of the sp > > restore prior to register fetches despite an attempt at preventing that > > with a stack_tie instruction (VxWorks ta

Re: [patch tree-optimization 1/2]: Branch-cost optimizations

2011-11-07 Thread Richard Guenther
On Mon, Nov 7, 2011 at 4:53 PM, Kai Tietz wrote: > 2011/11/7 Richard Guenther : >> On Sun, Nov 6, 2011 at 11:12 PM, Kai Tietz wrote: >>> Hello, >>> >>> By this patch branch-cost optimization is moved from tree AST to cfgexpand >>> from gimple to RTL.  By this we are able to do better optimizatio

Re: [patch] 19/n: trans-mem: middle end/misc patches (LAST PATCH)

2011-11-07 Thread Aldy Hernandez
On 11/07/11 08:08, Richard Henderson wrote: On 11/07/2011 08:04 AM, Aldy Hernandez wrote: @@ -1812,6 +1844,8 @@ expand_call_stmt (gimple stmt) bool builtin_p; size_t i; + mark_transaction_restart_calls (stmt); + if (gimple_call_internal_p (stmt)) { expand_internal_cal

Re: [patch tree-optimization 2/2]: Branch-cost optimizations

2011-11-07 Thread Richard Guenther
On Mon, Nov 7, 2011 at 5:07 PM, Kai Tietz wrote: > 2011/11/7 Richard Guenther : >> On Sun, Nov 6, 2011 at 11:17 PM, Kai Tietz wrote: >>> Hello, >>> >>> the second patch extends the tree-ssa-ifcombine pass so, that it chains up >>> simple if-and/or-if patterns via associative bitwise-and/or opera

[Ada] Define unique entity for parameter (used in Alfa mode)

2011-11-07 Thread Arnaud Charlet
For the formal verification backend, to be used in Alfa mode, define the unique entity representing a parameter. Tested on x86_64-pc-linux-gnu, committed on trunk 2011-11-07 Yannick Moy * sem_util.adb (Unique_Entity): For a parameter on a subprogram body that has a correspondi

[Ada] Iteration over class-wide containers

2011-11-07 Thread Arnaud Charlet
In Ada2012 some aspects on tagged types are inherited, and apply to the class wide type as well. Among these are the Default_Iterator and Iterator_Element aspects. These allow iterations over class-wide objects, e.g. in pre- or post- conditions. Tested on x86_64-pc-linux-gnu, committed on trunk 2

Re: cxx-mem-model merge [6 of 9] - libstdc++-v3

2011-11-07 Thread Joseph S. Myers
On Mon, 7 Nov 2011, Andrew MacLeod wrote: > Actually, this target has no lock free support whatsoever? ie, no > compare_and_swap instruction, nor an implementation of sync_lock_test_and_set > and sync_lock_release? > > I think the libstdc++ standard now requires the class atomic_flag to be lock

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-07 Thread Richard Guenther
On Mon, Nov 7, 2011 at 5:07 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > >> >> I also wonder if instead of a new pass control-dependent DCE can be >> taught of this? > It could.   I'm not sure it really buys us anything except maybe being > able to reuse the pdom & con

[Ada] In Alfa mode, record also modifications not coming from source

2011-11-07 Thread Arnaud Charlet
Alfa mode is meant for formal verification, in which we must gather all modifications to variables, even those not coming from source. This is in particular the case for rewritings of renamings in Alfa mode. Tested on x86_64-pc-linux-gnu, committed on trunk 2011-11-07 Yannick Moy * se

Re: cxx-mem-model merge [6 of 9] - libstdc++-v3

2011-11-07 Thread Richard Henderson
On 11/07/2011 06:44 AM, Andrew MacLeod wrote: > rth: __sync_lock_test_and_set_1 could be provided by libgcc if the > OS has hooks in it to provide functionality... How can we tell when > compiling a C++ program whether that is going to be an unresolved > external or whether libgcc is going to pro

Re: [patch] 19/n: trans-mem: middle end/misc patches (LAST PATCH)

2011-11-07 Thread Richard Henderson
On 11/07/2011 08:14 AM, Aldy Hernandez wrote: > TM tests all pass. Further tests are still going. > > OK pending tests? Much better. Ok. r~

[Ada] Improve error msg for passing volatile to non-volatile

2011-11-07 Thread Arnaud Charlet
This patch provides a minor improvement to an error message. This is compiled with -gnatld7 -gnatws -gnatj60: 1. procedure VolNVol is 2.type R is tagged null record; 3.procedure Q (A : R) is 4.begin 5. null; 6.end; 7.V : R; 8.pr

Re: [trans-mem] Fix instantiation of transaction expressions.

2011-11-07 Thread Richard Henderson
On 11/07/2011 06:12 AM, Torvald Riegel wrote: > stmt = begin_transaction_stmt (input_location, NULL, flags); > tmp = RECUR (TRANSACTION_EXPR_BODY (t)); > +if (tmp) > + { > +/* No statements; handle this like an expression. */ In which case I'm pretty

Re: [patch] 6/n: trans-mem: runtime

2011-11-07 Thread Joseph S. Myers
On Mon, 7 Nov 2011, Torvald Riegel wrote: > On Sun, 2011-11-06 at 23:04 +, Joseph S. Myers wrote: > > On Sun, 6 Nov 2011, Torvald Riegel wrote: > > > > > Is the attached patch what you'd like to see? It doesn't yet use the > > > > It's plausible, but really a build system maintainer should l

[build, v3] Return gthr-posix.h to libgcc (PR bootstrap/50982)

2011-11-07 Thread Rainer Orth
The gthr move to libgcc broke bootstrap on AIX in libstdc++: gthr-default.h is gthr-aix.h, which included config/gthr-posix.h. This works fine for the original files in libgcc, but the modified copy of gthr-default.h in libstc++-v3/include//bits couldn't find config/gthr-posix.h. The easiest solu

Re: vector garbaged collected while still in use

2011-11-07 Thread Xinliang David Li
Here is the stack trace when the watch point is hit (the watch point is on address &cleanups->base.prefix.num David #0 memset () at ../sysdeps/x86_64/memset.S:336 #1 0x00d1528d in poison_pages () at /usr/local/google/davidxl/dev/gcc/tot/gcc/ggc-page.c:1983 #2 0x00d15424 in ggc_

Re: [doc] fix broken anchor in install.texi

2011-11-07 Thread Jonathan Wakely
ping We currently have a broken link in the installation docs, see below. I've tried to fix it, but on both Fedora 15 and Debian squeeze the docs generated by "make html" do not match the online docs because of a different version of makeinfo (4.13 versus 4.8 usedfor the online docs). Can anyone

Re: Problems with trans-mem branch on Solaris/x86 etc.

2011-11-07 Thread Richard Henderson
On 11/07/2011 03:47 AM, Rainer Orth wrote: > While the configure triplet has i386 as target_cpu, the port defaults > to --with-arch=pentiumpro (Solaris 8/9) or pentium4 (Solaris 10+). > I've changed configure.tgt to accept i386 as well, but this needs to > be dealt with in a more general wa

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-07 Thread Kai Tietz
2011/11/7 Richard Guenther : > On Mon, Nov 7, 2011 at 5:07 PM, Jeff Law wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> >>> >>> I also wonder if instead of a new pass control-dependent DCE can be >>> taught of this? >> It could.   I'm not sure it really buys us anything except may

Re: Use of vector instructions in memmov/memset expanding

2011-11-07 Thread Jan Hubicka
> Hi, Jan! > I was just preparing my version of the patch, but it seems a bit late > now. Please see my comments to this and your previous letter below. > > By the way, would it be possible to commit other part of the patch > (middle-end part) - probably also by small parts - and some other > tun

Re: [RFA/ARM][Patch 02/05]: LDRD generation instead of POP in A15 Thumb2 epilogue.

2011-11-07 Thread Richard Henderson
On 11/07/2011 01:48 AM, Sameera Deshpande wrote: > >> >> >> I don't believe REG_FRAME_RELATED_EXPR does the right thing for >> anything besides prologues. You need to emit REG_CFA_RESTORE >> for the pop inside an epilogue. > > Richard, here is updated patch that uses REG_CFA_RESTORE instead of

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 04:54 PM, Tom Tromey wrote: "Jeff" == Jeff Law writes: Jeff> So, presumably there's no way to know we're throwing to Jeff> NullPointerException from the exception information attached to the Jeff> statement or BB? If not I could disable if the statement with the Jeff> memory

[RFA/ARM] Add support for -mcpu=cortex-a7

2011-11-07 Thread Matthew Gretton-Dann
All, The attached patch adds support for -mcpu=cortex-a7 to the GCC command line. A related patch has just been committed to binutils so that gas will recognize cortex-a7 on the command line and in the appropriate directives. See http://sourceware.org/ml/binutils/2011-11/msg00048.html. Can

Re: [PING2] New port for TILEPro and TILE-Gx

2011-11-07 Thread Walter Lee
Seeking more feedback or status update. Thanks, Walter Lee On 10/30/2011 12:07 PM, Walter Lee wrote: > Ping? I believe I have addressed all the reviewer's (namely Joseph Myers') > comments to date. > > Thanks, > > Walter Lee

Re: [RFA/ARM] Add support for -mcpu=cortex-a7

2011-11-07 Thread Richard Earnshaw
On 07/11/11 16:58, Matthew Gretton-Dann wrote: > All, > > The attached patch adds support for -mcpu=cortex-a7 to the GCC command line. > > A related patch has just been committed to binutils so that gas will > recognize cortex-a7 on the command line and in the appropriate > directives. See htt

Re: [build] Restore arm-eabi bootstrap (PR target/50978)

2011-11-07 Thread Rainer Orth
Hi Paolo, >>> ./config/t-rtems:HOST_LIBGCC2_CFLAGS = >>> -I$(srcdir)/../newlib/libc/sys/rtems/include > > This was LIBGCC2_INCLUDES before your patches. > > You're also missing it in many cases: arm, avr, bfin, moxie, h8300, lm32, > m32r, m68k, mips, powerpc, sh, m32c. As mentioned, I've added a

Re: [patch] 19/n: trans-mem: middle end/misc patches (LAST PATCH)

2011-11-07 Thread Aldy Hernandez
Notice I am hijacking the alias_pair object, because it has everything we need, though the DECL_UID goes in a field called emitted_diags. I am avoiding having to create an exact same object with the exact same fields. I can change duplicate this, if it's a big eye sore. Yes, please duplicat

Re: [build] Restore arm-eabi bootstrap (PR target/50978)

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 06:01 PM, Rainer Orth wrote: Ok for mainline? Ok, thanks. Paolo

Re: cxx-mem-model merge [6 of 9] - libstdc++-v3

2011-11-07 Thread Andrew MacLeod
On 11/07/2011 11:24 AM, Joseph S. Myers wrote: On Mon, 7 Nov 2011, Andrew MacLeod wrote: Actually, this target has no lock free support whatsoever? ie, no compare_and_swap instruction, nor an implementation of sync_lock_test_and_set and sync_lock_release? I think the libstdc++ standard now re

Re: PowerPC shrink-wrap support 3 of 3

2011-11-07 Thread Jakub Jelinek
On Wed, Nov 02, 2011 at 02:03:40AM +1030, Alan Modra wrote: > Bootstrapped and regression tested powerpc-linux. OK to apply? > (And I won't be posting any more versions of the patch until this is > reviewed. Please excuse me for spamming the list.) Looks reasonable to me, appart from > *

[Patch, libfortran] configure cleanup

2011-11-07 Thread Janne Blomqvist
Hi, it's 2011. I think it's fairly safe to assume that, at this point, any target capable of supporting libgfortran also provides C89. Attached patch gets rid of such configure tests, and rips out unused code paths (which likely have never been compiled in the history of libgfortran..) from the li

Re: [RFA/ARM][Patch 01/02]: Thumb2 epilogue in RTL

2011-11-07 Thread Sameera Deshpande
On Mon, 2011-11-07 at 09:56 +, Paul Brook wrote: > > The array REGISTER_NAMES in aout.h use S0, S2, ... names for double > > registers. Is there any way to use OVERLAPPING_REGISTER_NAMES? If that > > can be done, I can eliminate the table here. > > You should be using %P. > Paul, Thanks fo

Re: [Patch, libfortran] PR 46686 Implement backtrace using libgcc functionality

2011-11-07 Thread Janne Blomqvist
PING! On Tue, Nov 1, 2011 at 20:23, Janne Blomqvist wrote: > Hi, > > the attached patch changes the backtracing functionality, which is > used to print a stack trace before aborting when something goes > belly-up, to use the stack unwinding functionality provided by libgcc > instead of using the

Re: [Patch, libfortran] PR 50016 Slow IO on Windows due to _commit()

2011-11-07 Thread Janne Blomqvist
PING! On Mon, Oct 31, 2011 at 20:57, Janne Blomqvist wrote: > Hi, > > here's an updated version of my patch that gets rid of _commit along > with a section in the manual describing data consistency and > durability issues. > > See also the thread starting at > > http://gcc.gnu.org/ml/fortran/2011

Re: cxx-mem-model merge [6 of 9] - libstdc++-v3

2011-11-07 Thread Hans-Peter Nilsson
> From: "Joseph S. Myers" > Date: Mon, 7 Nov 2011 17:24:04 +0100 > On Mon, 7 Nov 2011, Andrew MacLeod wrote: > > > Actually, this target has no lock free support whatsoever? ie, no > > compare_and_swap instruction, nor an implementation of > > sync_lock_test_and_set > > and sync_lock_release?

Re: Patch to fix optabs.c when SWITCHABLE_TARGETS is defined.

2011-11-07 Thread Tom de Vries
On 11/07/2011 04:49 PM, Andrew MacLeod wrote: > On 11/07/2011 09:43 AM, Tom de Vries wrote: >> On 11/06/2011 04:04 PM, Andrew MacLeod wrote: >>> (get_atomic_op_for_code): New. Return an opcode table entry. >> I'm getting these errors with a MIPS cross build: >> ... >> /scratch/vries/b4/ref-mip

Re: C++/c-common PATCH for c++/35688 (wrong visibility of template instantiation)

2011-11-07 Thread Jason Merrill
On 11/06/2011 11:31 PM, Jason Merrill wrote: The function constrain_visibility_for_template tries to set the visibility of a template instantiation properly by giving it the minimum visibility of the template itself and the template arguments. But this PR points out that we were failing to do tha

Re: [patch] 19/n: trans-mem: middle end/misc patches (LAST PATCH)

2011-11-07 Thread Aldy Hernandez
Do not push new_version->lowered setting into the core routine but keep it at the callers. Well, why didn't you say so? :). That can't be hard :). I'm testing this. How does it look? Index: ChangeLog.tm-merge === --- ChangeLog

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-07 Thread Richard Henderson
On 11/06/2011 02:09 AM, Richard Guenther wrote: >> > Richi, do you have any particular issue with the attribs.c change? Does >> > this context resolve any questions you may have had? > ... no, it just looked weird without seeing a use. Now, target specific > attributes on a non-target specific bu

[PR50764, PATCH, PING] Fix for ICE in maybe_record_trace_start with -fsched2-use-superblocks

2011-11-07 Thread Tom de Vries
On 10/30/2011 08:38 AM, Tom de Vries wrote: > On 10/29/2011 09:17 PM, Tom de Vries wrote: >> Richard, >> >> I have a tentative fix for PR50764. >> >> In the example from the test-case, -fsched2-use-superblocks moves an insn >> from >> block 4 to block 3. >> >>2 >> bar >>

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-11-07 Thread Jason Merrill
The bootstrap issues with a recent patch of mine led me to run make check-g++-strict-gc, which turned up a GC problem with this code, fixed thus. Tested x86_64-pc-linux-gnu, applying to trunk. commit f2f82e0908b807a0d339a00b434913fc0886c0cc Author: Jason Merrill Date: Mon Nov 7 09:19:27 2011

Re: C++ PATCH for c++/48370 (extending lifetime of temps in aggregate initialization)

2011-11-07 Thread Jason Merrill
On 11/04/2011 11:23 PM, Jason Merrill wrote: While working on a followup, I noticed that this patch runs temporary cleanups in the wrong order. Fixed (and tested) thus. This patch broke bootstrap because it allocated a gc-able vector and held it across the definition of a function, at the end

Re: Patch to fix optabs.c when SWITCHABLE_TARGETS is defined.

2011-11-07 Thread Richard Henderson
On 11/07/2011 07:49 AM, Andrew MacLeod wrote: > 2011-11-07 Andrew MacLeod > > * optabs.c (get_atomic_op_for_code): Fill in optab table at runtime so > SWITCHABLE_TARGET can change the valuies during compilation. > (expand_atomic_fetch_op): handle parameter changes ripples for

Re: [Patch,AVR]: Clean-up load non-integer constants

2011-11-07 Thread Denis Chertykov
2011/11/7 Georg-Johann Lay : > This is a patch that cleans up the code for loading CONST or SYMBOL_REF into a > register. > > This code is also needed to be able to load symbols into PSImode registers. > > Up to now, this is not needed because there are no 24-bit symbols yet, but it > is needed for

Re: cxx-mem-model merge [6 of 9] - libstdc++-v3

2011-11-07 Thread Andrew MacLeod
On 11/07/2011 12:32 PM, Hans-Peter Nilsson wrote: From: "Joseph S. Myers" Date: Mon, 7 Nov 2011 17:24:04 +0100 On Mon, 7 Nov 2011, Andrew MacLeod wrote: Actually, this target has no lock free support whatsoever? ie, no compare_and_swap instruction, nor an implementation of sync_lock_test_and_s

Re: Patch to fix optabs.c when SWITCHABLE_TARGETS is defined.

2011-11-07 Thread Andrew MacLeod
On 11/07/2011 12:48 PM, Richard Henderson wrote: On 11/07/2011 07:49 AM, Andrew MacLeod wrote: 2011-11-07 Andrew MacLeod * optabs.c (get_atomic_op_for_code): Fill in optab table at runtime so SWITCHABLE_TARGET can change the valuies during compilation. (expand_atomic_fe

Re: Massive breakage with your libgcc patches

2011-11-07 Thread Rainer Orth
Bernd Schmidt writes: > On 11/03/11 20:20, Rainer Orth wrote: >> >> * config/c6x/t-elf (LIB2ADDEH): Set. >> * config/c6x/t-c6x-elf: Remove. > > It builds now, but parts of libgcc are missing. There's no sign of > muldf3, for examples. I found the problem: before, LIB2ADD was passed in

Re: [C++ PATCH] PR c++/45114 - Support alias templates

2011-11-07 Thread Jason Merrill
On 11/07/2011 10:54 AM, Dodji Seketeli wrote: I didn't realize the elaborated-type-specifier case. Fixed now. There still seem to be problems printing the scope: namespace N { template using U = T*; }; void f(N::U) { blah; } wa.C: In function ‘void N::f(U)’: wa.C:6:21: error

[PATCH] SLP vectorize calls (take 2)

2011-11-07 Thread Jakub Jelinek
Hi! On Fri, Oct 21, 2011 at 03:44:11PM +0200, Ira Rosen wrote: > There are vectorizable_type_promotion/demotion, and for the rest the > copies are "hidden" inside multiple vector operands that you get from > vect_get_vec_defs. But, of course, there is not need to handle > modifier == NARROW for SL

[PATCH] Vectorize lrint on x86_64/i686 -m32 -mavx using 32-byte vectors

2011-11-07 Thread Jakub Jelinek
Hi! BUILT_IN_LRINT has been vectorized just using 16-byte vectors, the following patch cures it (of course, for -m64 it unfortunately can't be vectorized, as long there is DImode rather than SImode). Bootstrapped/regtested on x86_64-linux and i686-linux. Ok for trunk? 2011-11-07 Jakub Jelinek

Re: Failure to bootstrap trunk with --enable-threads=posix on cygwin since r180767

2011-11-07 Thread Rainer Orth
Christian Joensson writes: > xgcc: error: unrecognized command line option ‘-pthread’ [...] > Note the --enable-threads=posix. > > Backing off to revision 180766 does not yield this problem, while > 180767 has the problem. I erroneously moved the use of i386/t-mingw-pthread to the cygwin cas

Re: [Patch, Fortran, OOP] PR 50919: Don't use vtable for NON_OVERRIDABLE TBP

2011-11-07 Thread Janus Weil
2011/11/7 Janus Weil : >> Thus, I believe it is rather difficult to run into the ABI issue in the real >> world (due to technical but also due to usage reasons), but it is possible. >> Hence, I wanted to point out that there is an ABI issue, but I also don't >> oppose the committal as it is difficu

Re: [PATCH] Vectorize lrint on x86_64/i686 -m32 -mavx using 32-byte vectors

2011-11-07 Thread Richard Henderson
On 11/07/2011 10:38 AM, Jakub Jelinek wrote: > 2011-11-07 Jakub Jelinek > > * config/i386/i386-bultin-types.def (V8SI_FTYPE_V4DF_V4DF): Add. > * config/i386/i386.c (enum ix86_builtins): Add > IX86_BUILTIN_VEC_PACK_SFIX256. > (bdesc_args): Add __builtin_ia32_vec_pack_sfix

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-07 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/07/11 09:24, Richard Guenther wrote: > On Mon, Nov 7, 2011 at 5:07 PM, Jeff Law wrote: > I also wonder if instead of a new pass control-dependent DCE can be taught of this? > It could. I'm not sure it really buys us anything e

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-07 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/07/11 08:54, Tom Tromey wrote: >> "Jeff" == Jeff Law writes: > > Jeff> So, presumably there's no way to know we're throwing to Jeff> > NullPointerException from the exception information attached to > the Jeff> statement or BB? If not I co

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-07 Thread Richard Henderson
On 11/05/2011 03:09 PM, Richard Guenther wrote: > On Sat, Nov 5, 2011 at 10:05 PM, Aldy Hernandez wrote: >> [rth, see below] >> local_define_builtin ("__builtin_eh_pointer", ftype, BUILT_IN_EH_POINTER, "__builtin_eh_pointer", ECF_PURE | ECF_NOTHROW | EC

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-07 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/07/11 08:49, Richard Guenther wrote: > > OTOH I'm not sure we want to change a possible trap (And thus > program abort) to a fallthru ... I think this is the big question we need to answer; there's other places were we rely upon ISO's standard

Re: [trans-mem] Fix instantiation of transaction expressions.

2011-11-07 Thread Jason Merrill
On 11/07/2011 11:31 AM, Richard Henderson wrote: On 11/07/2011 06:12 AM, Torvald Riegel wrote: stmt = begin_transaction_stmt (input_location, NULL, flags); tmp = RECUR (TRANSACTION_EXPR_BODY (t)); +if (tmp) + { +/* No statements; handle this like

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-07 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/07/11 03:07, Jakub Jelinek wrote: > On Mon, Nov 07, 2011 at 02:55:02AM -0700, Jeff Law wrote: >> [ Working virtually from Hawaii tonight... :-) ] > > ;) > >> You might legitimately wonder how often this triggers. A GCC >> 4.6.0 checking-enab

Re: [PATCH] Vectorize lrint on x86_64/i686 -m32 -mavx using 32-byte vectors

2011-11-07 Thread Uros Bizjak
On Mon, Nov 7, 2011 at 7:38 PM, Jakub Jelinek wrote: > BUILT_IN_LRINT has been vectorized just using 16-byte > vectors, the following patch cures it (of course, for -m64 > it unfortunately can't be vectorized, as long there is DImode > rather than SImode). Hm... Looking at convert.c (around lin

Re: RFA: New pass to delete unexecutable paths in the CFG

2011-11-07 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/07/11 03:21, Richard Guenther wrote: > > Oh, and points-to plus DSE/DCE might confuse your pass as stores > that points-to can prove go "nowhere" are removed. I think this is OK in the sense that we may miss a case where we could have detected

patch - __sync_lock_test_and_set, __sync_lock_release fallback expansion

2011-11-07 Thread Andrew MacLeod
Originally I had __atomic_exchange falling back to __sync_lock_test_and_set, and __atomic_store falling back to __sync_lock_release whenever the _atomic variation wasn't specified. On some limited targets, functionality of these two operations can be restrictedt. rth had already removed the s

Re: patch - __sync_lock_test_and_set, __sync_lock_release fallback expansion

2011-11-07 Thread Richard Henderson
On 11/07/2011 11:13 AM, Andrew MacLeod wrote: > libstdc++-v3 > * include/bits/atomic_base.h (atomic_thread_fence): Call builtin. > (atomic_signal_fence): Call builtin. > (atomic_flag::test_and_set): Call __atomic_exchange when it is lockfree, > otherwise fall back to c

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-07 Thread Aldy Hernandez
I hope this cleanup both addresses the above questions and tidies things up as indicated. Please ask if you've got more questions. BTW, please add a merged changelog entry to ChangeLog.tm-merge. No need for a ChangeLog.tm, unless we don't merge, in case we're back to ChangeLog.tm for a com

Re: [trans-mem] Fix instantiation of transaction expressions.

2011-11-07 Thread Torvald Riegel
On Mon, 2011-11-07 at 14:04 -0500, Jason Merrill wrote: > On 11/07/2011 11:31 AM, Richard Henderson wrote: > > On 11/07/2011 06:12 AM, Torvald Riegel wrote: > >> stmt = begin_transaction_stmt (input_location, NULL, flags); > >> tmp = RECUR (TRANSACTION_EXPR_BODY (t)); > >> +

Re: [patch tree-optimization 1/2]: Branch-cost optimizations

2011-11-07 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/07/11 09:14, Richard Guenther wrote: >> >> Well, not that I noticed that I missed here any freedom. In >> what cases you mean I would need here freedom to create new >> ssa-statements? > > You lookup SSA_NAME_DEF_STMTs of SSA names - you cann

Re: [trans-mem] Fix instantiation of transaction expressions.

2011-11-07 Thread Richard Henderson
On 11/07/2011 11:33 AM, Torvald Riegel wrote: > Fix instantiation of transaction expressions. > > * cp/pt.c (tsubst_expr) [TRANSACTION_EXPR]: If body is not a > statement, create an expression instead. > * cp/cp-tree.h (TRANSACTION_EXPR_IS_STMT, build_transaction_expr): N

Re: [patch tree-optimization 1/2]: Branch-cost optimizations

2011-11-07 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/07/11 07:38, Richard Guenther wrote: > > > The cond_chain stuff should be as we have discussed quite some > time ago on IRC - modeled after tree-affine.c - a "vector" of > predicates of the form [~] A op B, combined using logical AND or > OR (t

[patch] add missing option to "C++ Language Options" docs

2011-11-07 Thread Jonathan Wakely
When I added this option I failed to add it to the options summary. * doc/invoke.texi (C++ Language Options): Add missing -Wdelete-non-virtual-dtor option. OK to commit? Index: doc/invoke.texi === --- doc/invoke.texi

Re: [patch tree-optimization 1/2]: Branch-cost optimizations

2011-11-07 Thread Kai Tietz
2011/11/7 Jeff Law : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 11/07/11 09:14, Richard Guenther wrote: > >>> >>> Well, not that I noticed that I missed here any freedom.  In >>> what cases you mean I would need here freedom to create new >>> ssa-statements? >> >> You lookup SSA_NAME_

Re: [patch] 19/n: trans-mem: middle end/misc patches (LAST PATCH)

2011-11-07 Thread Aldy Hernandez
On 11/07/11 09:43, Aldy Hernandez wrote: Do not push new_version->lowered setting into the core routine but keep it at the callers. Well, why didn't you say so? :). That can't be hard :). I'm testing this. How does it look? rth approved this off-list. I have just committed. Richi, if yo

Re: [C++ Patch] PR 50864

2011-11-07 Thread Jason Merrill
On 10/28/2011 08:10 PM, Paolo Carlini wrote: I reverted it. Had inadvertently tested with checking disabled, the problem with checking enabled happens earlier than that. Was there a problem with the patch? It still looks correct even if it doesn't fix this testcase, so there's no need to reve

Re: [Patch, Fortran, committed] Add libquadmath testcase gfortran.dg/quad_2.f90

2011-11-07 Thread Eric Botcazou
> The test uses the largest available floating-point number - be it 8, 10 > or 16 - and tests for that. The checks should be thus OK for any system. It fails with a link failure on SPARC Solaris 8 and 9: FAIL: gfortran.dg/quad_2.f90 -O0 (test for excess errors) Excess errors: Undefined

Re: [PATCH i386] PR47698 no CMOV for volatile mem

2011-11-07 Thread Eric Botcazou
> 2011-11-06 Sergey Ostanevich sergos@gmail.com > > PR rtl-optimization/47698 > * ifconv.c (noce_operand_ok): prevent CMOV generation > for volatile mem There is no such file as ifconv.c though. The first letter must be capitalized and there must be a period at the end. A

[PATCH] AIX fixincludes for pthread.h

2011-11-07 Thread David Edelsohn
As part of the fallout from PR 50982, this patch adds some new fixes to GCC fixincludes that corrects a syntax error in an array initializer for PTHREAD_ONCE_INIT. The incorrect header file still is present in AIX 7.1; I have reported the bug to AIX as well. * inclhack.def (aix_once_init_

Re: [v3] add missing dg-require to tests

2011-11-07 Thread Eric Botcazou
> Tested x86_64-linux and committed to trunk. > > * testsuite/30_threads/async/49668.cc: Add missing dg-require. > * testsuite/30_threads/packaged_task/49668.cc: Likewise. We have a related failure on SPARC/Solaris for some time: FAIL: 30_threads/call_once/49668.cc (test for exces

Re: [Patch, Fortran, committed] Add libquadmath testcase gfortran.dg/quad_2.f90

2011-11-07 Thread Steve Kargl
On Mon, Nov 07, 2011 at 09:55:48PM +0100, Eric Botcazou wrote: > > The test uses the largest available floating-point number - be it 8, 10 > > or 16 - and tests for that. The checks should be thus OK for any system. > > It fails with a link failure on SPARC Solaris 8 and 9: > > FAIL: gfortran.dg/

[PATCH, i386]: Vectorize BUILT_IN_{I,LL}RINT{,F} when appropriate

2011-11-07 Thread Uros Bizjak
Hello! Attached patch fixes omission from "(int) rint ()" conversion to __builtin_irint (). We can vectorize this function when out_mode is SImode, no matter how the builtin is called. Throw in also BUILT_IN_LLRINT, just for completion ... 2011-11-07 Uros Bizjak * config/i386/i386.c (

Re: Implement C1X _Alignas, _Alignof, max_align_t, stdalign.h

2011-11-07 Thread Eric Botcazou
> 2011-11-06 Joseph Myers > > * g++.dg/cpp0x/alignof3.C, gcc.dg/c1x-align-1.c, > gcc.dg/c1x-align-2.c, gcc.dg/c1x-align-3.c, gcc.dg/c1x-align-4.c, > gcc.dg/c90-align-1.c, gcc.dg/c99-align-1.c: New tests. > * gcc.dg/gnu89-const-expr-1.c, gcc.dg/gnu90-const-expr-1.c, >

Re: [v3] add missing dg-require to tests

2011-11-07 Thread Jonathan Wakely
On 7 November 2011 20:58, Eric Botcazou wrote: >> Tested x86_64-linux and committed to trunk. >> >>         * testsuite/30_threads/async/49668.cc: Add missing dg-require. >>         * testsuite/30_threads/packaged_task/49668.cc: Likewise. > > We have a related failure on SPARC/Solaris for some time

[PATCH] Avoid frame pointer and stack realignment in AVX/AVX2 using fns if they don't touch sp/fp

2011-11-07 Thread Jakub Jelinek
Hi! As I've mentioned during the weekend, currently all functions that use 32-byte vectors end up with frame pointer and stack realignment (except when they have some 32-byte aligned argument, but that means 9+ arguments, so quite unlikely). The stack realignment is there just in case, if reloade

Re: [C++ Patch] PR 50864

2011-11-07 Thread Paolo Carlini
On 11/07/2011 09:39 PM, Jason Merrill wrote: On 10/28/2011 08:10 PM, Paolo Carlini wrote: I reverted it. Had inadvertently tested with checking disabled, the problem with checking enabled happens earlier than that. Was there a problem with the patch? It still looks correct even if it doesn't

[PATCH] Emit vperm2[if]128 $0x12/$0x20 as vinsert[if]128 $0/$1

2011-11-07 Thread Jakub Jelinek
Hi! I think it is at least more readable and perhaps for some CPUs could be faster (for SandyBridge it is the same speed) if we emit a more specialized insn over a more generic one. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? In the attachment is my first attempt to do t

Re[2]: [CRIS] Convert CRIS to constraints.md

2011-11-07 Thread Anatoly Sokolov
Hi. > From: Hans-Peter. > Date: 5 Nov 2011 г., 5:24:20: >> +(define_constraint "S" >> + "PIC-constructs for symbols." >> + (and (match_test "flag_pic") >> + (match_code "const") >> + (match_test "cris_valid_pic_const (op, false)"))) > Can you really have other than two operands to

[PATCH] Improve VEC_BASE

2011-11-07 Thread Jakub Jelinek
Hi! This patch attempts to optimize VEC_BASE if we know that offsetof of base is 0 (unless the compiler is doing something strange, it is true). It doesn't have a clear code size effect, some .text sections grew, supposedly because of more inlining, some .text sections shrunk. Bootstrapped/regtes

[lra] patch rewriting inheritance and speeding LRA up

2011-11-07 Thread Vladimir Makarov
The following patch contains a major rewriting inheritance code to permit inheritance from non-reload insns. That is important for targets (like x86-64) permitting memory in general insns and as a result considerably decreasing code size. Now LRA can do the following transformations: p

Re: Disable early inlining while compiling for coverage (issue5173042)

2011-11-07 Thread Sharad Singhai
Honza, Sorry, I forgot about this. Could you please put this on your TODO list? David, While a proper fix is pending for the trunk, we need this interim fix internally. Okay for google/main? Thanks, Sharad On Sun, Oct 2, 2011 at 3:08 AM, Jan Hubicka wrote: >> >> I believe Richi opent PR back wh

Patch RFA: Add context switching splitstack routines

2011-11-07 Thread Ian Lance Taylor
This patch adds some support for context switching to the -fsplit-stack support routines in libgcc. I intend to use this in the Go library to support multiplexing multiple goroutines onto a single pthread. They work similarly to getcontext/setcontext/makecontext. This patch also adds control ove

[C++11] Add cstdalign to precompiled headers.

2011-11-07 Thread 3dw4rd
Subject says it all. It's a one liner. Bootstrapped on x86_64-redhat-linux. Testing is ongoing. Ed patch Description: Binary data CL Description: Binary data

revert patch

2011-11-07 Thread Andrew MacLeod
I had to revert a minor change in the last patch. It didn't show any problems in an incremental bootstrap, but once from scratch showed a compile failure due to a duplicate definition. I'll have to fix the lack of an atomic_thread_fence or atomic_signal_fence a different way apparently. Sor

[patch] c++/2972 warn when ctor-initializer leaves uninitialized data

2011-11-07 Thread Jonathan Wakely
This is a new version of my -Wmeminit patch, first posted to PR c++/2972. Jason suggested combining the Wmeminit warning with the adjacent Weffc++ one which I agree with. The advice in the Effective C++ book actually says not to leave members uninitialized, rather than saying *all* members must h

Re: [C++ Patch / RFC] PR 50864

2011-11-07 Thread Jason Merrill
On 10/26/2011 04:35 PM, Paolo Carlini wrote: We have that parser->scope is a RECORD_TYPE and postfix_expression is an INDIRECT_REF. Ah, OK. I guess we swallow up the namespace while parsing the full nested-name-specifier and it isn't a problem. So I think handling this here should be OK. B

Patch ping

2011-11-07 Thread Jakub Jelinek
Hi! I'd like to ping the restrict_based_on_field attribute patch: http://gcc.gnu.org/ml/gcc-patches/2011-10/msg00135.html We currently don't do cast restricts and even if we do them again, as this attribute doesn't make the type __restrict it wouldn't affect those, it only affects parameters, if

Re: [patch] c++/2972 warn when ctor-initializer leaves uninitialized data

2011-11-07 Thread Jason Merrill
On 11/07/2011 04:43 PM, Jonathan Wakely wrote: Unfortunately this doesn't work very well in C++11 mode, as defaulted constructors don't cause warnings when they should do e.g. Maybe check this in defaulted_late_check? Jason

<    1   2   3   >