Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-05 Thread Aldy Hernandez
On 11/04/11 08:26, Michael Matz wrote: Hi, On Thu, 3 Nov 2011, Aldy Hernandez wrote: +/* GIMPLE_EH_ELSE must be the sole contents of + a GIMPLE_TRY_FINALLY node. For all normal exits from the try block, + we N_BODY is run; for all exception exits from the try block, s/we // Fixed

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-05 Thread Richard Guenther
On Sat, Nov 5, 2011 at 3:24 AM, Richard Henderson wrote: > On 11/04/2011 04:53 PM, Aldy Hernandez wrote: >>> Why is it necessary to know whether a clone is a tm clone? >> >> How do you mean?  First, there are a few pretty printing places where we >> dump that a function is a clone.  It is easy to

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-05 Thread Richard Guenther
On Sat, Nov 5, 2011 at 3:54 AM, Richard Henderson wrote: > On 11/04/2011 07:36 PM, Richard Henderson wrote: >> On 11/04/2011 03:36 AM, Richard Guenther wrote: > +    case GIMPLE_TRANSACTION: > +      return (weights->tm_cost > +             + estimate_num_insns_seq (gimple_transaction_

[doc] Fix a cross reference

2011-11-05 Thread Mingjie Xing
Hello, This small patch fix a cross reference in gcc document. 2011-11-05 Mingjie Xing * doc/invoke.texi (Wunused-result): Change @pxref{Variable Attributes} to @pxref{Function Attributes}. Is it OK? Thanks Mingjie Index: doc/invoke.texi =

Re: [PING #2] Pass address space to REGNO_MODE_CODE_OK_FOR_BASE_P

2011-11-05 Thread Georg-Johann Lay
Ulrich Weigand wrote: The following patch still needs maintainer review: http://gcc.gnu.org/ml/gcc-patches/2011-10/msg01874.html Thanks, Ulrich ...me too looking forward to this being reviewed. Thanks, Johann

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-05 Thread Eric Botcazou
> Here is a patch which fixes redundant zero extensions problem. Issue > is resolved by expanding implicit_zee pass functionality to cover zero > and sign extends of different modes. Could please someone review it? Could you explain the undelying idea? The current strategy of implicit-zee.c is e

Re: [PATCH] strlenopt improvements

2011-11-05 Thread Eric Botcazou
> The man page is outdated, stpcpy is a standard POSIX2008 function. Sorry for being so 20th century-ish. :-) > Anyway, in the other gcc.dg/strlenopt-* testcases for USE_GNU I was using > the convention that the name ended with g (i.e. strlenopt-22g.c) and > the test would start with: > /* This t

Re: [PATCH] Fix early inliner inlining uninlinable functions

2011-11-05 Thread Iain Sandoe
On 28 Oct 2011, at 13:57, Richard Guenther wrote: We fail to keep the cannot-inline flag up-to-date when turning indirect to direct calls. The following patch arranges to do this during statement folding (which should always be called when that happens). It also makes sure to copy the update

Re: [PATCH] strlenopt improvements

2011-11-05 Thread Jakub Jelinek
On Sat, Nov 05, 2011 at 11:44:27AM +0100, Eric Botcazou wrote: > Thanks for the tip. Tested on Solaris 8 and Linux, applied on the mainline. Thanks. > @@ -32,10 +31,9 @@ main () >return 0; > } > > -/* { dg-final { scan-tree-dump-times "strlen \\(" 0 "strlen" } } */ > +/* { dg-final { scan

Re: [Patch]: Fix PR rtl-optimization/50448

2011-11-05 Thread Georg-Johann Lay
Paolo Bonzini wrote: > On 11/04/2011 09:50 AM, Eric Botcazou wrote: >> + /* If above failed and this is a single set, try to simplify the >> source of >> + the set given our substitution. We could perhaps try this for >> multiple >> + SETs, but it probably won't buy us anything. */ >>

Re: [Patch]: Fix PR rtl-optimization/50448

2011-11-05 Thread Eric Botcazou
> PR rtl-optimization/50448 > * cprop.c (try_replace_reg): Also try to replace uses of FROM that > appear in SET_DEST. OK if it passes testing, with s/addr/dest/ as addr isn't an address at all. > IMO the head comment is still misleading because it might give rise to the > assum

Re: PATCH: Move f16c intrinsics into f16cintrin.h

2011-11-05 Thread Eric Botcazou
> Reposting, okay to commit after testing on x86_64 if no regressions? The patch wasn't correctly installed and the ChangeLog is incomplete. * config/i386/f16cintrin.h: Contents moved from immintrin.h. * config/i386/immintrin.h: Include f16cintrin.h. * config.gcc (i[34567

Re: [v3] use NSDMI in C++11 mutex types

2011-11-05 Thread Jonathan Wakely
Also use NSDMI for std::once_flag PR libstdc++/49894 PR bootstrap/50982 * include/std/mutex (once_flag): Use NSDMI. tested x86_64-linux, committed to trunk. Index: include/std/mutex === --- include/std/mutex

Re: [Patch]: Fix PR rtl-optimization/50448

2011-11-05 Thread Georg-Johann Lay
Eric Botcazou wrote: >> PR rtl-optimization/50448 >> * cprop.c (try_replace_reg): Also try to replace uses of FROM that >> appear in SET_DEST. > > OK if it passes testing, with s/addr/dest/ as addr isn't an address at all. Ok, it's here: http://gcc.gnu.org/viewcvs?view=revision&re

VZEROUPPER for simple_return?

2011-11-05 Thread Jakub Jelinek
Hi! On Sat, Nov 05, 2011 at 10:50:44AM +0100, Jakub Jelinek wrote: > On the following testcase with -m64 -O3 -mavx2 (but it is just an example, > you can replace the loop there with any code that doesn't touch the > stack or frame pointer at all), only f3 is shrink wrapped and in that case > it on

Re: C++ PATCH for c++/26714 (lifetime of temps in mem-initializers for reference members)

2011-11-05 Thread Iain Sandoe
On 5 Nov 2011, at 03:24, Jason Merrill wrote: After my previous patch for 48370 which adds extend_ref_init_temps, it is straightforward to fix this issue as well by extending ref init mem-initializers to match the lifetime of 'this'. Tested x86_64-pc-linux-gnu, applying to trunk. commit 30

Re: [Patch, libfortran] PR 45723 Revert previous fix

2011-11-05 Thread Jerry DeLisle
On 10/31/2011 11:51 AM, Janne Blomqvist wrote: Hi, I'd like to revert the fix for PR 45723 that was committed previously for the following reasons: - Using stat("/path/to/file", ...) to infer something about an open file descriptor is racy. - As I argued in http://gcc.gnu.org/ml/fortran/2011-1

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-05 Thread Aldy Hernandez
Richi, if it's the use of the bit in the tree node that you're worried about, we could probably put it in cgraph_node.local instead. But we do need the knowledge. Yeah, I was worried about /* 1 bit left */ ;) Putting it in the cgraph node sounds more appealing indeed. Richi, is this a blo

SPU build broken (Re: CFT: [build] Move libgcc2 to toplevel libgcc)

2011-11-05 Thread Ulrich Weigand
Rainer Orth wrote: > diff --git a/gcc/config/spu/t-spu-elf b/gcc/config/spu/t-spu-elf > -# We exclude those because the libgcc2.c default versions do not support > -# the SPU single-precision format (round towards zero). We provide our > -# own versions below and/or via direct expansion. > -LIB2

Re: [Patch, Fortran] Cleanup of gfc_extend_expr

2011-11-05 Thread William Clodius
Sounds like what everything needs is a differently named enum: say three_way_logic. On Nov 3, 2011, at 3:56 PM, Janus Weil wrote: >> At least add a comment about the re-use (abuse?) of the >> enum. > > Updated patch attached, which adds a short comment on the usage of 'match'. > > >> This sho

Re: [commited, rtems] Sync gcc/config/rs6000/*rtems* with RTEMS-gcc

2011-11-05 Thread Joseph S. Myers
I'd like to remind you that specs such as %{!Dppc*: %{!Dmpc*: -Dppc8540}} (which you were adding to match existing specs) have been broken for some time, since the canonical form of -D options now has separate arguments (and they would never have worked with separate-argument -D options). * Def

Re: [doc] Fix a cross reference

2011-11-05 Thread Joseph S. Myers
On Sat, 5 Nov 2011, Mingjie Xing wrote: > Hello, > > This small patch fix a cross reference in gcc document. > > 2011-11-05 Mingjie Xing > > * doc/invoke.texi (Wunused-result): Change @pxref{Variable Attributes} > to @pxref{Function Attributes}. > > Is it OK? OK. -- Josep

put __stl_prime_list in comdat section

2011-11-05 Thread Xinliang David Li
Hi, the following patch is a follow up to the one posted here http://gcc.gnu.org/ml/gcc-patches/2009-05/msg01293.html. The new patch is a header only change and can greatly reduce rodata section size for some programs. Ok for trunk after testing? thanks, David cl Description: Binary data st

Re: put __stl_prime_list in comdat section

2011-11-05 Thread Paolo Carlini
On 11/05/2011 07:32 PM, Xinliang David Li wrote: Hi, the following patch is a follow up to the one posted here http://gcc.gnu.org/ml/gcc-patches/2009-05/msg01293.html. The new patch is a header only change and can greatly reduce rodata section size for some programs. Ok for trunk after testing?

Re: New port^2: Renesas RL78

2011-11-05 Thread Richard Henderson
On 11/04/2011 10:09 PM, DJ Delorie wrote: > The problem I'm trying to solve with that is that there's only one > segment register (ES) so you only need to force an operand non-far if > *both* operands are far. Not sure if the function is implemented that > way, but I coded the expanders that way.

[v3] Re: put __stl_prime_list in comdat section

2011-11-05 Thread Xinliang David Li
thanks. The attached is the revised patch. David On Sat, Nov 5, 2011 at 11:52 AM, Paolo Carlini wrote: > On 11/05/2011 07:32 PM, Xinliang David Li wrote: >> >> Hi, the following patch is a follow up to the one posted here >> http://gcc.gnu.org/ml/gcc-patches/2009-05/msg01293.html. >> >> The new

Re: PATCH: Check HARD_FRAME_POINTER_REGNUM instead of hard_frame_pointer_rtx in dwarf2out_frame_debug_expr

2011-11-05 Thread Richard Henderson
On 11/04/2011 01:29 PM, H.J. Lu wrote: > 2011-11-04 H.J. Lu > > * dwarf2cfi.c (dwarf2out_frame_debug_expr): Check > HARD_FRAME_POINTER_REGNUM instead of hard_frame_pointer_rtx > in Rule 18. Ok. r~

Re: RFA: Add Epiphany port

2011-11-05 Thread Richard Henderson
> #define __builtin_epiphany_fmsub(a, b, c) __builtin_fmaf (-b, c, a) Needs -(b), or conversion to __always_inline__ functions, as with the intrinsics used by the i386 target. Otherwise, you've taken care of all of my concerns. r~

Re: [patch] 3/n: trans-mem: runtime

2011-11-05 Thread Gerald Pfeifer
On Thu, 3 Nov 2011, Aldy Hernandez wrote: > --- libitm/method-wbetl.cc(.../trunk) (revision 0) > +++ libitm/method-wbetl.cc(.../branches/transactional-memory) > (revision 180773) > @@ -0,0 +1,628 @@ > +/* Copyright (C) 2009 Free Software Foundation, Inc. > + Contributed by Richard Hen

cxx-mem-model merge ... status

2011-11-05 Thread Andrew MacLeod
So the comments seem have quieted down yesterday afternoon and today. There was nothing too major, mostly it was documentation issues. Is it OK to apply the patches to mainline? If its OK, I'd like to try applying them sunday morning... Any further issues/comment can be dealt with after mer

[Patch, Fortran, committed] Add libquadmath testcase gfortran.dg/quad_2.f90

2011-11-05 Thread Tobias Burnus
Motivated by the report at http://groups.google.com/group/comp.lang.fortran/browse_thread/thread/6373a2dfe64f0b83 There is currently no run-test check that libquadmath actually works. The attached and committed (Rev. 181015) adds one which tests for libquadmath that I/O read/write works. Addi

Re: [trans-mem] document -fgnu-tm

2011-11-05 Thread Gerald Pfeifer
On Thu, 3 Nov 2011, Aldy Hernandez wrote: > OK for branch? * doc/invoke.texi (C Dialect Options): Document -fgnu-tm. Index: doc/invoke.texi === +When the option @option{-fgnu-tm} is specified, the compiler will +generate code

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-05 Thread Aldy Hernandez
[rth, see below] local_define_builtin ("__builtin_eh_pointer", ftype, BUILT_IN_EH_POINTER, "__builtin_eh_pointer", ECF_PURE | ECF_NOTHROW | ECF_LEAF); + if (flag_tm) +apply_tm_attr (builtin_decl_explicit (BUILT_IN_EH_POINTER), + get_identifier ("t

Re: [trans-mem] document -fgnu-tm

2011-11-05 Thread Aldy Hernandez
Torvald, is this documentation somewhere public whose link we can add to the committed patch below? I know the latest draft is not available, but at least Revision 1.1 which we reference below? Aldy +Memory ABI specification document (Revision 1.1, May 6 2009). This is +an experimental feat

Re: [trans-mem] document -fgnu-tm

2011-11-05 Thread Torvald Riegel
On Sat, 2011-11-05 at 14:08 -0700, Aldy Hernandez wrote: > > Torvald, is this documentation somewhere public whose link we can add to > the committed patch below? I know the latest draft is not available, but > at least Revision 1.1 which we reference below? I don't know of any stable URL. The A

Re: PATCH: Add capability to contrib/compare_tests to handle directories

2011-11-05 Thread Mike Stump
On Nov 4, 2011, at 8:23 PM, Quentin Neill wrote: > This patch concatenates the common .sum files before comparing. > > Okay to commit? Ok, thanks for the contribution.

Re: C++ PATCH for c++/26714 (lifetime of temps in mem-initializers for reference members)

2011-11-05 Thread Jason Merrill
On 11/05/2011 10:32 AM, Iain Sandoe wrote: either this or the previous patch has broken (or exposed a problem which has broken) bootstrap on i686-darwin9 with: I've mostly reverted the previous patch, does that fix bootstrap for you? I don't understand yet what the problem is. Jason

Re: C++ PATCH for c++/26714 (lifetime of temps in mem-initializers for reference members)

2011-11-05 Thread Iain Sandoe
On 5 Nov 2011, at 21:30, Jason Merrill wrote: On 11/05/2011 10:32 AM, Iain Sandoe wrote: either this or the previous patch has broken (or exposed a problem which has broken) bootstrap on i686-darwin9 with: I've mostly reverted the previous patch, does that fix bootstrap for you? I don't

Re: [trans-mem] document -fgnu-tm

2011-11-05 Thread Richard Henderson
On 11/05/2011 02:25 PM, Torvald Riegel wrote: > I don't know of any stable URL. The ABI PDF is linked to from > http://software.intel.com/en-us/articles/intel-c-stm-compiler-prototype-edition/ > but I don't think the final URL is supposed to be used for deep linking, > or guaranteed to be stable.

Re: [PATCH 1/1] sparc leon: Use -Aleon assembler switch for -mcpu=leon arch

2011-11-05 Thread David Miller
From: Konrad Eisele Date: Tue, 1 Nov 2011 10:22:13 +0100 > Use -Aleon to enable binutils sparc-leon architecture. The leon-arch > binutils GAS has umul/smul and casa enabled. > > Signed-off-by: Konrad Eisele You can't just add new assembler options that are only right now being added to binut

Re: [trans-mem] document -fgnu-tm

2011-11-05 Thread Torvald Riegel
On Sat, 2011-11-05 at 14:38 -0700, Richard Henderson wrote: > On 11/05/2011 02:25 PM, Torvald Riegel wrote: > > I don't know of any stable URL. The ABI PDF is linked to from > > http://software.intel.com/en-us/articles/intel-c-stm-compiler-prototype-edition/ > > but I don't think the final URL is s

Re: C++ PATCH for c++/26714 (lifetime of temps in mem-initializers for reference members)

2011-11-05 Thread Iain Sandoe
On 5 Nov 2011, at 21:32, Iain Sandoe wrote: On 5 Nov 2011, at 21:30, Jason Merrill wrote: On 11/05/2011 10:32 AM, Iain Sandoe wrote: either this or the previous patch has broken (or exposed a problem which has broken) bootstrap on i686-darwin9 with: I've mostly reverted the previous patc

Re: cxx-mem-model merge ... status

2011-11-05 Thread Richard Guenther
On Sat, Nov 5, 2011 at 9:47 PM, Andrew MacLeod wrote: > So the comments seem have quieted down yesterday afternoon and today. There > was nothing too major, mostly it was documentation issues. > > Is it OK to apply the patches to mainline?   If its OK, I'd like to try > applying them sunday mornin

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-05 Thread Richard Guenther
On Sat, Nov 5, 2011 at 4:09 PM, Aldy Hernandez wrote: > >>> Richi, if it's the use of the bit in the tree node that you're worried >>> about, >>> we could probably put it in cgraph_node.local instead.  But we do need >>> the >>> knowledge. >> >> Yeah, I was worried about /* 1 bit left */ ;)  Putti

Re: [trans-mem] document -fgnu-tm

2011-11-05 Thread Tobias Burnus
Richard Henderson wrote: We have the GCC wiki. We can put a copy there and know that it's going to be stable. Jumping on that topic: Is there actually a possibility to "undo" attachment deletes in the wiki? I remember someone using an recursive "wget" on the wiki, which deleted Graphite PDFs

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-05 Thread Richard Guenther
On Sat, Nov 5, 2011 at 10:05 PM, Aldy Hernandez wrote: > [rth, see below] > >>>   local_define_builtin ("__builtin_eh_pointer", ftype, >>> BUILT_IN_EH_POINTER, >>>                        "__builtin_eh_pointer", ECF_PURE | ECF_NOTHROW | >>> ECF_LEAF); >>> +  if (flag_tm) >>> +    apply_tm_attr (bui

Re: [PATCH] Straight-line strength reduction, stage 1

2011-11-05 Thread William J. Schmidt
On Fri, 2011-11-04 at 14:55 +0100, Richard Guenther wrote: > On Sun, Oct 30, 2011 at 5:10 PM, William J. Schmidt > wrote: > > > > You do not seem to transform stmts on-the-fly, so for > > a1 = c + d; > a2 = c + 2*d; > a3 = c + 3*d; > > are you able to generate > > a1 = c + d; > a2 = a1 + d; >

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-05 Thread Aldy Hernandez
[rth, see below] Index: gcc/attribs.c === --- gcc/attribs.c (.../trunk) (revision 180744) +++ gcc/attribs.c (.../branches/transactional-memory) (revision 180773) @@ -166,7 +166,8 @@ init_attributes (void)

Re: [C++ PATCH] PR c++/45114 - Support alias templates

2011-11-05 Thread Dodji Seketeli
Jason Merrill writes: > On 10/27/2011 03:10 PM, Dodji Seketeli wrote: > > +/* Setter for the TYPE_DECL_ALIAS_P proprety above. */ > > +#define SET_TYPE_DECL_ALIAS_P(NODE, VAL) \ > > + (DECL_LANG_FLAG_6 (TYPE_DECL_CHECK (NODE)) = (VAL)) > > This seems unnecessary. Removed. > >

[v3] update c++0x status table w.r.t emplace member of associate containers

2011-11-05 Thread Jonathan Wakely
PR libstdc++/44436 * doc/xml/manual/status_cxx200x.xml: Document emplace members are missing. committed to trunk Index: doc/xml/manual/status_cxx200x.xml === --- doc/xml/manual/status_cxx200x.xml (revision 180

[v3] fix dg-warning examples in docs

2011-11-05 Thread Jonathan Wakely
* doc/xml/manual/test.xml: Fix dg-warning examples. Committed to trunk Index: doc/xml/manual/test.xml === --- doc/xml/manual/test.xml (revision 181010) +++ doc/xml/manual/test.xml (working copy) @@ -609,10 +609,10 @@ // { dg-

[PATCH] More improvements to sparc VIS vec_init code generation.

2011-11-05 Thread David Miller
Eric, the testsuite target tests for vis2 and vi3 capable hardware work well in my own testing but if you find some problem with how it's done just let me know and I'll try to fix it up. I'm almost %100 satisfied with the code generation for vec_init now. The one remaining case where I think we c

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-05 Thread Aldy Hernandez
Well - we usually don't grab bits off the tree nodes lightly. Especially if the cgraph seems to be more fit. If this is a suggestion, I can put it on my laundry list of future things todo (after merge, 4.8?, etc). There are not many consumers of the flag, so fixing it shouldn't be hard. For

Re: [patch] 3/n: trans-mem: runtime

2011-11-05 Thread Aldy Hernandez
On 11/05/11 13:40, Gerald Pfeifer wrote: On Thu, 3 Nov 2011, Aldy Hernandez wrote: --- libitm/method-wbetl.cc (.../trunk) (revision 0) +++ libitm/method-wbetl.cc (.../branches/transactional-memory) (revision 180773) @@ -0,0 +1,628 @@ +/* Copyright (C) 2009 Free Software Foundation,

Re: [C++ PATCH] PR c++/45114 - Support alias templates

2011-11-05 Thread Jason Merrill
On 11/05/2011 07:36 PM, Dodji Seketeli wrote: +#define TYPE_DECL_NAMES_ALIAS_TEMPLATE_P(NODE) \ This doesn't seem to be needed anymore. +dump_alias_template_specialization (tree t, int flags) +{ + gcc_assert (alias_template_specialization_p (t)); + + if (CLASS_TYPE_P