Re: [PATCH 2/3] canonicalize_loop_ivs should not generate unsigned types.

2011-07-25 Thread Richard Guenther
On Sun, 24 Jul 2011, Sebastian Pop wrote: > On Sun, Jul 24, 2011 at 05:59, Richard Guenther > wrote: > > For two IVs with the same precision, one signed and one unsigned you choose > > signedness of the canonical IV based on the random order of PHIs - that > > doesn't > > look correct. > > > > I

Re: [Patch] [C++0x] Support decltype-specifier as start of nested-name-specifier. (Bug 6709)

2011-07-25 Thread Adam Butcher
On Fri, July 22, 2011 10:23 pm, Jason Merrill wrote: > On 07/21/2011 11:48 AM, Adam Butcher wrote: >> No worries. I'm guilty of not checking mails for months due to other >> commitments so didn't see either of your responses (or the committed >> fix) on this decltype stuff until now. > > I was beg

[Melt] Fix foreach_edge_bb_precs

2011-07-25 Thread Romain Geissler
Hello, This iteratoc won't work because of a little typo error (the previous edge field is preDs and not preCs). To avoid future errors, i apply the global /precs/preds/ change (and thus the iterator is renamed). Romain Geissler Changelog Description: Binary data foreach_edge_bb_preds.diff De

Re: [patch] Fix inlining glitch

2011-07-25 Thread Richard Guenther
On Sun, Jul 24, 2011 at 7:12 PM, Eric Botcazou wrote: > Hi, > > we sometimes get messages like this in Ada: > > prime-mc2-other.adb: In function 'PRIME.MC2.OTHER.DO_SOMETHING': > prime-mc2.adb:2:4: warning: inlining failed in call > to 'PRIME.MC2.GET_INPUT_VALUE.PART': non-call exception handling

Re: [PATCH] Fix PR 49671 volatile goes missing after inlining

2011-07-25 Thread Richard Guenther
On Mon, Jul 25, 2011 at 1:34 AM, Andrew Pinski wrote: > Hi, >  There are two issues, first the inliner does not copy a volatile > when creating a new tree in one case.  The second issue is that > IPA-SRA does not check if we are deferencing a pointer variable via a > volatile type. > > OK?  Bootst

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Ulrich Weigand
Richard Guenther wrote: > On Sun, Jul 24, 2011 at 2:02 PM, Ira Rosen wrote: > > On 21 July 2011 15:19, Ira Rosen wrote: > >> I reproduced the failure. It occurs without Richard's > >> (http://gcc.gnu.org/ml/gcc-patches/2011-07/msg01022.html) and this > >> patches too. Obviously the vectorized loo

Re: vect-70.c fails on spu-elf

2011-07-25 Thread Ulrich Weigand
Ira Rosen wrote: > "Ulrich Weigand" wrote on 22/07/2011 05:05:57 PM: > > Any suggestions how to fix this? Maybe decrease N again and instead > > prevent unrolling via command line switch? > > There is no flag for this unrolling, but we can run the test with -O1 > instead of -O2 (and with N=12) b

Re: ARM: Clear icache when creating a closure

2011-07-25 Thread Andrew Haley
On 21/07/11 16:33, Joseph S. Myers wrote: > On Tue, 12 Jul 2011, Andrew Haley wrote: > *(unsigned int*) &__tramp[0] = 0xe92d000f; /* stmfd sp!, {r0-r3} */ \ *(unsigned int*) &__tramp[4] = 0xe59f; /* ldr r0, [pc] */ \ *(unsigned int*) &__tramp[8] = 0xe59ff000; /

[Patch,AVR]: PR49687 (better widening 32-bit mul)

2011-07-25 Thread Georg-Johann Lay
This is the second part for a better widening multiply for AVR, namely widening to 32 bit when a MUL instructions are available. This as a bit more complicated than the 16-bit case because the multiplications are emit as implicit libgcc calls and involve hard registers. Thus, all splits and expan

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Richard Guenther
On Mon, Jul 25, 2011 at 11:10 AM, Ulrich Weigand wrote: > Richard Guenther wrote: >> On Sun, Jul 24, 2011 at 2:02 PM, Ira Rosen wrote: >> > On 21 July 2011 15:19, Ira Rosen wrote: >> >> I reproduced the failure. It occurs without Richard's >> >> (http://gcc.gnu.org/ml/gcc-patches/2011-07/msg0102

Re: [patch] Fix inlining glitch

2011-07-25 Thread Jan Hubicka
> On Sun, Jul 24, 2011 at 7:12 PM, Eric Botcazou wrote: > > Hi, > > > > we sometimes get messages like this in Ada: > > > > prime-mc2-other.adb: In function 'PRIME.MC2.OTHER.DO_SOMETHING': > > prime-mc2.adb:2:4: warning: inlining failed in call > > to 'PRIME.MC2.GET_INPUT_VALUE.PART': non-call exc

Re: PING: PATCH [4/n]: Prepare x32: Permute the conversion and addition if one operand is a constant

2011-07-25 Thread Paolo Bonzini
On 07/13/2011 07:48 PM, H.J. Lu wrote: Here is the patch. OK for trunk? Again, at least you should explain clearly _why_ you need ignore_address_wrap_around. You said elsewhere x32 should be first clean, then fast. if (GET_CODE (x) == SUBREG && SUBREG_PROMOTED_VAR_P (x) && GET_

[PATCH] Saner return value for gen_lowpart_no_emit

2011-07-25 Thread Paolo Bonzini
For some reason, when I "invented" gen_lowpart_no_emit I defaulted it to returning the original value of X. Since gen_lowpart_no_emit is mostly used to return simplifications, the correct thing to return when conversion fails is NULL. As a follow-up, every use in simplify-rtx.c could be changed t

Re: [patch] Fix inlining glitch

2011-07-25 Thread Eric Botcazou
> No, the problem here is deciding whether we can inline a clone. > We look into DECL_STRUCT_FUNCTION that we can't. The real fix is one > commented in: > > /* Don't inline if the callee can throw non-call exceptions but the > caller cannot. > FIXME: this is obviously wrong for LTO whe

Re: [patch tree-optimization]: Move tree-vrp to use binary instead of truth-expressions

2011-07-25 Thread Kai Tietz
Hello, this patch removes TRUTH-binary expressions and adjusts some places about bitwise-binary-expressions. ChangeLog gcc 2011-07-25 Kai Tietz * tree-vrp.c (extract_range_from_binary_expr): Remove TRUTH-binary cases and add new bitwise cases. (extract_range_from_assi

Re: [patch] Fix inlining glitch

2011-07-25 Thread Jan Hubicka
> > No, the problem here is deciding whether we can inline a clone. > > We look into DECL_STRUCT_FUNCTION that we can't. The real fix is one > > commented in: > > > > /* Don't inline if the callee can throw non-call exceptions but the > > caller cannot. > > FIXME: this is obviously wro

Re: [patch tree-optimization]: Move tree-vrp to use binary instead of truth-expressions

2011-07-25 Thread Richard Guenther
On Mon, Jul 25, 2011 at 12:08 PM, Kai Tietz wrote: > Hello, > > this patch removes TRUTH-binary expressions and adjusts some places about > bitwise-binary-expressions. > > ChangeLog gcc > > 2011-07-25  Kai Tietz   > >        * tree-vrp.c (extract_range_from_binary_expr): Remove >        TRUTH-bina

Re: tic6c-elf toolchain fails to build in FSF mainline

2011-07-25 Thread Bernd Schmidt
On 07/24/11 10:17, Nick Clifton wrote: > Hi Bernd, > > I tried building a tic6x-elf toolchain today from the FSF mainline > sources, but "make all-gcc" fails with: > > make[1]: *** No rule to make target > `/work/sources/gcc/current/gcc/common/config/c6x/c6x-common.c', needed by > `c6x-co

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Ira Rosen
On 25 July 2011 12:39, Richard Guenther wrote: > On Mon, Jul 25, 2011 at 11:10 AM, Ulrich Weigand wrote: >> Richard Guenther wrote: >>> On Sun, Jul 24, 2011 at 2:02 PM, Ira Rosen wrote: >>> > On 21 July 2011 15:19, Ira Rosen wrote: >>> >> I reproduced the failure. It occurs without Richard's >>

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Richard Guenther
On Mon, Jul 25, 2011 at 12:52 PM, Ira Rosen wrote: > On 25 July 2011 12:39, Richard Guenther wrote: >> On Mon, Jul 25, 2011 at 11:10 AM, Ulrich Weigand wrote: >>> Richard Guenther wrote: On Sun, Jul 24, 2011 at 2:02 PM, Ira Rosen wrote: > On 21 July 2011 15:19, Ira Rosen wrote:

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Ira Rosen
On 25 July 2011 13:57, Richard Guenther wrote: > On Mon, Jul 25, 2011 at 12:52 PM, Ira Rosen wrote: >> On 25 July 2011 12:39, Richard Guenther wrote: >>> On Mon, Jul 25, 2011 at 11:10 AM, Ulrich Weigand >>> wrote: Richard Guenther wrote: > On Sun, Jul 24, 2011 at 2:02 PM, Ira Rosen w

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Richard Guenther
On Mon, Jul 25, 2011 at 1:09 PM, Ira Rosen wrote: > On 25 July 2011 13:57, Richard Guenther wrote: >> On Mon, Jul 25, 2011 at 12:52 PM, Ira Rosen wrote: >>> On 25 July 2011 12:39, Richard Guenther wrote: On Mon, Jul 25, 2011 at 11:10 AM, Ulrich Weigand wrote: > Richard Guenther

[Patch,AVR]: Fix PR39386 (x << x and x >> x)

2011-07-25 Thread Georg-Johann Lay
This is a fix for pathological, variable shift offset shifts of the form x << x resp. x >> x. Such shifts need a shift register which might overlap with the shift operand. unsigned char shift (unsigned int x) { return x << x; } Without patch, note r24 is part of operand and used in loop: s

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Richard Guenther
On Mon, Jul 25, 2011 at 1:15 PM, Richard Guenther wrote: > On Mon, Jul 25, 2011 at 1:09 PM, Ira Rosen wrote: >> On 25 July 2011 13:57, Richard Guenther wrote: >>> On Mon, Jul 25, 2011 at 12:52 PM, Ira Rosen wrote: On 25 July 2011 12:39, Richard Guenther wrote: > On Mon, Jul 25, 2011 a

[patch, testsuite] Fix gcc.dg/vect/vect-70.c (was Re: vect-70.c fails on spu-elf)

2011-07-25 Thread Ira Rosen
"Ulrich Weigand" wrote on 25/07/2011 12:19:54 PM: > Ira Rosen wrote: > > "Ulrich Weigand" wrote on 22/07/2011 05:05:57 PM: > > > Any suggestions how to fix this? Maybe decrease N again and instead > > > prevent unrolling via command line switch? > > > > There is no flag for this unrolling, bu

Re: [PATCH, i386]: Rewrite LEA handling (was:Re: PATCH [10/n] X32: Support x32 LEA insns)

2011-07-25 Thread Uros Bizjak
On Mon, Jul 25, 2011 at 3:58 AM, H.J. Lu wrote: >> You are not fixing the core of the problem... this is why you need so >> much hacks and kludges at various places (some w.r.t. -fPIC already >> existed, see the patch). Above, you correctly identified the problem, >> so let's avoid gen_lowpart on

[C++ Patch] PR 49838

2011-07-25 Thread Paolo Carlini
Hi, I have this patchlet for an ICE after error on invalid. Is it OK? Tested x86_64-linux. Paolo. /cp 2011-07-25 Paolo Carlini PR c++/49838 * parser.c (cp_parser_perform_range_for_lookup): Early return if error_operand_p (range). /testsuite

Re: Fix pass_partition_blocks vs -O0

2011-07-25 Thread Michael Matz
Hi, On Fri, 22 Jul 2011, Richard Henderson wrote: > Well, technically it's not "broken" yet. It will be as soon as it starts > touching DF data, since this pass runs before pass_df_initialize_no_opt. > > But the only real consumer of BB_PARTITION is pass_reorder_blocks. And > that pass is alre

Re: [RFC] Replace some bitmaps with HARD_REG_SETs - second version

2011-07-25 Thread Dimitrios Apostolou
Bug found, in df_mark_reg I need to iterate until regno + n, not n. The error is at the following hunk: --- gcc/df-scan.c 2011-02-02 20:08:06 + +++ gcc/df-scan.c 2011-07-24 17:16:46 + @@ -3713,35 +3717,40 @@ df_mark_reg (rtx reg, void *vset) if (regno < FIRST_PSEUDO_REGIST

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Ulrich Weigand
Richard Guenther wrote: > >> Well, the back-end assumes a pointer to vector type is always > >> naturally aligned, and therefore the data it points to can be > >> accessed via a simple load, with no extra rotate needed. > > > > I can't see any use of VECTOR_TYPE in config/spu/,

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Richard Guenther
On Mon, Jul 25, 2011 at 3:22 PM, Ulrich Weigand wrote: > Richard Guenther wrote: > >> >> Well, the back-end assumes a pointer to vector type is always >> >> naturally aligned, and therefore the data it points to can be >> >> accessed via a simple load, with no extra rotate needed. >> >

Re: [PATCH, i386]: Rewrite LEA handling (was:Re: PATCH [10/n] X32: Support x32 LEA insns)

2011-07-25 Thread H.J. Lu
On Mon, Jul 25, 2011 at 5:33 AM, Uros Bizjak wrote: > On Mon, Jul 25, 2011 at 3:58 AM, H.J. Lu wrote: > >>> You are not fixing the core of the problem... this is why you need so >>> much hacks and kludges at various places (some w.r.t. -fPIC already >>> existed, see the patch). Above, you correct

PR 49809: write data refs can now be calls

2011-07-25 Thread Richard Sandiford
PR 49809 is fallout from my patch to add write data references for the lhs of calls. tree-ssa-phiopt.c was still assuming that writes were always assignments. I tried to look for other examples of the same thing, but couldn't find any. Tested on x86_64-linux-gnu (all,ada). OK to install? Richa

Re: [PATCH, i386]: Rewrite LEA handling (was:Re: PATCH [10/n] X32: Support x32 LEA insns)

2011-07-25 Thread Uros Bizjak
On Mon, Jul 25, 2011 at 3:30 PM, H.J. Lu wrote: >> Attached patch implements -fpic handling for x32. In x32 mode, we now >> use x86_64_general_operand and corresponding "e" constraints for adds >> in SImode, since it looks that invalid addresses can only be generated >> through adds. This avoids

Re: PR 49809: write data refs can now be calls

2011-07-25 Thread Richard Guenther
On Mon, Jul 25, 2011 at 3:38 PM, Richard Sandiford wrote: > PR 49809 is fallout from my patch to add write data references for the > lhs of calls.  tree-ssa-phiopt.c was still assuming that writes were > always assignments. > > I tried to look for other examples of the same thing, but couldn't > f

Re: PR 49809: write data refs can now be calls

2011-07-25 Thread Eric Botcazou
> PR 49809 is fallout from my patch to add write data references for the > lhs of calls. tree-ssa-phiopt.c was still assuming that writes were > always assignments. > > I tried to look for other examples of the same thing, but couldn't > find any. > > Tested on x86_64-linux-gnu (all,ada). OK to i

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Richard Guenther
On Mon, Jul 25, 2011 at 3:24 PM, Richard Guenther wrote: > On Mon, Jul 25, 2011 at 3:22 PM, Ulrich Weigand wrote: >> Richard Guenther wrote: >> >>> >> Well, the back-end assumes a pointer to vector type is always >>> >> naturally aligned, and therefore the data it points to can be >>> >>>

Re: [PATCH] Fix PR49715, (float)unsigned -> (float)signed

2011-07-25 Thread H.J. Lu
On Fri, Jul 22, 2011 at 2:13 AM, Richard Guenther wrote: > On Fri, 22 Jul 2011, Richard Guenther wrote: > >> On Thu, 21 Jul 2011, Joseph S. Myers wrote: >> >> > On Thu, 21 Jul 2011, Richard Guenther wrote: >> > >> > > Patch also handling wider modes and not starting with SImode but >> > > the mode

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Richard Guenther
On Mon, Jul 25, 2011 at 4:03 PM, Richard Guenther wrote: > On Mon, Jul 25, 2011 at 3:24 PM, Richard Guenther > wrote: >> On Mon, Jul 25, 2011 at 3:22 PM, Ulrich Weigand wrote: >>> Richard Guenther wrote: >>> >> Well, the back-end assumes a pointer to vector type is always >> na

Re: [PATCH] Fix PR49715, (float)unsigned -> (float)signed

2011-07-25 Thread Richard Guenther
On Mon, 25 Jul 2011, H.J. Lu wrote: > On Fri, Jul 22, 2011 at 2:13 AM, Richard Guenther wrote: > > On Fri, 22 Jul 2011, Richard Guenther wrote: > > > >> On Thu, 21 Jul 2011, Joseph S. Myers wrote: > >> > >> > On Thu, 21 Jul 2011, Richard Guenther wrote: > >> > > >> > > Patch also handling wider m

Re: [PATCH, i386]: Rewrite LEA handling (was:Re: PATCH [10/n] X32: Support x32 LEA insns)

2011-07-25 Thread H.J. Lu
On Mon, Jul 25, 2011 at 6:43 AM, Uros Bizjak wrote: > On Mon, Jul 25, 2011 at 3:30 PM, H.J. Lu wrote: > >>> Attached patch implements -fpic handling for x32. In x32 mode, we now >>> use x86_64_general_operand and corresponding "e" constraints for adds >>> in SImode, since it looks that invalid ad

Re: [RFC PATCH 0/9] CFG aware dwarf2 cfi generation

2011-07-25 Thread David Edelsohn
On Sun, Jul 24, 2011 at 11:56 PM, Richard Henderson wrote: > Please try again.  I've fixed 4 bugs today for different targets; > hopefully I've gotten this one as part of that. Unfortunately, no. Same error. - David

[PATCH] Fix PR49822

2011-07-25 Thread Richard Guenther
This robustifies remove_prop_source_from_use some more. Bootstrapped and tested on x86_64-unknown-linux-gnu, also cross-tested the arm testcase. Applied. Richard. 2011-07-25 Richard Guenther PR tree-optimization/49822 * tree-ssa-forwprop.c (remove_prop_source_from_use): Rob

RE: [Patch,AVR]: Fix PR39386 (x << x and x >> x)

2011-07-25 Thread Weddington, Eric
> -Original Message- > From: Georg-Johann Lay [mailto:a...@gjlay.de] > Sent: Monday, July 25, 2011 5:20 AM > To: gcc-patches@gcc.gnu.org > Cc: Denis Chertykov; Weddington, Eric; Richard Henderson > Subject: [Patch,AVR]: Fix PR39386 (x << x and x >> x) > > This is a fix for pathological,

RE: [Patch,AVR]: PR49687 (better widening 32-bit mul)

2011-07-25 Thread Weddington, Eric
> -Original Message- > From: Georg-Johann Lay [mailto:a...@gjlay.de] > Sent: Monday, July 25, 2011 3:32 AM > To: gcc-patches@gcc.gnu.org > Cc: Anatoly Sokolov; Denis Chertykov; Weddington, Eric; Richard Henderson > Subject: [Patch,AVR]: PR49687 (better widening 32-bit mul) > > Eric, can

Re: [RFC] Replace some bitmaps with HARD_REG_SETs - second version

2011-07-25 Thread Michael Matz
Hi, On Mon, 25 Jul 2011, Dimitrios Apostolou wrote: > Bug found, in df_mark_reg I need to iterate until regno + n, not n. The error > is at the following hunk: > > --- gcc/df-scan.c 2011-02-02 20:08:06 + > +++ gcc/df-scan.c 2011-07-24 17:16:46 + > @@ -3713,35 +3717,40 @@ df_m

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Ulrich Weigand
Richard Guenther wrote: > > Btw, as pseudos do not have a single def site how can the above > > ever be correct in the face of coalescing? I had always understood this to reflect the simple fact that a pointer to some type must never hold a value that is not properly aligned for that type. (Mayb

Re: Allow Tru64 UNIX bootstrap with C++

2011-07-25 Thread Rainer Orth
Ian Lance Taylor writes: > I'll preapprove a similar patch to libcpp/system.h if you want to take a > look at that. Sure. The following patch has been bootstrapped successfully on i386-pc-solaris2.11, installed on mainline. Rainer 2011-07-22 Rainer Orth * system.h [__cplu

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Richard Guenther
On Mon, Jul 25, 2011 at 4:23 PM, Ulrich Weigand wrote: > Richard Guenther wrote: > >> > Btw, as pseudos do not have a single def site how can the above >> > ever be correct in the face of coalescing? > > I had always understood this to reflect the simple fact that a > pointer to some type must nev

[patch] Fix PR tree-optimization/49471

2011-07-25 Thread Razya Ladelsky
Hi, This patch fixes the build failure of cactusADM and dealII spec2006 benchmarks when autopar is enabled. (for powerpc they fail only when -m32 is additionally enabled) The problem originated in canonicalize_loop_ivs, where we iterate the header's phis in order to base all the induction varia

eliminate bitmap regs_invalidated_by_call_regset

2011-07-25 Thread Dimitrios Apostolou
Hello list, the attached patch eliminates regs_invalidated_by_call_regset bitmap and uses instead the original regs_invalidated_by_call HARD_REG_SET. Tested on i386, I had the following two regressions that I'll investigate right on: FAIL: libmudflap.cth/pass39-frag.c (-O3) (rerun 10) execut

Re: [patch] Fix PR tree-optimization/49471

2011-07-25 Thread Richard Guenther
On Mon, Jul 25, 2011 at 4:47 PM, Razya Ladelsky wrote: > Hi, > > This patch fixes the build failure of cactusADM and dealII spec2006 > benchmarks when autopar is enabled. > (for powerpc they fail only when -m32 is additionally enabled) > > The problem originated in canonicalize_loop_ivs, where we

Re: [PATCH 2/3] canonicalize_loop_ivs should not generate unsigned types.

2011-07-25 Thread Sebastian Pop
On Mon, Jul 25, 2011 at 03:41, Richard Guenther wrote: > I think we also need to care for non-integral PHIs where TYPE_PRECISION > and TYPE_UNSIGNED are not applicable (seems the original code is also > buggy here?).  So, sth like > >  type = TREE_TYPE (res); >  if (!is_gimple_reg (res) >      ||

Reject unqualified *-*-solaris2 configurations (PR target/47124)

2011-07-25 Thread Rainer Orth
As described in the PR, configuring for e.g. sparc-sun-solaris2 fails to build in the gcc directory. While this could be made to work, it doesn't really make sense: in a native build, you don't have to specify the configure triplet you're building for, and in a cross you must, given the difference

Re: [patch] Fix PR tree-optimization/49471

2011-07-25 Thread Razya Ladelsky
Razya Ladelsky/Haifa/IBM wrote on 25/07/2011 05:44:02 PM: > From: Razya Ladelsky/Haifa/IBM > To: gcc-patches@gcc.gnu.org > Cc: Zdenek Dvorak , Richard Guenther > > Date: 25/07/2011 05:44 PM > Subject: [patch] Fix PR tree-optimization/49471 > > Hi, > > This patch fixes the build failure of cact

Re: [PATCH 2/3] canonicalize_loop_ivs should not generate unsigned types.

2011-07-25 Thread Richard Guenther
On Mon, Jul 25, 2011 at 4:56 PM, Sebastian Pop wrote: > On Mon, Jul 25, 2011 at 03:41, Richard Guenther wrote: >> I think we also need to care for non-integral PHIs where TYPE_PRECISION >> and TYPE_UNSIGNED are not applicable (seems the original code is also >> buggy here?).  So, sth like >> >>  

Re: [RFC] Replace some bitmaps with HARD_REG_SETs - second version

2011-07-25 Thread Bernd Schmidt
On 07/25/11 16:20, Michael Matz wrote: > Hi, > > On Mon, 25 Jul 2011, Dimitrios Apostolou wrote: > >> Bug found, in df_mark_reg I need to iterate until regno + n, not n. The error >> is at the following hunk: >> >> --- gcc/df-scan.c 2011-02-02 20:08:06 + >> +++ gcc/df-scan.c 2011-

Fix libgomp alignment errors on Tru64 UNIX (PR libgomp/45351)

2011-07-25 Thread Rainer Orth
As discussed in the PR, we need to force int alignment for sem_t on Tru64 UNIX to work around a bug in the native librt. The following patch does this. Tested by rebuilding libgomp, make check is still running. No failures or unaligned access errors so for. Ok for mainline if it passes? Thanks

Re: Fix libgomp alignment errors on Tru64 UNIX (PR libgomp/45351)

2011-07-25 Thread Jakub Jelinek
On Mon, Jul 25, 2011 at 05:04:03PM +0200, Rainer Orth wrote: > As discussed in the PR, we need to force int alignment for sem_t on > Tru64 UNIX to work around a bug in the native librt. The following > patch does this. > > Tested by rebuilding libgomp, make check is still running. No failures >

Re: [PATCH 2/3] canonicalize_loop_ivs should not generate unsigned types.

2011-07-25 Thread Sebastian Pop
On Mon, Jul 25, 2011 at 10:01, Richard Guenther wrote: >>  type = TREE_TYPE (res); >>  if (!is_gimple_reg (res) >>      || !INTEGRAL_TYPE_P (type) >>      || TYPE_PRECISION (type) < precision) >>    continue; >> >>  if (TYPE_PRECISION (type) > precision) >>    unsigned_p = TYPE_UNSIGNED (type); >>

[fixincludes] Fix posix_spawn* declarations in Solaris (PR c++/49347)

2011-07-25 Thread Rainer Orth
As discussed in the PR, the Solaris 10+ header needs a fix to make it work with g++. The following patch implements it. It passed a i386-pc-solaris2.11 bootstrap without regressions and make check in fixincludes works without failures. Ok for mainline? Thanks. Rainer diff --git a/fix

Re: [C++ Patch] PR 49838

2011-07-25 Thread Jason Merrill
Ok.

Re: Fix pass_partition_blocks vs -O0

2011-07-25 Thread Richard Henderson
On 07/25/2011 06:02 AM, Michael Matz wrote: > Hi, > > On Fri, 22 Jul 2011, Richard Henderson wrote: > >> Well, technically it's not "broken" yet. It will be as soon as it starts >> touching DF data, since this pass runs before pass_df_initialize_no_opt. >> >> But the only real consumer of BB_PAR

Re: [patch] Fix PR tree-optimization/49771

2011-07-25 Thread Ulrich Weigand
Richard Guenther wrote: > On Mon, Jul 25, 2011 at 4:23 PM, Ulrich Weigand wrote: > > I had always understood this to reflect the simple fact that a > > pointer to some type must never hold a value that is not properly > > aligned for that type. (Maybe this is only true on STRICT_ALIGNMENT > > tar

[testsuite] Restore g++.dg/torture/pr49309.C (PR testsuite/49753)

2011-07-25 Thread Rainer Orth
As previously discussed, I've returned the pr49309.C test to gcc/testsuite, given that it's a compiler and not a runtime library test. Tested on i386-pc-solaris2.11, installed on mainline and 4.6 branch. Rainer 2011-07-18 Rainer Orth gcc/testsuite: PR testsuite/49753

Re: [fixincludes] Fix posix_spawn* declarations in Solaris (PR c++/49347)

2011-07-25 Thread Bruce Korb
On 07/25/11 08:17, Rainer Orth wrote: As discussed in the PR, the Solaris 10+ header needs a fix to make it work with g++. The following patch implements it. It passed a i386-pc-solaris2.11 bootstrap without regressions and make check in fixincludes works without failures. Ok for mainline?

Re: [fixincludes] Fix posix_spawn* declarations in Solaris (PR c++/49347)

2011-07-25 Thread Rainer Orth
Hi Bruce, >> some-function(char *const argv[_RESTRICT_KYWD], ...) > > looks pretty broken to me. How would it work with plain gcc? no idea, but both gcc -std=c99 and Sun Studio cc -xc99 do accept it. > Anyway, editing the _RESTRICT_KYWD into the correct place looks > correct to me, and I'm sure

Re: Fix pass_partition_blocks vs -O0

2011-07-25 Thread Michael Matz
Hi, On Mon, 25 Jul 2011, Richard Henderson wrote: > >> But the only real consumer of BB_PARTITION is pass_reorder_blocks. > >> And that pass is already gated to only run if optimization is > >> enabled. So really there's no point in running this pass without > >> optimization. > >> > >> Comm

Re: [PR43597, ARM, TESTCASE]

2011-07-25 Thread Tom de Vries
Hi, thanks for the review. On 07/18/2011 03:19 PM, Richard Earnshaw wrote: > On 18/07/11 12:09, Tom de Vries wrote: >> Hi, >> >> PR43597 was fixed by >> http://gcc.gnu.org/viewcvs?view=revision&revision=172032. >> >> This patch adds a testcase. >> >> OK for trunk? >> >> Thanks, >> - Tom >> >> 20

Re: [ARM] Fix PR49641

2011-07-25 Thread Bernd Schmidt
On 07/13/11 16:01, Richard Earnshaw wrote: > On 07/07/11 21:02, Bernd Schmidt wrote: >> This corrects an error in store_multiple_operation. We're only >> generating the writeback version of the instruction on Thumb-1, so >> that's where we must make sure the base register isn't also stored. >> >> T

Re: [Patch,AVR]: PR49687 (better widening 32-bit mul)

2011-07-25 Thread Georg-Johann Lay
Weddington, Eric wrote: > >> Eric, can you review the assembler routines and say if such reuse is ok or >> if you'd prefer a >> speed-optimized version of __mulsi3 like in the current libgcc? > > Hi Johann, > > Typically a penalty on speed is preferred over a penalty on code size. Do you > alr

[testsuite] Provide and use mmap effective-target keyword

2011-07-25 Thread Rainer Orth
When last week a testcase using mmap was posted with a copy of some old (and wrong) list of targets supporting mmap, I noticed what mess we have here. To fix this, I've introduced a new effective-target keyword mmap and use it in all testcases. Two minor changes to the tests were required: * gcc

[PATCH] Fix PR47594: Sign extend constants while translating to Graphite

2011-07-25 Thread Sebastian Pop
"Bug 47594 - gfortran.dg/vect/vect-5.f90 execution test fails when compiled with -O2 -fgraphite-identity" The problem is due to the fact that Graphite generates this loop: for (scat_3=0;scat_3<=4294967295*scat_1+T_51-1;scat_3++) { S6(scat_1,scat_3); } that has a "-1" encoded as an

Re: CFT: Move unwinder to toplevel libgcc

2011-07-25 Thread Rainer Orth
Steve, > Well, I see "-Wl,--version-script=libgcc.map" on the link line now but I > still get an error during the link: > > /wsp/sje/gcc_git/gcc-ia64-debian-linux-gnu-gcc/ia64-debian-linux-gnu/bin/ld: > ./libgcc_s.so.1.tmp: version node not found for symbol > _Unwind_GetBSP@GCC_3.3.2 > /wsp/sje/

Re: [build, ada] Allow Solaris bootstrap with C++ (PR bootstrap/49794)

2011-07-25 Thread Rainer Orth
Paolo, > On Wed, Jul 20, 2011 at 18:35, Rainer Orth > wrote: >>  I've hacked around this by wrapping the AM_ICONV calls in >>  AC_LANG_{PUSH, POP}(C++), but I think this exposes a fundamental >>  issue: the configure tests must be performed with the compiler used >>  for the build.  That this wo

Re: PR 45819 - possible fix?

2011-07-25 Thread DJ Delorie
> Fact is that GCC knows that memory is not properly aligned. So in the impossibly rare case that gcc is *wrong*, how is the programmer supposed to tell gcc that? I mean, gcc 4.4 has been doing what the programmer wanted, and zillions of ARM devices have been happily working, and now you tell me

Re: IA64 HP-UX bootstrap with C++

2011-07-25 Thread Rainer Orth
Joseph, > Are -static-libstdc++ and -static-libgcc not working for you (with the > stage 1 compiler when it's used to link stage 2, and the stage 2 compiler > used to link stage 3)? If not, fixing them if possible would be the right > approach. unless HP-UX ld supports -Bstatic/-Bdynamic and

Re: [M32C] Hookize PRINT_OPERAND, PRINT_OPERAND_ADDRESS and PRINT_OPERAND_PUNCT_VALID_P

2011-07-25 Thread DJ Delorie
Ok.

Re: [C++0x] contiguous bitfields race implementation

2011-07-25 Thread Aldy Hernandez
On 07/22/11 13:44, Jason Merrill wrote: On 07/18/2011 08:02 AM, Aldy Hernandez wrote: + /* If other threads can't see this value, no need to restrict stores. */ + if (ALLOW_STORE_DATA_RACES + || !DECL_THREAD_VISIBLE_P (innerdecl)) + { + *bitstart = *bitend = 0; + return; + } What if get_inner_

[v3] libstdc++/49836

2011-07-25 Thread Paolo Carlini
Hi, tested x86_64-linux, committed to mainline (see audit trail for details) Thanks, Paolo. 2011-07-25 Paolo Carlini Nathan Ridge PR libstdc++/49836 * include/bits/stl_vector.h (vector<>::_M_emplace_back_aux): Declare. (

[PATCH, Obvious cleanup] Remove parm name from declaration

2011-07-25 Thread Dodji Seketeli
Hello, I committed this obvious header cleanup patch to trunk. -- Dodji gcc/c-family * c-common.h (set_underlying_type): Remove parm name from declaration. diff --git a/gcc/c-family/c-common.h b/gcc/c-family/c-common.h index 202be02..4ac7c4a 100644 ---

[Patch,AVR]: Fix PR29560 (map 16-bit shift to 8-bit)

2011-07-25 Thread Georg-Johann Lay
This is an optimization for 8-bit shifts if the high part is unused. Variable shift offset shifts are tedious on AVR because these devices can just shift by 1. If the high part of a shift is unused, the high part need not to be computed, i.e. the 16-bit shift can be mapped to a 8-bit shift. Most

Re: eliminate bitmap regs_invalidated_by_call_regset

2011-07-25 Thread Steven Bosscher
On Mon, Jul 25, 2011 at 4:52 PM, Dimitrios Apostolou wrote: > Hello list, > > the attached patch eliminates regs_invalidated_by_call_regset bitmap and > uses instead the original regs_invalidated_by_call HARD_REG_SET. Tested on > i386, I had the following two regressions that I'll investigate righ

Re: [RFC] Replace some bitmaps with HARD_REG_SETs - second version

2011-07-25 Thread Steven Bosscher
On Mon, Jul 25, 2011 at 4:20 PM, Michael Matz wrote: > Hi, > > On Mon, 25 Jul 2011, Dimitrios Apostolou wrote: > >> Bug found, in df_mark_reg I need to iterate until regno + n, not n. The error >> is at the following hunk: >> >> --- gcc/df-scan.c       2011-02-02 20:08:06 + >> +++ gcc/df-scan.

Re: [Patch,AVR]: Fix PR29560 (map 16-bit shift to 8-bit)

2011-07-25 Thread Richard Henderson
On 07/25/2011 10:30 AM, Georg-Johann Lay wrote: > PR target/29560 > * config/avr/avr.md: Add peephole2 to map ashlhi3 to ashlqi3 if > high part of shift target is unused. Ok. r~

Re: Allow IRIX Ada bootstrap with C++

2011-07-25 Thread Rainer Orth
Eric Botcazou writes: >> 2011-07-20 Rainer Orth >> >> * init.c [sgi] (__gnat_error_handler): Update sigaction(2) citation. >> Correct argument types. >> Extract code from reason. >> (__gnat_install_handler): Assign to act.sa_sigaction. > > This breaks signal handling on our

[C++ Patch, committed] PR 49845

2011-07-25 Thread Paolo Carlini
Hi, I'm committing as obvious the below, to fix the breakage I inadvertently cause. Sorry again. Paolo. /// 2011-07-25 Paolo Carlini PR bootstrap/49845 * parser.c (cp_parser_perform_range_for_lookup): Always assign *being and *end before ret

Re: [PATCH, PR 49094] Refrain from creating misaligned accesses in SRA

2011-07-25 Thread Martin Jambor
Hi, On Thu, Jul 21, 2011 at 11:40:32AM +0200, Martin Jambor wrote: > Hi, > > On Thu, Jul 21, 2011 at 10:34:35AM +0200, Richard Guenther wrote: > > On Wed, 20 Jul 2011, Ulrich Weigand wrote: > > > > > Richard Guenther wrote: > > > > On Tue, Jul 19, 2011 at 8:20 PM, Ulrich Weigand > > > > wrote:

[google] Merge r176592 from google/main to google/gcc-4_6 branch.

2011-07-25 Thread Rong Xu
committed.

Re: [PATCH, PR 49094] Refrain from creating misaligned accesses in SRA

2011-07-25 Thread Ulrich Weigand
Martin Jambor wrote: > Like this? Ulrich, can you please verify it works? I have > bootstrapped this on x86_64 but there it obvioulsy works and my run of > compile/testsuite on compile farm sparc64 will take some time (plus, > the testcase you complained about passes there). Yes, this does fix

Re: [RFC] Replace some bitmaps with HARD_REG_SETs - second version

2011-07-25 Thread Dimitrios Apostolou
That was a bug, indeed, but unfortunately it wasn't the one causing the crash I posted earlier... Even after fixing it I get the same backtrace from gdb. So the petition "spot the bug" holds... Thanks, Dimitris

added some assert checks in hard-reg-set.h

2011-07-25 Thread Dimitrios Apostolou
Hello list, the attached patch was tested on i386, and measured to have almost no overhead in runtime, when RTL checks are enabled: Instruction Count before: 2328.6 M Instruction Count after: 2334.4 M which translates to some milliseconds, well within noise area. Changelog: 2011-07-25 Di

Re: [PATCH] Fix configure --with-cloog

2011-07-25 Thread Romain Geissler
Le 6 juil. 2011 à 11:04, Romain Geissler a écrit : > Hello > > This patch fix an issue while building with cloog and gmp installed in > a custom separate directories. > > How to reproduce : > - Make sure you've installed cloog and gmp in separate directories > (ie ${WITH-CLOOG-PATH}/lib doesn't

Re: [PLUGIN] compile and install gengtype, install gtype.state

2011-07-25 Thread Romain Geissler
Le 19 juil. 2011 à 14:41, Romain Geissler a écrit : > 2011/7/19 Jakub Jelinek : >> On Tue, Jul 19, 2011 at 02:26:32PM +0200, Romain Geissler wrote: >>> 2011-07-18 Romain Geissler >>> >>> * gengtype-state.c (#include "bconfig.h"): include "bconfig.h" >>> if GENERATOR_FILE is defined

Re: [PLUGIN] compile and install gengtype, install gtype.state

2011-07-25 Thread Jakub Jelinek
On Mon, Jul 25, 2011 at 09:10:55PM +0200, Romain Geissler wrote: > > 2011-07-18 Romain Geissler > > > > * gengtype-state.c (#include "bconfig.h"): Include "bconfig.h" > > if GENERATOR_FILE is defined, "config.h" otherwise. Still not right, this should have been * gengtype-state

RE: [Patch,AVR]: PR49687 (better widening 32-bit mul)

2011-07-25 Thread Weddington, Eric
> -Original Message- > From: Georg-Johann Lay [mailto:a...@gjlay.de] > Sent: Monday, July 25, 2011 10:29 AM > To: Weddington, Eric > Cc: gcc-patches@gcc.gnu.org; Anatoly Sokolov; Denis Chertykov; Richard > Henderson > Subject: Re: [Patch,AVR]: PR49687 (better widening 32-bit mul) > > >

[PATCH, i386, take 2]: Rewrite LEA handling (was:Re: PATCH [10/n] X32: Support x32 LEA insns)

2011-07-25 Thread Uros Bizjak
On Mon, Jul 25, 2011 at 3:30 PM, H.J. Lu wrote: >> Attached patch implements -fpic handling for x32. In x32 mode, we now >> use x86_64_general_operand and corresponding "e" constraints for adds >> in SImode, since it looks that invalid addresses can only be generated >> through adds. This avoids

Re: [PATCH] GNU/kFreeBSD systems running on MIPS

2011-07-25 Thread Richard Sandiford
Robert Millan writes: > This patch adds support for GNU/kFreeBSD systems running on MIPS. Looks good. However, Rainer's in the middle of moving things from gcc/ to libgcc/ -- where they belong -- and committing a new port now would interfere with that. If it's OK, I'd like to hold off applying

[google] Disable annotalysis in google/main (issue4816050)

2011-07-25 Thread Diego Novillo
Annotalysis has been broken in google/main since the last merge from trunk. This patch disables it until Delesley comes up with a permanent solution. Tested on x86_64. OK for google/main? 2011-07-25 Diego Novillo * tree-threadsafe-analyze.c (gate_threadsafe_analyze): Always

Re: [PATCH, i386, take 2]: Rewrite LEA handling (was:Re: PATCH [10/n] X32: Support x32 LEA insns)

2011-07-25 Thread H.J. Lu
On Mon, Jul 25, 2011 at 12:59 PM, Uros Bizjak wrote: > On Mon, Jul 25, 2011 at 3:30 PM, H.J. Lu wrote: > >>> Attached patch implements -fpic handling for x32. In x32 mode, we now >>> use x86_64_general_operand and corresponding "e" constraints for adds >>> in SImode, since it looks that invalid a

  1   2   >