Re: [google] Check if the nonnull attribute is applied to 'this' (issue4446070)

2011-05-02 Thread Jason Merrill
On 04/29/2011 04:08 PM, Basile Starynkevitch wrote: [...] which is also what I expect. I have no idea if it is conforming to standards. But I notice that the test about this is remaining in the code. So apparently GCC 4.6 does not make the hypothesis that this is never null, otherwise it would ha

C++ PATCHes relating to c++/48834, c++/40975 (array new)

2011-05-02 Thread Jason Merrill
So, the problem in 48834 was that we had specified a particular target for the vec initialization, but it was getting clobbered by ending up on the rhs of an INIT_EXPR. So 48834.patch avoids that. But Diego doesn't think there was any real reason to abort on trying to copy a STATEMENT_LIST, s

Re: [google]: initialize language field for clone function struct

2011-05-02 Thread Xinliang David Li
Is this one ok? David On Fri, Apr 29, 2011 at 4:38 PM, Xinliang David Li wrote: > During function cloning, the language field of the src func is not > copied. This can lead to null dereference when gcc calls into langhook > functions.  Unfortunately, I lost track of the test case. > > Ok for tru

Re: C++ PATCHes relating to c++/48834, c++/40975 (array new)

2011-05-02 Thread Eric Botcazou
> But Diego doesn't think there was any real reason to abort on trying to > copy a STATEMENT_LIST, so it seems to me that we could revert my earlier > patch for 40975 and just add support for copying STATEMENT_LIST. So > 40975-2.patch adds that support. FWIW this assertion caught an impressive nu

Re: [PATCH] use build_function_type_list in the sh backend

2011-05-02 Thread Kaz Kojima
Nathan Froyd wrote: > As $SUBJECT suggests. The only tricky bit is the initialization of > `args' to NULL_TREEs so that we can safely pass all of the relevant args > to build_function_type_list, regardless of whether the function type in > question has that many args. > > Tested with cross to sh

Re: [google] Patch to support calling multi-versioned functions via new GCC builtin. (issue4440078)

2011-05-02 Thread Xinliang David Li
On Mon, May 2, 2011 at 2:33 PM, Richard Guenther wrote: > On Mon, May 2, 2011 at 6:41 PM, Xinliang David Li wrote: >> On Mon, May 2, 2011 at 2:11 AM, Richard Guenther >> wrote: >>> On Fri, Apr 29, 2011 at 6:23 PM, Xinliang David Li >>> wrote: Here is the background for this feature:

Re: update C++0x status table to FDIS

2011-05-02 Thread Jonathan Wakely
2011-05-03 Jonathan Wakely PR libstdc++/48848 * doc/xml/manual/status_cxx200x.xml: Update valarray status. * doc/html/*: Regenerate. A small tweak to the C++0x status table, as pointed out in PR 48848 Tested with 'make doc-xml-validate-docbook' and 'make doc-html' on x

Re: std::bind vs ::bind ambiguity

2011-05-02 Thread Jonathan Wakely
On 25 April 2011 19:11, Jonathan Wakely wrote: > > Here's a patch which removes std::bind from the overload set when the > first argument is "socketlike" which I've defined as is_integral || > is_enum.  I considered using is_convertible to int to detect > "socketlike" types, but a callable class ty

Re: [testsuite] Compile gfortran.dg/fmt_g0_6.f08 with -ffloat-store

2011-05-02 Thread Jerry DeLisle
On 05/02/2011 07:20 AM, Rainer Orth wrote: gfortran.dg/fmt_g0_6.f08 execution seems to fail on all 32-bit x86 targets at -O1 and above. Running it under gdb, I find Program received signal SIGABRT, Aborted. [Switching to Thread 1 (LWP 1)] 0xfed0ff85 in _lwp_kill () from /lib/libc.so.1 (gdb) whe

Re: Improve jump threading 4 of N

2011-05-02 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/02/11 15:40, Richard Guenther wrote: > > I've got no opinion on using a VEC if folks chime in with the request, > I'll make that change. > >> If it's fixed size there's no need for a VEC, it would be just overhead. VEC adds checking, which can

Re: [PATCH] Properly build integer constants

2011-05-02 Thread H.J. Lu
On Sun, Apr 24, 2011 at 8:11 AM, H.J. Lu wrote: > On Fri, Apr 22, 2011 at 12:27 PM, Richard Guenther wrote: >> >> There is a scary comment before build_int_cst_type why build_int_cst >> can't be sane.  Fortunately it is not true.  If it were there would >> be other code to be fixed. >> >> Bootstr

Re: [PATCH] Fix switch conversion (PR tree-optimization/48809)

2011-05-02 Thread H.J. Lu
On Fri, Apr 29, 2011 at 9:43 AM, Jakub Jelinek wrote: > Hi! > > The following patch fixes a bug in tree-switch-conversion.c with > signed index_expr's.  build_arrays would compute index_expr - range_min > in index_expr's type and use that as index into CSWTCH.N array, > which is wrong, because in

Re: Improve DSE in the presence of calls

2011-05-02 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/26/11 16:06, Easwaran Raman wrote: > >> You're right. The patch has correctness issues. It is not possible to >> simply not call add_wild_read because it also resets >> active_local_stores and frees read_recs. During the local phase it >> seems

Re: C++ PATCHes relating to c++/48834, c++/40975 (array new)

2011-05-02 Thread Jason Merrill
On 05/02/2011 06:23 PM, Eric Botcazou wrote: I'm not sure you can copy statements if they have any side-effects; this looks quite dangerous to me. Instead statement-expressions should be wrapped up in a SAVE_EXPR/TARGET_EXPR to protect them and prevent copying. It sounds like Ada and C++ are u

<    1   2