[Patch, Fortran, committed] PR 18918 - Fix max-rank check for coarrays

Committed as obvious (Rev. 172812). Tobias Index: gcc/testsuite/gfortran.dg/coarray_18.f90 === --- gcc/testsuite/gfortran.dg/coarray_18.f90 (revision 0) +++ gcc/testsuite/gfortran.dg/coarray_18.f90 (revision 0) @@ -0,0 +1,39 @@ +! { d

Re: [patch middle-end]: Missed optimization for (x & ~y) | (~x & y)

On Wed, Apr 20, 2011 at 5:58 PM, Kai Tietz wrote: > 2011/4/20 Jakub Jelinek : >> On Wed, Apr 20, 2011 at 05:22:31PM +0200, Kai Tietz wrote: >>> --- gcc.orig/gcc/fold-const.c 2011-04-20 17:10:39.478091900 +0200 >>> +++ gcc/gcc/fold-const.c      2011-04-20 17:11:22.901039400 +0200 >>> @@ -10660,6 +1

Re: [PATCH] use build_function_type_list in the s390 backend

On Wed, Apr 20, 2011 at 9:43 PM, Nathan Froyd wrote: > As $SUBJECT suggests.  Tested with cross to s390-linux-gnu.  OK to > commit? Those kind of patches are pretty obvious, so if $target maintainers do not comment within 48h consider them approved. Thanks, Richard. > -Nathan > >        * confi

Re: Fix PR48703: segfault in mangler due to -g

On Thu, Apr 21, 2011 at 12:04 AM, Michael Matz wrote: > Hi, > > I wrote: > >> Basically we have to set assembler names early also for TYPE_DECLs, we >> can't rely on the frontends langhook to do that after free_lang_data. >> >> Okay for trunk assuming regstrapping on x86_64-linux works? > > Patch

Re: Ping^2 Re: Target header etc. cleanup patch

On Wed, Apr 20, 2011 at 11:09 PM, Joseph S. Myers wrote: > Ping^2.  This patch > is still pending > review.  This version applies cleanly to current trunk. The s/struct rtx_def */rtx/ changes are all ok (in fact I'd say they are obvious).

Re: [PATCH] use build_function_type_list in the spu backend

Nathan Froyd wrote: >for (parm = 1; d->parm[parm] != SPU_BTI_END_OF_PARAMS; parm++) > ; > > - p = void_list_node; > + gcc_assert (parm <= (SPU_MAX_ARGS_TO_BUILTIN + 1)); > + > + for (i = 0; i < ARRAY_SIZE (args); i++) > + args[i] = NULL_TREE; > + >while (

Re: [PATCH] use build_function_type_list in the arm backend

On Wed, 2011-04-20 at 15:59 -0400, Nathan Froyd wrote: > As $SUBJECT suggests. There's one remaining use of build_function_type, > but replace that will have to wait until we have a better > FUNCTION_TYPE-building interface. > > Tested with cross to arm-eabi. OK to commit? > OK. R. > -Natha

Re: [PATCH] use build_function_type_list in the s390 backend

Nathan Froyd wrote: > * config/s390/s390.c (s390_init_builtins): Call > build_function_type_list instead of build_function_type. This is OK. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE ulrich.weig...@de.ibm.com

GCC 4.5.3 Status Report (2011-04-21), branch now frozen

Status == A first release candidate for GCC 4.5.3 is beeing made. The branch is now frozen until after the final 4.5.3 release. All changes require explicit release manager approval. Quality Data Priority # Change from Last Report --- ---

Re: Add an array_mode_supported_p target hook

To get back to this... Richard Sandiford writes: > Richard Guenther writes: >> On Thu, Mar 31, 2011 at 3:32 PM, Richard Sandiford >> wrote: >>> This patch adds an array_mode_supported_p hook, which says whether >>> MAX_FIXED_MODE_SIZE should be ignored for a given type of array. >>> It follows

Re: GCC 4.5.3 Status Report (2011-04-21), branch now frozen

On Thursday 21 April 2011 11:30:49 Richard Guenther wrote: > Status > == > > A first release candidate for GCC 4.5.3 is beeing made. The branch > is now frozen until after the final 4.5.3 release. All changes > require explicit release manager approval. > > > Quality Data > >

Re: Add an array_mode_supported_p target hook

On Thu, Apr 21, 2011 at 11:50 AM, Richard Sandiford wrote: > To get back to this... > > Richard Sandiford writes: >> Richard Guenther writes: >>> On Thu, Mar 31, 2011 at 3:32 PM, Richard Sandiford >>> wrote: This patch adds an array_mode_supported_p hook, which says whether MAX_FIXED_

Re: Ping^2 Re: Target header etc. cleanup patch

On Thu, 21 Apr 2011, Richard Guenther wrote: > On Wed, Apr 20, 2011 at 11:09 PM, Joseph S. Myers > wrote: > > Ping^2.  This patch > > is still pending > > review.  This version applies cleanly to current trunk. > > The s/struct rtx_def */

Re: Ping^2 Re: Target header etc. cleanup patch

Joseph, mingw part is ok, too. Thanks, Kai

[PATCH][ARM] Thumb2 replicated constants

This patch is a repost of the one I previously posted here: http://gcc.gnu.org/ml/gcc-patches/2010-12/msg00652.html As requested, I've broken out the other parts of the original patch, and those have already been reposted yesterday (and one committed also). This (final) part is support for

[PATCH] Handle returns in ref_maybe_used_by_stmt_p

With all returns now having virtual operands we can trivially arrive at them during alias walks. Instead of always returning true as we did sofar this patch makes us more precise, also handle the fact that a function return implicitly is a use for all values that escape (now, hopefully I will get

[PATCH] Fix gcc_release to not build GO tarballs on old branches

This changes maybe_build_tarfile to require that the first directory in the list actually exists. This avoids building a GO tarball on old branches where neither gcc/go nor libgo exist but libffi does. I have built the 4.5.3 release candidate with this patch applied. Looks ok? Thanks, Richard.

[PATCH, i386]: Fix target/48708 - Invalid V2DI vector set insn generated

Hello! ix86_expand_vector_set (around line 31485) synthesizes unrecognisable vec_concat/vec_select insn in invalid mode. The problem is, that V2DImode goes through the same code path as V2DFmode. 2011-04-21 Uros Bizjak * config/i386/i386.c (ix86_expand_vector_set) : Generate v

Re: [PATCH] Fix gcc_release to not build GO tarballs on old branches

On Thu, Apr 21, 2011 at 01:36:53PM +0200, Richard Guenther wrote: > > This changes maybe_build_tarfile to require that the first directory > in the list actually exists. This avoids building a GO tarball on > old branches where neither gcc/go nor libgo exist but libffi does. > > I have built the

Re: [PATCH] Fix gcc_release to not build GO tarballs on old branches

On Thu, 21 Apr 2011, Jakub Jelinek wrote: > On Thu, Apr 21, 2011 at 01:36:53PM +0200, Richard Guenther wrote: > > > > This changes maybe_build_tarfile to require that the first directory > > in the list actually exists. This avoids building a GO tarball on > > old branches where neither gcc/go n

Re: [Patch,AVR]: Solve PR42210

Georg-Johann Lay schrieb: > This solves some missed optimization that can be seen when moving > around bits. > > There are 4 combiner patterns that operate on regs and one that uses > them as intermediate patterns and works on I/O. Even if just an > intermediate pattern matches it's still an impro

Re: [PATCH] Optimize (x * 8) | 5 and (x << 3) ^ 3 to use lea (PR target/48688)

On Wed, Apr 20, 2011 at 10:27:36AM -0700, Richard Henderson wrote: > On 04/20/2011 09:09 AM, Jakub Jelinek wrote: > > Hi! > > > > This splitter allows us to optimize (x {* {2,4,8},<< {1,2,3}}) {|,^} y > > for constant integer y <= {1ULL,3ULL,7ULL} using lea{l,q} (| or ^ in > > that case, when the

[committed]: vms/ia64: avoid a crash if -mdebug-main is used without -g

Hi, this simple patch adds a guard to avoid a crash. As -mdebug-main directly calls dwarf2out, debug_info_level should be checked before. Committed on trunk. Tristan. 2011-04-21 Tristan Gingold * config/ia64/ia64.c (ia64_start_function): Add a guard. --- gcc/config/ia64/ia64.c

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

Mike, [Could you please configure your mail client to break lines? It's hard to reply to messages all on a single line. Thanks.] > On Apr 19, 2011, at 11:12 AM, Rainer Orth wrote: >> I've had a closer look now and think it's possible (and desirable) to >> define HAVE_GAS_HIDDEN for Darwin, too.

[vms/committed]: avoid wrong output by vmsdbgout.c for long path

Hi, vmsdbgout could generate buggy records for long path. This happened while cross-compiling. Committed on trunk. Tristan. 2011-04-21 Tristan Gingold * vmsdbgout.c (write_srccorr): Compute file length from the string. (dst_file_info_struct): Remove flen field. (lo

[PATCH][1/n] Alias housekeeping

Remove INDIRECT_REF times code, don't use the strange SSA_VAR_P predicate. Simple cleanups, catched a case where we still build an INDIRECT_REF. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-04-21 Richard Guenther * tree-ssa-alias.c (ptr_deref

Re: [PATCH] Don't use ./tmp0 for site.exp generation

Richard Guenther writes: >> Perhaps it would be better to use site.tmp to match current git >> automake? > > I can certainly use any other temporary name, just the tmp0 use > is annoying ;) It's a matter of a single search-and-replace. Although this isn't exactly part of the testsuite itself, g

Re: [RFC] OpenMP 3.1 atomics

On Thu, Mar 03, 2011 at 05:54:32PM +0100, Jakub Jelinek wrote: > This patch is a WIP patch for OpenMP 3.1 atomics, so far for C FE only. > It handles parsing (I created 3 new tree codes for atomic read, > atomic capture of the old and of the new value), gimplification and > omp expansion thereof, b

Re: [PATCH] Don't use ./tmp0 for site.exp generation

On Thu, 21 Apr 2011, Rainer Orth wrote: > Richard Guenther writes: > > >> Perhaps it would be better to use site.tmp to match current git > >> automake? > > > > I can certainly use any other temporary name, just the tmp0 use > > is annoying ;) It's a matter of a single search-and-replace. > >

Re: better wpa [1/n]: merge types during read-in

Hi, On Wed, 20 Apr 2011, Michael Matz wrote: > > It would have been nice to have the top-level tree merging as a > > separate patch, as I am not convinced it is correct, but see below ... > > I'll split it out. Like so (also including the other remarks). Regstrapping on x86_64-linux in progre

Re: [patch, fortran] PR 48405 - Front end expressions in DO loops

Am 19.04.2011 20:35, schrieb Thomas Koenig: Hello world, this patch fixes the enhancement PR, plus probably a few regressions. The basic problem was that the code walker got confused when *c, the pointer to the current gfc_code statement, was changed by inserting additional code. Currently reg

Re: [PATCH] use build_function_type_list in the frv backend

Hi Nathan, * config/frv/frv.c (frv_init_builtins): Delete `endlink' variable. Call builtin_function_type_list instead of builtin_function_type. (UNARY, BINARY, TRINARY, QUAD): Likewise. Approved - please apply. Cheers Nick

Re: [PATCH] use build_function_type_list in the iq2000 backend

Hi Nathan, * config/iq2000/i2000.c (iq2000_init_builtins): Call build_function_type_list instead of build_function_type. Delete `endlink' variable. Approved - please apply. Cheers Nick

Re: [PATCH] use build_function_type_list in the stormy16 backend

Hi Nathan, * config/stormy16/stormy16 (xstormy16_init_builtins): Call build_function_type_list instead of build_function_type. Rearrange initialization of `args' to do so. Approved - please apply. Cheers Nick

Re: [patch, fortran] PR 48405 - Front end expressions in DO loops

On Thursday 21 April 2011 16:02:18 Thomas Koenig wrote: > Am 19.04.2011 20:35, schrieb Thomas Koenig: > > Hello world, > > > > this patch fixes the enhancement PR, plus probably a few regressions. > > > > The basic problem was that the code walker got confused when *c, the > > pointer to the curr

Fix ICE during nested functions lowering

The attached testcase triggers an ICE during nested functions lowering, a regression present on the mainline and 4.6 branch. The middle-end is trying to create an object which must be created by the front-end: /* If the type is of variable size or a type which must be created by the fron

[PATCH] Fix PR48703

This fixes the fallout of not re-setting the set_decl_assembler_name langhook with -flto. Bootstrapped and tested on x86_64-unknown-linux-gnu, SPEC2k6 build tested, installed. Richard. 2011-04-21 Richard Guenther PR lto/48703 * tree.c (free_lang_data_in_decl): Do not zero TR

Re: [PATCH] use build_function_type_list in the picochip backend

Looks good to me Nathan. Please go ahead and commit. Thanks Hari On 20/04/11 20:51, Nathan Froyd wrote: As $SUBJECT suggests. Tested with cross to picochip-elf. OK to commit? -Nathan * config/picochip/picochip.c (picochip_init_builtins): Call build_function_type_list instead

Re: better wpa [1/n]: merge types during read-in

On Thu, Apr 21, 2011 at 3:46 PM, Michael Matz wrote: > Hi, > > On Wed, 20 Apr 2011, Michael Matz wrote: > >> > It would have been nice to have the top-level tree merging as a >> > separate patch, as I am not convinced it is correct, but see below ... >> >> I'll split it out. > > Like so (also incl

[PATCH] centralize builtin function type building

This patch does two things: - centralizes some infrastructure for defining builtin function types for frontends by providing a common function that DEF_FUNCTION_TYPE_FOO macros can call; and - in order to do that well, it also introduces build{,_varargs}_function_type_array for cases when

Re: fix memory leak in gengtype

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/20/11 17:35, Dimitrios Apostolou wrote: > > Plus a whole page which is preallocated by the obstack, if I understand > correctly. As a result, for each word in the text file we consume 4KB, > which are never freed. Plausible. Though I always th

Re: Improve stack layout heuristic.

Hi, On Wed, 20 Apr 2011, Easwaran Raman wrote: > But you're right - not adding that conflict doesn't actually reduce the > size of bit maps. Reverting back to what was there originally. Thanks, I have no more issues with the patch. You'll need to find someone who can formally approve it, thou

Re: [RFA] [PowerPC]

On 04/20/2011 07:52 PM, Segher Boessenkool wrote: The test and-1.c has wrong logic. In the formula: y & ~(y & -y) The part (y & -y) is always a mask with one bit set, which corresponds to the least significant "1" bit in y. The final result is that bit, is set to zero (y & ~mask) There is no bo

Re: [PATCH] centralize builtin function type building

On Thu, Apr 21, 2011 at 5:04 PM, Nathan Froyd wrote: > This patch does two things: > > - centralizes some infrastructure for defining builtin function types >  for frontends by providing a common function that >  DEF_FUNCTION_TYPE_FOO macros can call; and > > - in order to do that well, it also in

Re: Improve stack layout heuristic.

On Thu, Apr 21, 2011 at 5:22 PM, Michael Matz wrote: > Hi, > > On Wed, 20 Apr 2011, Easwaran Raman wrote: > >> But you're right - not adding that conflict doesn't actually reduce the >> size of bit maps. Reverting back to what was there originally. > > Thanks, I have no more issues with the patch.

RFA: Improve jump threading #2 of N

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 For some dumb reason I thought handling threading through a SWITCH_EXPR was hard in VRP; that's definitely not the case, it's no more difficult than handling a COND_EXPR. This patch allows tree-vrp.c to thread through a SWITCH_EXPR when we know the s

Re: [PATCH PING] c++-specific bits of tree-slimming patches

On Thu, 14 Apr 2011, Nathan Froyd wrote: > On Fri, Apr 08, 2011 at 01:50:24PM -0400, Jason Merrill wrote: > > On 03/24/2011 09:15 AM, Nathan Froyd wrote: > >> + tree t = make_node (CASE_LABEL_EXPR); > >> + > >> + TREE_TYPE (t) = void_type_node; > >> + SET_EXPR_LOCATION (t, input_location); > >

Re: [PATCH] make LABEL_DECL has its own rtx field for its associated CODE_LABEL

Hi, On Wed, 20 Apr 2011, Richard Guenther wrote: > > I had occasion to try this today; this inheritance structure doesn't > > work.  The truncated inheritance tree looks like: > > > > * decl_common > >  * field_decl > >  * const_decl > >  * decl_with_rtl > >    * label_decl > >    * result_decl >

Re: [PATCH][ARM] RTABI half-precision conversion functions

On Thu, 14 Apr 2011, Andrew Stubbs wrote: > On 14/02/11 18:20, Joseph S. Myers wrote: > > Is there a reason you didn't add these functions to the shared libgcc > > (adjust t-bpabi and t-symbian accordingly, add them to libgcc-bpabi.ver at > > version GCC_4.6.0)? The GCC-specific names were delibe

Re: [PATCH][C] Do not expand array-refs via pointer arithmetic

On Thu, 14 Apr 2011, Richard Guenther wrote: > 2011-04-14 Richard Guenther > > * c-typeck.c (build_unary_op): Do not expand array-refs via > pointer arithmetic. Only adjust qualifiers for function types. OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] make LABEL_DECL has its own rtx field for its associated CODE_LABEL

On Thu, Apr 21, 2011 at 05:54:28PM +0200, Michael Matz wrote: > > > In particular, FIELD_DECLs have a size, but they have no RTL associated > > > with them.  And LABEL_DECLs have RTL, but no size. > > Blaeh. So far about nice clean ideas :) One hacky idea: change my > proposal to this: > > de

Re: Convert legacy m68k options to .opt aliases

On Thu, 14 Apr 2011, Gunther Nikl wrote: > However, the link spec seems to be harder. > > "%{m68020-*|m68040|m68060:-fl libm020}" > > Do I have to replace every m680x0 option with a matching mcpu= (maybe > even together with a march=) option? Whatever options you want to match that spec shoul

[Ada] Adjust rules for selected files in Makefiles

A few selected files must be compiled with special options in Ada, both for the compiler and the runtime. The attached patch cleans things up a bit in this area and also fixes various minor related issues. Bootstrapped/regtested on i586-suse-linux, applied on the mainline. 2011-04-21 Eric B

Re: [doc] Remove references to mips-tfile on MIPS

Not strictly related to this patch, but there are other cleanups possible because of the only-used-on-Tru64 nature of mips-tdump/mips-tfile. In particular, there are seven target macros (all undocumented) used by those programs and nowhere else in GCC: ALIGN_SYMTABLE_OFFSET CODE_MASK MIPS_IS_S

[cxx-mem-model] contiguous bitfields race implementation

To refresh everyone's memory, here is the problem: struct { unsigned int a : 4; unsigned char b; unsigned int c: 6; } var; void seta(){ var.a = 12; } Stores into cannot touch , so we can't store with anything wider (e.g. a 32 bit store) that will touch . This problem can be

[PATCH] PR c/36750: Suppress missing field initializer warning for '= {0}'

Hello, This patch suppresses the "missing field initializer" warning when a structure is initialized with ` = { 0 }' in C. Even though the PR author asks specifically to suppress (at least) only when a trailing comma is included, results from Google code search suggest that spelling without a com

Re: new option -Wno-maybe-uninitialized

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/07/11 18:24, Xinliang David Li wrote: > Hi, > > the following patch implements the option to fine control the emitted > warnings -- > 1) allow suppressing warnings for use of values that may be > uninitialized. Definitely uninitialized values t

Re: RFA: Improve jump threading #2 of N

> Bootstrapped and regression tested on x86_64-unknown-linux-gnu.  OK for > trunk? Would this also fix PR18046? Ciao! Steven

Re: FDO usability patch -- cfg and lineno checksum

On Tue, Apr 19, 2011 at 15:47, Xinliang David Li wrote: > The attached is the revised patch with a warning suggested for cases > when CFG matches, but source locations change. > > Ok for trunk? The tree.c changes are OK. Diego.

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

Ping .. David On Wed, Apr 20, 2011 at 9:34 AM, Xinliang David Li wrote: > This would work if there is a way to set Werror=coverage-mismatch > without having to explicitly set the option classification as > DK_ERROR.   Does this mechanism exist? > > Thanks, > > David > > On Tue, Apr 19, 2011 at 1

Re: RFA: Improve jump threading #2 of N

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/21/11 11:26, Steven Bosscher wrote: >> Bootstrapped and regression tested on x86_64-unknown-linux-gnu. OK for >> trunk? > > Would this also fix PR18046? Not right now. If we look at VRP2 (and this only affects VRP's jump threading) we have: S

Re: new option -Wno-maybe-uninitialized

On Thu, Apr 21, 2011 at 10:21 AM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/07/11 18:24, Xinliang David Li wrote: >> Hi, >> >> the following patch implements the option to fine control the emitted >> warnings -- >> 1) allow suppressing warnings for use of values t

Re: fix memory leak in gengtype

On Thu, 21 Apr 2011, Laurynas Biveinis wrote: :( Why don't you get yourself a compile farm account? http://gcc.gnu.org/wiki/CompileFarm Thanks Laurynas, I am absolutely thrilled to see such a variety of hardware! I'll try applying, but I'm not sure I'm eligible, my contributions to OSS are

Re: [Patch,AVR]: Solve PR42210

On 04/21/2011 05:31 AM, Georg-Johann Lay wrote: > +;; Some combiner patterns dealing with bits. > +;; See PR42210 > + > +;; Move bit $3.$4 into bit $0.$4 > +(define_insn "*movbitqi.1-6.a" ... > +(define_insn "*movbitqi.1-6.b" ... > +(define_insn "*movbitqi.0" ... > +(define_insn "*movbitqi.7" This

[PATCH] PR 48175, Make CASE_VALUES_THRESHOLD settable via --param

In looking at some improvements to the powerpc, we wanted to change the default for when a table jump is generated vs. a series of if statements. Now, we could just add a powerpc specific TARGET_CASE_VALUES_THRESHOLD, but I tend to think that these should be settable on all/most ports with --param

Re: [PATCH] centralize builtin function type building

On Thu, Apr 21, 2011 at 05:36:42PM +0200, Richard Guenther wrote: > On Thu, Apr 21, 2011 at 5:04 PM, Nathan Froyd > wrote: > > This patch does two things: > > > > - centralizes some infrastructure for defining builtin function types > >  for frontends by providing a common function that > >  DEF_

Re: Improve stack layout heuristic.

On Thu, Apr 21, 2011 at 8:43 AM, Richard Guenther wrote: > On Thu, Apr 21, 2011 at 5:22 PM, Michael Matz wrote: >> Hi, >> >> On Wed, 20 Apr 2011, Easwaran Raman wrote: >> >>> But you're right - not adding that conflict doesn't actually reduce the >>> size of bit maps. Reverting back to what was t

Re: [patch, fortran] PR 48405 - Front end expressions in DO loops

Hi Mikael, Regression-testing passed. Ping ** 0.25? Thomas OK. Thanks Waiting for Emacs... Sende fortran/ChangeLog Sende fortran/frontend-passes.c Sende testsuite/ChangeLog Hinzufügen testsuite/gfortran.dg/function_optimize_6.f90 Übertrage Daten

Re: [PATCH] Avoid regressing with the PR48248 change

On Mon, 18 Apr 2011, Richard Guenther wrote: > This avoids changing -P output with the PR48248 fix which appearantly > breaks Chrome (with has bogus assumptions on gcc -E -P output). > > For 4.7 I think we should instead go with the 2nd patch and make -P > output smaller (which is the whole reaso

Re: RFA: Improve jump threading #2 of N

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/21/11 11:26, Steven Bosscher wrote: >> Bootstrapped and regression tested on x86_64-unknown-linux-gnu. OK for >> trunk? > > Would this also fix PR18046? Also note that the assertion machinery doesn't really have the concept of anti-ranges, much

Re: Improve stack layout heuristic.

> 2011-04-21 Easwaran Raman > > * gcc/cfgexpand.c (stack_var): Remove OFFSET... > (add_stack_var): ...and its reference here... > (expand_stack_vars): ...and here. > (stack_var_cmp): Sort by descending order of size. > (partition_stack_vars): Change heuristic. >

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

On Tue, 19 Apr 2011, Xinliang David Li wrote: > 2011-04-18 Neil Vachharajani > > * flags.c: New flag variable. > * opts.c (common_handle_options): Set flag_werror_set. > * opts-global.c (decode_options): Delay Werror decision > for Wcoverage-mismatch util after options are par

Re: [patch] Split Parse Timevar (issue4378056)

On Wed, Apr 20, 2011 at 18:00, Jason Merrill wrote: > On 04/12/2011 11:49 AM, Lawrence Crowl wrote: >> >> This patch is available for review at >> http://codereview.appspot.com/4378056 > > I tried to comment there, but it didn't seem to be working; looking at the > side-by-side diffs didn't show a

Re: [google]Pass --save-temps to the assembler (issue4436049)

On Tue, Apr 19, 2011 at 12:02:08PM -0700, Easwaran Raman wrote: > This makes the gcc driver pass the --save-temps option to the assembler or > assembler wrapper so that post-assembly tools like MAO can be integrated. > Bootstraps on x86_64. Ok for google/main? > > 2011-04-19 Easwaran Raman >

Re: [PATCH] PR c/36750: Suppress missing field initializer warning for '= {0}'

On Thu, 21 Apr 2011, Alexander Monakov wrote: > Hello, > > This patch suppresses the "missing field initializer" warning when a structure > is initialized with ` = { 0 }' in C. Even though the PR author asks > specifically to suppress (at least) only when a trailing comma is included, > results

Re: FDO usability: pid handling

> @@ -730,6 +726,8 @@ void cgraph_clone_inlined_nodes (struct > void compute_inline_parameters (struct cgraph_node *); > cgraph_inline_failed_t cgraph_edge_inlinable_p (struct cgraph_edge *); > > +void cgraph_init_node_map (void); > +void cgraph_del_node_map (void); Given that you don't even

Re: Improve stack layout heuristic.

On Thu, Apr 21, 2011 at 12:30 PM, Eric Botcazou wrote: >> 2011-04-21  Easwaran Raman   >> >>       * gcc/cfgexpand.c (stack_var): Remove OFFSET... >>       (add_stack_var): ...and its reference here... >>       (expand_stack_vars): ...and here. >>       (stack_var_cmp): Sort by descending order of

Re: FDO usability: pid handling

On Thu, Apr 21, 2011 at 1:36 PM, Jan Hubicka wrote: >> @@ -730,6 +726,8 @@ void cgraph_clone_inlined_nodes (struct >>  void compute_inline_parameters (struct cgraph_node *); >>  cgraph_inline_failed_t cgraph_edge_inlinable_p (struct cgraph_edge *); >> >> +void cgraph_init_node_map (void); >> +void

Re: FDO usability patch -- cfg and lineno checksum

> > I don't really follow the logic here.  buffer is allocated to be size of > > block+4 and it is expected that gcov_write_words is not executed on size > > greater than 4.  Since gcov_write_string now seems to be expected to handle > > strings of bigger size, I think you acually need to make writ

Re: FDO usability: pid handling

> On Thu, Apr 21, 2011 at 1:36 PM, Jan Hubicka wrote: > >> @@ -730,6 +726,8 @@ void cgraph_clone_inlined_nodes (struct > >>  void compute_inline_parameters (struct cgraph_node *); > >>  cgraph_inline_failed_t cgraph_edge_inlinable_p (struct cgraph_edge *); > >> > >> +void cgraph_init_node_map (voi

Re: FDO usability patch -- cfg and lineno checksum

On Thu, Apr 21, 2011 at 1:43 PM, Jan Hubicka wrote: >> > I don't really follow the logic here.  buffer is allocated to be size of >> > block+4 and it is expected that gcov_write_words is not executed on size >> > greater than 4.  Since gcov_write_string now seems to be expected to handle >> > stri

Re: [google]Pass --save-temps to the assembler (issue4436049)

On Thu, Apr 21, 2011 at 12:07 PM, Michael Meissner wrote: > On Tue, Apr 19, 2011 at 12:02:08PM -0700, Easwaran Raman wrote: >> This makes the gcc driver pass the --save-temps option to the assembler or >> assembler wrapper so that post-assembly tools like MAO can be integrated. >> Bootstraps on

Re: [google]Pass --save-temps to the assembler (issue4436049)

On Thu, Apr 21, 2011 at 3:18 PM, Easwaran Raman wrote: > When using gcc with a post-assembly tool, we use a wrapper that > invokes the tool and needs to know if the tool's output (another > assembly file) needs to be saved. The wrapper doesn't generate any > additional .o files and hence doesn't n

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

On Thu, Apr 21, 2011 at 12:54 PM, Joseph S. Myers wrote: > On Tue, 19 Apr 2011, Xinliang David Li wrote: > >> 2011-04-18  Neil Vachharajani   >> >>     * flags.c:  New flag variable. >>     * opts.c (common_handle_options): Set flag_werror_set. >>     * opts-global.c (decode_options): Delay Werror

Re: Group static constructors and destructors in specific subsections, take 2

On Nov 20, 2010, at 5:12 PM, Jan Hubicka wrote: > this is updated patch. I addressed, I hope, all the comments except for > removing USE_SELECT_SECTION_FOR_FUNCTIONS. I am somewhat confused by darwin > and > thus would like to handle it incrementally. > > I've removed the subsection hash, the st

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

On Thu, 21 Apr 2011, Xinliang David Li wrote: > On Thu, Apr 21, 2011 at 12:54 PM, Joseph S. Myers > wrote: > > On Tue, 19 Apr 2011, Xinliang David Li wrote: > > > >> 2011-04-18  Neil Vachharajani   > >> > >>     * flags.c:  New flag variable. > >>     * opts.c (common_handle_options): Set flag_we

Re: [patch] Split Parse Timevar (issue4378056)

On 4/20/11, Jason Merrill wrote: > On 04/12/2011 11:49 AM, Lawrence Crowl wrote: >> This patch is available for review at >> http://codereview.appspot.com/4378056 >> + timevar_start (TV_RESOLVE_OVERLOAD); > > Putting this in perform_overload_resolution isn't enough; only a couple > of cases of ov

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

That will work. Revised patch coming up. Thanks, David On Thu, Apr 21, 2011 at 3:59 PM, Joseph S. Myers wrote: > On Thu, 21 Apr 2011, Xinliang David Li wrote: > >> On Thu, Apr 21, 2011 at 12:54 PM, Joseph S. Myers >> wrote: >> > On Tue, 19 Apr 2011, Xinliang David Li wrote: >> > >> >> 2011-04-

Re: [RFC PATCH, go]: Port to ALPHA arch - sysinfo.go fixup

Rainer Orth writes: > Here's the error I run into: > > /vol/gcc/src/hg/trunk/irix/libgo/go/os/file.go:432:12: error: incompatible > types in assignment (implicit assignment of 'syscall.Timeval' hidden field > '_f0') > /vol/gcc/src/hg/trunk/irix/libgo/go/os/file.go:433:12: error: incompatible >

Re: FDO usability: pid handling

Revised as suggested and committed. Thanks, David On Thu, Apr 21, 2011 at 1:36 PM, Jan Hubicka wrote: >> @@ -730,6 +726,8 @@ void cgraph_clone_inlined_nodes (struct >>  void compute_inline_parameters (struct cgraph_node *); >>  cgraph_inline_failed_t cgraph_edge_inlinable_p (struct cgraph_edge

Re: [patch] Split Parse Timevar (issue4378056)

On 04/21/2011 07:17 PM, Lawrence Crowl wrote: @@ -1911,7 +1911,7 @@ ggc_collect (void) - timevar_push (TV_GC); + timevar_start (TV_GC); Why this change? GC time shouldn't be counted against whatever we happen to be parsing when it happens. If not, then code that generates lots of garbage d

Re: [PATCH PING] c++-specific bits of tree-slimming patches

On Fri, Apr 08, 2011 at 01:50:24PM -0400, Jason Merrill wrote: > On 03/24/2011 09:15 AM, Nathan Froyd wrote: >> + tree t = make_node (CASE_LABEL_EXPR); >> + >> + TREE_TYPE (t) = void_type_node; >> + SET_EXPR_LOCATION (t, input_location); > > As jsm and richi said, using input_location like this

fix up hot/cold partitioning on ports that don't have long conditional branches

This patch fixes up hot/cold partitioning on ports that don't have long conditional branches. I'll note that the entire file has lots of other jump optimizations that are suspect. Ok? 2011-04-21 Mike Stump * reorg.c (relax_delay_slots): Don't delete a jump that crosses a se

Re: Fix 20020425-1.c

Ping? On Apr 12, 2011, at 4:36 PM, Mike Stump wrote: > This fixes 20020425-1.c when the compiler under test is built with -O0 and > we're on a machine with an 8 meg stack. > > Ok? > > 2011-04-12 Mike Stump > > * c-typeck.c (c_finish_if_stmt): Fold result. > * fold-const.c (fold

Update my email address

Hi, I have committed this patch to update my email address. Jie 2011-04-21 Jie Zhang * MAINTAINERS: Update my email address. Index: MAINTAINERS === --- MAINTAINERS (revision 172853) +++ MAINTAINERS (working copy) @@ -49,7 +49,

Re: [PATCH PING] c++-specific bits of tree-slimming patches

On 04/21/2011 08:50 PM, Nathan Froyd wrote: On Fri, Apr 08, 2011 at 01:50:24PM -0400, Jason Merrill wrote: As jsm and richi said, using input_location like this is a regression. Can we use DECL_SOURCE_LOCATION (label_decl) instead? I went off and tried that; some callers provide a NULL label_d

Re: [PATCH] use build_function_type_list in the bfin backend

On 04/20/2011 03:24 PM, Nathan Froyd wrote: As $SUBJECT suggests. Tested with cross to bfin-elf. OK to commit? OK. Thanks! Jie -Nathan * config/bfin/bfin.c (bfin_init_builtins): Call build_function_type_list instead of build_function_type. diff --git a/gcc/config/bfin/bfi

Re: [PATCH PING] c++-specific bits of tree-slimming patches

On Thu, Apr 21, 2011 at 10:49:05PM -0400, Jason Merrill wrote: > On 04/21/2011 08:50 PM, Nathan Froyd wrote: >> On Fri, Apr 08, 2011 at 01:50:24PM -0400, Jason Merrill wrote: >>> As jsm and richi said, using input_location like this is a regression. >>> Can we use DECL_SOURCE_LOCATION (label_decl)

Re: Ping^2 Re: Target header etc. cleanup patch

On 04/21/2011 06:06 AM, Joseph S. Myers wrote: On Thu, 21 Apr 2011, Richard Guenther wrote: On Wed, Apr 20, 2011 at 11:09 PM, Joseph S. Myers wrote: Ping^2. This patch is still pending review. This version applies cleanly to curren

Re: Allow more PowerPC sibling calls

On Mon, Apr 18, 2011 at 10:29:17AM -0700, Nathan Froyd wrote: > Could I request that you use FOREACH_FUNCTION_ARGS in these two cases? > The conversion is trivial, and avoiding more exposed TYPE_ARG_TYPES > calls is a good thing. Committed revision 172855. -- Alan Modra Australia Development Lab

  1   2   >