[PATCH] use build_function_type_list in the sh backend

2011-04-20 Thread Nathan Froyd
As $SUBJECT suggests. The only tricky bit is the initialization of `args' to NULL_TREEs so that we can safely pass all of the relevant args to build_function_type_list, regardless of whether the function type in question has that many args. Tested with cross to sh-elf. OK to commit? -Nathan

Re: Second ping for cannot_force_const_mem & LEGITIMATE_CONSTANT_P changes

2011-04-20 Thread Richard Henderson
On 04/18/2011 02:30 AM, Richard Sandiford wrote: > Ping for these two changes: > > http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00194.html > http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00195.html > Both ok. r~

Re: [patch] Do not generate discriminator directive in strict mode

2011-04-20 Thread Richard Henderson
On 04/20/2011 12:09 PM, Eric Botcazou wrote: >> How is this not redundant with the existing >> >> /* The discriminator column was added in dwarf4. Simplify the below >> by simply removing it if we're not supposed to output it. */ >> if (dwarf_version < 4 && dwarf_strict) >> discrimin

fix memory leak in gengtype

2011-04-20 Thread Dimitrios Apostolou
Hello list, while trying to build gcc-4.6.0 on my sparcstation, I got gengtype OOM killed. That's when I noticed that its RAM usage peaks at 150MB, which is a bit excessive for parsing a ~500K text file. The attached patch fixes the leak and gengtype now uses a peak of 4MB heap. Hopefully I

Re: [PATCH] use build_function_type_list a few places in the ObjC frontend

2011-04-20 Thread Mike Stump
On Apr 20, 2011, at 10:27 AM, Nathan Froyd wrote: > Tested on x86_64-unknown-linux-gnu. IIUC the changes to > objc-next-runtime-abi-02.c would not be tested on that platform, so it > would be helpful to have a Darwin tester double-check my work. Just check http://gcc.gnu.org/regtest/HEAD/ after a

Ping^2 Re: Target header etc. cleanup patch

2011-04-20 Thread Joseph S. Myers
Ping^2. This patch is still pending review. This version applies cleanly to current trunk. 2011-04-20 Joseph Myers * config/alpha/alpha.c (struct machine_function): Use rtx, not struct rtx_def *. * config/bfi

Re: [PATCH] use build_function_type_list in the ia64 backend

2011-04-20 Thread Steve Ellcey
On Wed, 2011-04-20 at 13:03 -0700, Nathan Froyd wrote: > On Wed, Apr 20, 2011 at 03:29:19PM -0400, Nathan Froyd wrote: > > As $SUBJECT suggests. Tested with cross to ia64-linux-gnu. OK to > > commit? > > > > - ftype = build_function_type (float128_type, void_list_node); > > - decl = add

Ping Re: Don't use linux.h for non-Linux targets

2011-04-20 Thread Joseph S. Myers
Ping. This patch is pending review. -- Joseph S. Myers jos...@codesourcery.com

Re: Ping^2 Re: Target header etc. cleanup patch

2011-04-20 Thread DJ Delorie
The m32c one is OK

Re: [PATCH] use build_function_type_list in the ia64 backend

2011-04-20 Thread Nathan Froyd
On Wed, Apr 20, 2011 at 02:09:49PM -0700, Steve Ellcey wrote: > I am not sure what the patch would look like then. You removed the > assignment to decl, so what are you putting in ia64_builtins? Can you > send the full correct patch. Sure. Updated patch below, which probably looks somewhat more

Re: [PATCH] use build_function_type_list in the ia64 backend

2011-04-20 Thread Steve Ellcey
On Wed, 2011-04-20 at 17:25 -0400, Nathan Froyd wrote: > On Wed, Apr 20, 2011 at 02:09:49PM -0700, Steve Ellcey wrote: > > I am not sure what the patch would look like then. You removed the > > assignment to decl, so what are you putting in ia64_builtins? Can you > > send the full correct patch.

Re: [patch] Split Parse Timevar (issue4378056)

2011-04-20 Thread Jason Merrill
On 04/12/2011 11:49 AM, Lawrence Crowl wrote: This patch is available for review at http://codereview.appspot.com/4378056 I tried to comment there, but it didn't seem to be working; looking at the side-by-side diffs didn't show any changes, and double-clicking on a line in the patch form didn

Re: Fix PR48703: segfault in mangler due to -g

2011-04-20 Thread Michael Matz
Hi, I wrote: > Basically we have to set assembler names early also for TYPE_DECLs, we > can't rely on the frontends langhook to do that after free_lang_data. > > Okay for trunk assuming regstrapping on x86_64-linux works? Patch retracted, doesn't even survive testsuite. The problem is that we

Re: fix memory leak in gengtype

2011-04-20 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/20/11 15:08, Dimitrios Apostolou wrote: > Hello list, > > while trying to build gcc-4.6.0 on my sparcstation, I got gengtype OOM > killed. That's when I noticed that its RAM usage peaks at 150MB, which > is a bit excessive for parsing a ~500K te

Re: [patch testsuite committed] Skip gcc.dg/torture/pr37868.c on sh

2011-04-20 Thread Mike Stump
On Apr 20, 2011, at 5:22 AM, Kaz Kojima wrote: > Mike Stump wrote: >> I'd pre-approve hoisting these up into the lib/.exp files and checking a >> generic target requirement... :-) >> >>> -/* { dg-skip-if "unaligned access" { sparc*-*-* } "*" "" } */ >>> +/* { dg-skip-if "unaligned access" { spa

Re: fix memory leak in gengtype

2011-04-20 Thread Dimitrios Apostolou
On Wed, 20 Apr 2011, Jeff Law wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/20/11 15:08, Dimitrios Apostolou wrote: Hello list, while trying to build gcc-4.6.0 on my sparcstation, I got gengtype OOM killed. That's when I noticed that its RAM usage peaks at 150MB, which is a bit ex

Re: [PATCH] use build_function_type_list in the rs6000 backend

2011-04-20 Thread David Edelsohn
On Wed, Apr 20, 2011 at 3:49 PM, Nathan Froyd wrote: > As $SUBJECT suggests.  The only tricky part is in builtin_function_type, > where we fill in unused args with NULL_TREE so that passing extra > arguments to build_function_type_list doesn't matter. > > Tested with cross to powerpc-eabi.  OK to

Re: Ping^2 Re: Target header etc. cleanup patch

2011-04-20 Thread Paul Koning
On Apr 20, 2011, at 5:09 PM, Joseph S. Myers wrote: > Ping^2. This patch > is still pending > review. This version applies cleanly to current trunk. > ... pdp11 is fine. Thanks! paul

Re: [RFA] [PowerPC]

2011-04-20 Thread Segher Boessenkool
The test and-1.c has wrong logic. In the formula: y & ~(y & -y) The part (y & -y) is always a mask with one bit set, which corresponds to the least significant "1" bit in y. The final result is that bit, is set to zero (y & ~mask) There is no boolean simplification possible, and the compiler alw

Re: C++ PATCH for c++/48594 (failure with overloaded ->* in template)

2011-04-20 Thread Jason Merrill
While backporting this to 4.5 and 4.4 I noticed that making the object non-dependent shouldn't be conditionalized. Tested x86_64-pc-linux-gnu, applying to 4.6 and trunk. Applying the two patches folded together on 4.4 and 4.5. commit a39f5c2859bb16af16945830f3c0802c40441b70 Author: Jason Merri

Re: fix memory leak in gengtype

2011-04-20 Thread Laurynas Biveinis
Dimitrios - The patch is OK with a ChangeLog entry. Also a patch to fix the same in gengtype.c:matching_file_name_substitute is pre-approved (but it looks like Jeff will beat you to this :) > P.S. I was trying to test gcc on a rare arch (sparc-unknown-linux-gnu) but > unfortunately the sparcstati

Some small C++ PATCHes

2011-04-20 Thread Jason Merrill
1) While looking at 48530 I noticed that my recent change to put array literals in static storage again needed to check for non-trivial destructors. 2) I also added support for trivial destructors to build_over_call, though it isn't currently used by anything. 3) lookup_fnfields_slot wasn't

Re: FDO usability patch -- cfg and lineno checksum

2011-04-20 Thread Xinliang David Li
On Tue, Apr 19, 2011 at 3:20 PM, Jan Hubicka wrote: > I can not review tree.c changes.  I would probably suggest making crc_byte > inline. Diego, can you review this change? This is just a simple refactoring. > >> +#if IN_LIBGCOV >> + >> +/* These functions are guarded by #if to avoid compile

Go patch committed: Use mpfr_prec_round to constraint floats

2011-04-20 Thread Ian Lance Taylor
This patch to the Go frontend changes it to use mpfr_prec_round rather than real_convert to constrain untyped float or complex constants to their actual type. This is a simplification and also eliminates a call from the frontend to a gcc-specific middle-end function. Bootstrapped and ran Go tests

Ping: Make 128 bits the default vector size for NEON

2011-04-20 Thread Ira Rosen
http://gcc.gnu.org/ml/gcc-patches/2011-03/msg02172.html The last version: ChangeLog: * doc/invoke.texi (preferred-vector-size): Document. * params.h (PREFERRED_VECTOR_SIZE): Define. * config/arm/arm.c (arm_preferred_simd_mode): Use param PREFERRED_VECTOR_SIZE instead of

Re: [PATCH] use build_function_type_list in the avr backend

2011-04-20 Thread Denis Chertykov
2011/4/20 Nathan Froyd : > As $SUBJECT suggests.  Tested with cross to avr-elf.  OK to commit? > > -Nathan > >        * config/avr/avr.c (avr_init_builtins): Call >        build_function_type_list instead of build_function_type. > Please, commit. Denis.

<    1   2