Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-19 Thread Jakub Jelinek
On Mon, Apr 18, 2011 at 03:33:18PM -0700, Jason Merrill wrote: > On 04/18/2011 02:40 PM, Jakub Jelinek wrote: > >If TREE_BINFO has BV_VCALL_INDEX set, this needs to be dynamically > >adjusted, but none of the callers are prepared to handle that. > > Well, it means that we do dynamic adjustment at

FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-19 Thread Xinliang David Li
-Wcoverage-mismatch is enabled by default, and the warning is promoted to error by default. However in the current implementation -Wno-error can not demote the error back to warning. The patch was ported from one contributed by Neil. OK for trunk after regression testing? 2011-04-18 Neil Vachha

Re: [Patch, fortran] Use xcalloc instead of gfc_getmem

2011-04-19 Thread Janne Blomqvist
On Mon, Apr 18, 2011 at 23:50, Steve Kargl wrote: > On Mon, Apr 18, 2011 at 11:41:33PM +0300, Janne Blomqvist wrote: >> Hi, >> >> the attached patch replaces gfc_getmem with calls to xcalloc (from >> libiberty). Apart from reducing duplicated code, calloc is better than >> malloc + memset, as the

Re: [Patch, fortran] Use xcalloc instead of gfc_getmem

2011-04-19 Thread Jakub Jelinek
On Tue, Apr 19, 2011 at 10:41:33AM +0300, Janne Blomqvist wrote: > On Mon, Apr 18, 2011 at 23:50, Steve Kargl > wrote: > > On Mon, Apr 18, 2011 at 11:41:33PM +0300, Janne Blomqvist wrote: > >> Hi, > >> > >> the attached patch replaces gfc_getmem with calls to xcalloc (from > >> libiberty). Apart f

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-19 Thread Richard Guenther
On Tue, Apr 19, 2011 at 2:15 AM, Jan Hubicka wrote: >> > Hi! >> > >> > If TREE_BINFO has BV_VCALL_INDEX set, this needs to be dynamically >> > adjusted, but none of the callers are prepared to handle that. >> > Thus, this patch makes devirtualization give up in those cases. >> > >> > Bootstrapped/

Re: FDO usage: -Wcoverage-mismatch should not ignore -Wno-error

2011-04-19 Thread Richard Guenther
On Tue, Apr 19, 2011 at 9:13 AM, Xinliang David Li wrote: > -Wcoverage-mismatch is enabled by default, and the warning is promoted > to error by default. However in the current implementation -Wno-error > can not demote the error back to warning. The patch was ported from > one contributed by Neil

[vms] committed: add wrappers for ld and ar

2011-04-19 Thread Tristan Gingold
Hi, as the native vms linker ('link') doesn't follow at all the unix convention, we need to convert and massage the command line before invoking the native linker. The easiest and least intrusive way is the use of a wrapper. It deals with command line length limitation, filename, extension, li

Re: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-19 Thread Georg-Johann Lay
Anatoly Sokolov schrieb: > Hi. >> >> +/* To track if code will use .bss and/or .data */ >> +static int avr_need_clear_bss_p = 0; >> +static int avr_need_copy_data_p = 0; > > Change type avr_need_clear_bss_p and avr_need_copy_data_p vars to bool. > >> [ASM_OUTPUT_COMMON] > > Use ASM_OUTPUT_ALIGNE

[PATCH] Fix PR46188

2011-04-19 Thread Richard Guenther
This fixes PR46188 on the 4.5 branch by backporting rev. 159907. Instead of carrying over the checking bits I simply removed them on the branch (they had one trivial fallout originally, PR44295). Bootstrapped and tested on x86_64-unknown-linux-gnu, {,-m32} for all languages including Ada and Obj

Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.

2011-04-19 Thread Georg-Johann Lay
Denis Chertykov schrieb: > 2011/4/18 Georg-Johann Lay : >> Denis Chertykov schrieb: >>> 2011/4/17 Denis Chertykov : 2011/4/15 Georg-Johann Lay : > Finally, I exposed alternative #3 of the insns to the register > allocator, because it is not possible to distinguish between > overlap

Re: PR target/46329: Reject Neon structure constants

2011-04-19 Thread Richard Earnshaw
On Mon, 2011-04-18 at 11:12 +0100, Richard Sandiford wrote: > Richard Earnshaw writes: > > I'm uncomfortable about this. Generally the ARM port doesn't work well > > with the target-independent constant pool and it's better to assert that > > this is empty when it comes to final assembly generat

Re: Fix PR47976

2011-04-19 Thread Richard Guenther
On Tue, Apr 12, 2011 at 6:18 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/07/11 04:47, Bernd Schmidt wrote: >> PR47976 is a followup to PR47166; the patch there caused this problem. >> >> The problem occurs in reload. There are two autoinc addresses which >> inhe

[google] remove redundant push {lr} for -mthumb (issue4441050)

2011-04-19 Thread Guozhi Wei
Reload pass tries to determine the stack frame, so it needs to check the push/pop lr optimization opportunity. One of the criteria is if there is any far jump inside the function. Unfortunately at this time gcc can't decide each instruction's length and basic block layout, so it can't know the offs

Re: PATCH [trunk] gengtype should generate ggc_alloc macros in plugin mode on for plugin files

2011-04-19 Thread Basile Starynkevitch
On Tue, 19 Apr 2011 06:42:58 +0300 Laurynas Biveinis wrote: > > Did you test this patch that it bootstraps and that a GTY-using plugin > gets the right set of definitions in the output? I checked both (using MELT as the plugin to test it). I very slightly & trivially improved the patch by updat

Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.

2011-04-19 Thread Denis Chertykov
2011/4/19 Georg-Johann Lay : > How can add, sub etc. be split? This would need an explicit > representation of carry. Yes. Look at http://gcc.gnu.org/ml/gcc/2005-03/msg00871.html Denis.

Re: [google] remove redundant push {lr} for -mthumb (issue4441050)

2011-04-19 Thread Richard Guenther
On Tue, Apr 19, 2011 at 11:41 AM, Guozhi Wei wrote: > Reload pass tries to determine the stack frame, so it needs to check the > push/pop lr optimization opportunity. One of the criteria is if there is any > far jump inside the function. Unfortunately at this time gcc can't decide each > instructi

Re: [patch] Fix PR lto/48148

2011-04-19 Thread Richard Guenther
On Mon, Apr 18, 2011 at 11:45 PM, Eric Botcazou wrote: > Hi, > > this is the assembler error during an LTO bootstrap: > > cc1.ltrans8.s: Assembler messages: > cc1.ltrans8.s:249143: Error: symbol `.Ldebug_info0' is already defined > > In the assembly file: > > .Letext0: >        .file 93 "/home/eri

Re: [google] remove redundant push {lr} for -mthumb (issue4441050)

2011-04-19 Thread Carrot Wei
On Tue, Apr 19, 2011 at 5:57 PM, Richard Guenther wrote: > On Tue, Apr 19, 2011 at 11:41 AM, Guozhi Wei wrote: >> Reload pass tries to determine the stack frame, so it needs to check the >> push/pop lr optimization opportunity. One of the criteria is if there is any >> far jump inside the functio

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-19 Thread Jan Hubicka
> Huh. No, I don't think we want to do any "inlining" as part of > folding. At least not if it > is a correctness issue (is it?). Why does the inliner not simply > inline the thunk function > body? Because thunk functions have no bodies in gimple form and are no functions (at the moment) in cgr

Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.

2011-04-19 Thread Georg-Johann Lay
Denis Chertykov schrieb: > 2011/4/19 Georg-Johann Lay : >> How can add, sub etc. be split? This would need an explicit >> representation of carry. > > Yes. > > Look at http://gcc.gnu.org/ml/gcc/2005-03/msg00871.html Just skimmed the conversation. I thought about making AVR ISA's effects on SREG

Re: [patch] Fix PR lto/48148

2011-04-19 Thread Jakub Jelinek
On Mon, Apr 18, 2011 at 11:45:03PM +0200, Eric Botcazou wrote: > 2011-04-18 Eric Botcazou > > PR lto/48148 > * gimple.c (gimple_types_compatible_p_1) : Do not > merge the types if they have different enumeration identifiers. While I think it is a step in the right direction,

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-19 Thread Richard Guenther
On Tue, 19 Apr 2011, Jan Hubicka wrote: > > Huh. No, I don't think we want to do any "inlining" as part of > > folding. At least not if it > > is a correctness issue (is it?). Why does the inliner not simply > > inline the thunk function > > body? > > Because thunk functions have no bodies in

Re: [patch] Fix PR lto/48148

2011-04-19 Thread Richard Guenther
On Tue, Apr 19, 2011 at 12:21 PM, Jakub Jelinek wrote: > On Mon, Apr 18, 2011 at 11:45:03PM +0200, Eric Botcazou wrote: >> 2011-04-18  Eric Botcazou   >> >>       PR lto/48148 >>       * gimple.c (gimple_types_compatible_p_1) : Do not >>       merge the types if they have different enumeration ide

[Patch, Fortran] PR 48588 - (4.6/4.7 regression) Resolve whole TU before generating code

2011-04-19 Thread Tobias Burnus
Currently, gfortran ships (trans*.c) MODULEs directly while it waits until the end for subroutines, functions and PROGRAM. The latter are then first all resolved and afterwards the middle-end code is generated. In the PR this shows an issue: The a module procedure calls an external subroutine

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-19 Thread Jan Hubicka
> On Tue, 19 Apr 2011, Jan Hubicka wrote: > > > > Huh. No, I don't think we want to do any "inlining" as part of > > > folding. At least not if it > > > is a correctness issue (is it?). Why does the inliner not simply > > > inline the thunk function > > > body? > > > > Because thunk functions

[PATCH][LTO] Fix PR48207, ICE in lhd_set_decl_assembler_name

2011-04-19 Thread Richard Guenther
This avoids ICEing in the default decl-assembler-name hook during compile-time. We are not yet prepared for a world where all important mangling is done before/during free-lang-data, and the default langhook implementation surely isn't the one that would assert so. The following patch simply ret

Re: Fix PR47976

2011-04-19 Thread Richard Guenther
On Tue, Apr 19, 2011 at 11:32 AM, Richard Guenther wrote: > On Tue, Apr 12, 2011 at 6:18 PM, Jeff Law wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 04/07/11 04:47, Bernd Schmidt wrote: >>> PR47976 is a followup to PR47166; the patch there caused this problem. >>> >>> The pro

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-19 Thread Richard Guenther
On Tue, 19 Apr 2011, Jan Hubicka wrote: > > On Tue, 19 Apr 2011, Jan Hubicka wrote: > > > > > > Huh. No, I don't think we want to do any "inlining" as part of > > > > folding. At least not if it > > > > is a correctness issue (is it?). Why does the inliner not simply > > > > inline the thunk f

[patch] Add missing test for DECL_NO_INLINE_WARNING_P

2011-04-19 Thread Eric Botcazou
Hi, tree_inlinable_function_p issues the -Winline warning only if /* We only warn for functions declared `inline' by the user. */ do_warning = (warn_inline && DECL_DECLARED_INLINE_P (fn) && !DECL_NO_INLINE_WARNING_P (fn) && !DECL_IN_SYSTEM_HEAD

Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.

2011-04-19 Thread Denis Chertykov
2011/4/19 Georg-Johann Lay : > Denis Chertykov schrieb: >> 2011/4/19 Georg-Johann Lay : >>> How can add, sub etc. be split? This would need an explicit >>> representation of carry. >> >> Yes. >> >> Look at http://gcc.gnu.org/ml/gcc/2005-03/msg00871.html > > Just skimmed the conversation. I thought

Re: [patch] Add missing test for DECL_NO_INLINE_WARNING_P

2011-04-19 Thread Richard Guenther
On Tue, Apr 19, 2011 at 1:06 PM, Eric Botcazou wrote: > Hi, > > tree_inlinable_function_p issues the -Winline warning only if > >  /* We only warn for functions declared `inline' by the user.  */ >  do_warning = (warn_inline >                && DECL_DECLARED_INLINE_P (fn) >                && !DECL

[testsuite]: Skip some tests for avr

2011-04-19 Thread Georg-Johann Lay
This patchlet skips some tests for avr because int is just 16 bits there. Johann testsuite/ 2011-04-19 Georg-Johann Lay * gcc.c-torture/compile/pr43191.c: Skip avr due to 16-bit int. * gcc.dg/torture/pr43165.c: Ditto. * gcc.dg/torture/pr47228.c: Ditto. * gcc.d

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-04-19 Thread Paolo Bonzini
On 04/04/2011 06:15 PM, Rainer Orth wrote: I haven't found if there are provisions for in-tree gold, though, and still cannot test that. In-tree gold definitely works (or should). Paolo

Re: [testsuite]: Skip some tests for avr

2011-04-19 Thread Hans-Peter Nilsson
On Tue, 19 Apr 2011, Georg-Johann Lay wrote: > This patchlet skips some tests for avr because int is just 16 bits there. > 2011-04-19 Georg-Johann Lay > > * gcc.c-torture/compile/pr43191.c: Skip avr due to 16-bit int. > * gcc.dg/torture/pr43165.c: Ditto. > * gcc.dg/torture/pr4

Re: Improve stack layout heuristic.

2011-04-19 Thread Michael Matz
Hi, On Mon, 18 Apr 2011, Easwaran Raman wrote: > > > @@ -596,7 +581,7 @@ > > >    if (vb->conflicts) > > >      { > > >        EXECUTE_IF_SET_IN_BITMAP (vb->conflicts, 0, u, bi) > > > -     add_stack_var_conflict (a, stack_vars[u].representative); > > > +     add_stack_var_conflict (a, u); > > >

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-19 Thread Michael Matz
Hi, On Mon, 18 Apr 2011, Janne Blomqvist wrote: > (Why we, in the age of non-sucky version control, persist in keeping > manual changelog files is beyond me..) The one single reason why I'm very happy about our ChangeLog file policy is that I can grep it easily. Listing the changelog of the w

Re: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-19 Thread Anatoly Sokolov
Hi. + +/* Implement `ASM_OUTPUT_ALIGNED_DECL_LOCAL' */ +/* Track need of __do_clear_bss */ Put dot and two spaces after the end of a sentence. The same for other commens in this patch. + +void +avr_asm_output_aligned_decl_local (FILE * stream, const_tree decl ATTRIBUTE_UNUSED, +

Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.

2011-04-19 Thread Richard Earnshaw
On Tue, 2011-04-19 at 15:17 +0400, Denis Chertykov wrote: > 2011/4/19 Georg-Johann Lay : > > Denis Chertykov schrieb: > >> 2011/4/19 Georg-Johann Lay : > >>> How can add, sub etc. be split? This would need an explicit > >>> representation of carry. > >> > >> Yes. > >> > >> Look at http://gcc.gnu.o

Re: [google] remove redundant push {lr} for -mthumb (issue4441050)

2011-04-19 Thread Richard Earnshaw
On Tue, 2011-04-19 at 17:41 +0800, Guozhi Wei wrote: > Reload pass tries to determine the stack frame, so it needs to check the > push/pop lr optimization opportunity. One of the criteria is if there is any > far jump inside the function. Unfortunately at this time gcc can't decide each > instruct

Re: [PATCH][LTO] Fix PR48207, ICE in lhd_set_decl_assembler_name

2011-04-19 Thread Diego Novillo
On Tue, Apr 19, 2011 at 06:51, Richard Guenther wrote: > 2011-04-19  Richard Guenther   > >        PR lto/48207 >        * tree.c (free_lang_data): Do not reset the decl-assembler-name >        langhook. > >        * g++.dg/lto/pr48207_0.C: New testcase. OK, if it's only problematic with debug i

Re: Inliner heuristics facelift

2011-04-19 Thread H.J. Lu
On Sun, Apr 17, 2011 at 7:14 AM, Jan Hubicka wrote: > Hi, > there is now tracking PR48636 for fortran inlining issues.  I would suggest > reporting problems like this there or PR that blocks it instead of sending it > to different threads so we have track of them.  It is quite important to get > s

Re: RFA: Gimple calls to "internal" functions

2011-04-19 Thread Richard Sandiford
Richard Guenther writes: >> We really should be able to treat calls to pure internal functions >> like calls to pure "real" functions though. >> >> TBH, I think this is an example of why trying to so hard to avoid a tree >> code for the internal function is working against us.  Most of the patch >

[v3] fix libstdc++/48521

2011-04-19 Thread Jonathan Wakely
2011-04-19 Jonathan Wakely PR libstdc++/48521 * include/std/type_traits (result_of): Handle pointer to member. * include/std/functional (__invoke): Likewise. (_Function_to_function_pointer): Remove. (_Reference_wrapper_base): Provide nested types independ

Re: RFA: Gimple calls to "internal" functions

2011-04-19 Thread Richard Guenther
On Tue, Apr 19, 2011 at 3:14 PM, Richard Sandiford wrote: > Richard Guenther writes: >>> We really should be able to treat calls to pure internal functions >>> like calls to pure "real" functions though. >>> >>> TBH, I think this is an example of why trying to so hard to avoid a tree >>> code for

Re: RFA: Gimple calls to "internal" functions

2011-04-19 Thread Diego Novillo
On 04/19/2011 09:14 AM, Richard Sandiford wrote: Tested on x86_64-linux-gnu and arm-linux-gnueabi. OK to install? OK with me. Thanks for your patience. Just a couple of minor nits below + extern const int internal_fn_flags_array[]; + return internal_fn_flags_array[(int) fn]; +} + +exte

[patch] Do not generate discriminator directive in strict mode

2011-04-19 Thread Eric Botcazou
Hi, it appears that the (standard DWARF as of version 4) discriminator directive can confuse non-GDB DWARF 2/3 debuggers, so this patch changes the compiler to stop emitting it in strict mode. Tested on i586-suse-linux, OK for the mainline? 2011-04-19 Eric Botcazou * dwarf2out.c (

[PATCH] Don't use ./tmp0 for site.exp generation

2011-04-19 Thread Richard Guenther
This patch sits in all my development trees because delta uses tmp? named directories for storing intermediate files. This causes a make check to fail. Maybe there is an even better way to create a truly temporary file name (that is even portable), but the following patch simply avoids using tmp

Re: [PATCH] Don't use ./tmp0 for site.exp generation

2011-04-19 Thread Rainer Orth
Richard Guenther writes: > This patch sits in all my development trees because delta uses > tmp? named directories for storing intermediate files. This causes > a make check to fail. > > Maybe there is an even better way to create a truly temporary file > name (that is even portable), but the fo

Re: [PATCH] Don't use ./tmp0 for site.exp generation

2011-04-19 Thread Richard Guenther
On Tue, 19 Apr 2011, Rainer Orth wrote: > Richard Guenther writes: > > > This patch sits in all my development trees because delta uses > > tmp? named directories for storing intermediate files. This causes > > a make check to fail. > > > > Maybe there is an even better way to create a truly te

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-19 Thread Jan Hubicka
> I thought the idea was to use __builtin_va_arg_pack and friends. > Of course the inliner would still need to know how to inline such > a va-arg forwarder, and we would need a way to expand them (well, > or just go the existing special casing). We might need this > kind of inliner support anyway

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-19 Thread Richard Guenther
On Tue, 19 Apr 2011, Jan Hubicka wrote: > > I thought the idea was to use __builtin_va_arg_pack and friends. > > Of course the inliner would still need to know how to inline such > > a va-arg forwarder, and we would need a way to expand them (well, > > or just go the existing special casing). We

Fix hot/cold code in ipa-cp

2011-04-19 Thread Jan Hubicka
Hi, while removing use of optimize_function_for_size_p from the ipa-inliner (since we already check cgraph_maybe_hot_edge_p that include the test), I noticed that optimize_function_for_size_p (DECL_STRUCT_FUNCTION (node->decl)) won't give the expected results on WPA when DECL_STRUCT_FUNCTION is N

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-19 Thread Jan Hubicka
Hi, > > Well, even for the partial inlining case I'd devise a scheme that > if a call to such a forwarder remains it gets expanded as a call to > the original (non-split) function (similar to emitting a call to > the asm-thunk instead of expanding the gimple representation of the > thunk). I rea

Re: [PATCH][ARM] New testcases for NEON

2011-04-19 Thread Richard Earnshaw
On Wed, 2011-04-13 at 16:59 +0100, Andrew Stubbs wrote: > Hi, > > This old patch has been carried in the CodeSourcery toolchain for some > time now. It just adds a few new testcases for vectorization. > > OK? > > Andrew OK. 2008-12-03 Daniel Jacobowitz gcc/testsuite/ * gcc

Make vectoriser use operand_equal_p to compare base addresses

2011-04-19 Thread Richard Sandiford
In the attached testcase, we treat: sum += x[i][0] * x[i][0] + x[i][1] * x[i][1]; as being two independent strided loads: x[i][0] and x[i][1]. On targets with appropriate support, we therefore use two interleaved loads rather than one, then discard one half of each result. This does not happe

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-19 Thread Jim Meyering
Michael Matz wrote: > On Mon, 18 Apr 2011, Janne Blomqvist wrote: > >> (Why we, in the age of non-sucky version control, persist in keeping >> manual changelog files is beyond me..) > > The one single reason why I'm very happy about our ChangeLog file policy > is that I can grep it easily. Listing

[PATCH] Disallow i?86/x86_64 movstrict for subregs of non-MODE_INT regs (PR target/48678)

2011-04-19 Thread Jakub Jelinek
Hi! Since MEM_REF has been added, we can unlike in 4.5 and earlier, arbitrary VCEs on the LHS. Reload isn't able to reload (strict_low_part (subreg:HI (reg:V2DI ...))) on the LHS, while it probably should be taught to do that, such movstrict[qh]i IMHO will only very rarely lead to good code, unle

Re: Make vectoriser use operand_equal_p to compare base addresses

2011-04-19 Thread Richard Guenther
On Tue, Apr 19, 2011 at 4:59 PM, Richard Sandiford wrote: > In the attached testcase, we treat: > >    sum += x[i][0] * x[i][0] + x[i][1] * x[i][1]; > > as being two independent strided loads: x[i][0] and x[i][1]. > On targets with appropriate support, we therefore use two interleaved > loads rath

Re: [Patch, Fortran] PR 48588 - (4.6/4.7 regression) Resolve whole TU before generating code

2011-04-19 Thread Mikael Morin
On Tuesday 19 April 2011 12:36:11 Tobias Burnus wrote: > Build and regtested on x86-64-linux. > OK for the trunk - and after some grace period - for the 4.6 branch? Yes. Do you think we could have a case where we have to delay module namespace resolving as well (which we can't as we have to genera

Re: [google] Install cpu_defines.h (issue4440044)

2011-04-19 Thread Benjamin Kosnik
> This patch adds cpu_defines.h to the set of files to be installed. > Doug, could you describe why we need to do this? Will you be > submitting this patch for trunk? It's already in trunk, see 2011-03-15 Doug Kwan PR libstdc++/48123 * include/Makefile.am (install-freestandi

Re: [google] Install cpu_defines.h (issue4440044)

2011-04-19 Thread Diego Novillo
On Tue, Apr 19, 2011 at 12:04, Benjamin Kosnik wrote: > >> This patch adds cpu_defines.h to the set of files to be installed. >> Doug, could you describe why we need to do this?  Will you be >> submitting this patch for trunk? > > It's already in trunk, see D'oh. Thanks. Clearly, I was no autop

Re: [PATCH] Disallow i?86/x86_64 movstrict for subregs of non-MODE_INT regs (PR target/48678)

2011-04-19 Thread Uros Bizjak
On Tue, Apr 19, 2011 at 4:59 PM, Jakub Jelinek wrote: > Since MEM_REF has been added, we can unlike in 4.5 and earlier, arbitrary > VCEs on the LHS.  Reload isn't able to reload > (strict_low_part (subreg:HI (reg:V2DI ...))) > on the LHS, while it probably should be taught to do that, such > movs

Re: [Patch, Fortran] PR 48588 - (4.6/4.7 regression) Resolve whole TU before generating code

2011-04-19 Thread Tobias Burnus
On 04/19/2011 05:24 PM, Mikael Morin wrote: On Tuesday 19 April 2011 12:36:11 Tobias Burnus wrote: Build and regtested on x86-64-linux. OK for the trunk - and after some grace period - for the 4.6 branch? Yes. Do you think we could have a case where we have to delay module namespace resolving a

[gomp3.1] Allow pointers and cray pointers in firstprivate/lastprivate, handle not allocated allocatable in firstprivate

2011-04-19 Thread Jakub Jelinek
Hi! This patch includes assorted OpenMP 3.1 changes for Fortran. Haven't changed COPYIN with not allocated allocatables yet, waiting for explanation on OpenMP forum there. 2011-04-19 Jakub Jelinek PR fortran/46752 * trans-openmp.c (gfc_omp_clause_copy_ctor): Handle non

Re: Improve stack layout heuristic.

2011-04-19 Thread Easwaran Raman
On Tue, Apr 19, 2011 at 5:08 AM, Michael Matz wrote: > Hi, > > On Mon, 18 Apr 2011, Easwaran Raman wrote: > >> > > @@ -596,7 +581,7 @@ >> > >    if (vb->conflicts) >> > >      { >> > >        EXECUTE_IF_SET_IN_BITMAP (vb->conflicts, 0, u, bi) >> > > -     add_stack_var_conflict (a, stack_vars[u].r

Re: FDO usability patch -- correct insane profile data

2011-04-19 Thread Xinliang David Li
I reverted the original patch and added the assertion instead. Thanks, David On Sun, Apr 17, 2011 at 2:31 PM, Jan Hubicka wrote: >> Adding assertion sounds good to me -- the only problem is that problem >> like this hard to be triggered during testing, thus making assertion >> less useful as it

Re: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-19 Thread Georg-Johann Lay
Anatoly Sokolov schrieb: > Hi. > > >> + >> +/* Implement `ASM_OUTPUT_ALIGNED_DECL_LOCAL' */ >> +/* Track need of __do_clear_bss */ > > Put dot and two spaces after the end of a sentence. The same for other > commens in this patch. > >> + >> +void >> +avr_asm_output_aligned_decl_local (FILE * st

Re: [build, doc] Remove --enable-threads=solaris support

2011-04-19 Thread Rainer Orth
Hi Ralf, > Can't gcc/gthr-tpf.h go, too? What about gcc/gthr-nks.h? they are both used: config.gcc (s390x-ibm-tpf*) has thread_file='tpf', and i[3456x]86-*-netware* uses thread_file='nks'. I checked for references to the existing gthr-*.h files for the cleanup patch. Thanks. Rainer --

Re: [google] Install cpu_defines.h (issue4440044)

2011-04-19 Thread 關振德
This is used for a freestanding C++ library (i.e., we build libsupc++.a only). This is in trunk but for some reason it is not in the 4.6 release. -Doug On Sat, Apr 16, 2011 at 1:27 PM, Diego Novillo wrote: > I am committing this patch from Doug Kwan on google/main. > > This patch adds cpu_defin

Re: [testsuite]: Skip some tests for avr

2011-04-19 Thread Georg-Johann Lay
Hans-Peter Nilsson schrieb: > On Tue, 19 Apr 2011, Georg-Johann Lay wrote: >> This patchlet skips some tests for avr because int is just 16 bits there. > >> 2011-04-19 Georg-Johann Lay >> >> * gcc.c-torture/compile/pr43191.c: Skip avr due to 16-bit int. >> * gcc.dg/torture/pr43165.c:

Re: [google] Install cpu_defines.h (issue4440044)

2011-04-19 Thread Paolo Carlini
On 04/19/2011 07:26 PM, Doug Kwan (關振德) wrote: This is used for a freestanding C++ library (i.e., we build libsupc++.a only). This is in trunk but for some reason it is not in the 4.6 release. Why do you think so? For sure upon approval you committed it to the branch too, on March, 15th. Paol

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-04-19 Thread Rainer Orth
Hi Ralf, >> I haven't found if there are provisions for in-tree gold, though, and >> still cannot test that. > > I'm not quite sure I understand this statement. I built a combined tree > with gold enabled a while ago (must've been several months now). > I might be misunderstanding this. I suppos

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-04-19 Thread Rainer Orth
Paolo Bonzini writes: > On 04/04/2011 06:15 PM, Rainer Orth wrote: >> I haven't found if there are provisions for in-tree gold, though, and >> still cannot test that. > > In-tree gold definitely works (or should). My problem is simply that gold doesn't work on Solaris at all, either in-tree or e

Re: [Patch, fortran] Use xcalloc instead of gfc_getmem

2011-04-19 Thread Janne Blomqvist
On Tue, Apr 19, 2011 at 10:46, Jakub Jelinek wrote: > On Tue, Apr 19, 2011 at 10:41:33AM +0300, Janne Blomqvist wrote: >> On Mon, Apr 18, 2011 at 23:50, Steve Kargl >> wrote: >> > On Mon, Apr 18, 2011 at 11:41:33PM +0300, Janne Blomqvist wrote: >> >> Hi, >> >> >> >> the attached patch replaces gf

Re: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-19 Thread Anatoly Sokolov
Hi. This patch now uses the same procedure like elfos.h ... +#define ASM_OUTPUT_ALIGNED_DECL_COMMON(STREAM, DECL, NAME, SIZE, ALIGN) \ + avr_asm_output_aligned_common (STREAM, NAME, SIZE, ALIGN, false) .. +#define ASM_OUTPUT_ALIGNED_DECL_LOCAL(STREAM, DECL, NAME, SIZE, ALIGN) \ + avr_as

Re: [Patch, fortran] Use xcalloc instead of gfc_getmem

2011-04-19 Thread Jakub Jelinek
On Tue, Apr 19, 2011 at 08:46:17PM +0300, Janne Blomqvist wrote: > Oh, those macros are nice. I updated the patch to use them instead, > except for one case where the usage didn't fit the XCNEW(VEC) API and > I used xcalloc directly instead. Here's what I committed: For that remaining case there

Re: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-19 Thread Georg-Johann Lay
Anatoly Sokolov schrieb: > > Hi. > >> >> This patch now uses the same procedure like elfos.h >> > ... >> +#define ASM_OUTPUT_ALIGNED_DECL_COMMON(STREAM, DECL, NAME, SIZE, >> ALIGN) \ >> + avr_asm_output_aligned_common (STREAM, NAME, SIZE, ALIGN, false) > .. >> +#define ASM_OUTPUT_ALIGNED_DECL_LO

Re: [build] Support multilib testing in libgo

2011-04-19 Thread Rainer Orth
Hi Ralf, > * Rainer Orth wrote on Mon, Apr 04, 2011 at 08:19:19PM CEST: >> To avoid this mess, I'm instead setting LD_LIBRARY_PATH in CHECK. While >> this isn't exactly portable (some platforms, especially Darwin and >> HP-UX, use different variables), it's at least more widespread than -R. > > T

Re: [google] Install cpu_defines.h (issue4440044)

2011-04-19 Thread 關振德
My bad. I looked at the gcc-4.6.0 tarball and it is indeed there. -Doug On Tue, Apr 19, 2011 at 10:36 AM, Paolo Carlini wrote: > On 04/19/2011 07:26 PM, Doug Kwan (關振德) wrote: >> >> This is used for a freestanding C++ library (i.e., we build >> libsupc++.a only).  This is in trunk but for some

Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)

2011-04-19 Thread Rainer Orth
Rainer Orth writes: > Mike Stump writes: > >> On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote: >>> * lto.c (promote_var): Only set VISIBILITY_HIDDEN if >>> HAVE_GAS_HIDDEN. >> >> Oh, at a minimum, if TARGET_ASM_ASSEMBLE_VISIBILITY is set, doing this stuff >> I think is useful? > > No, thi

[Patch, fortran] Committed trivial FIXME patch

2011-04-19 Thread Janne Blomqvist
Now that Jim Meyering has remove the macro that prevented directly calling free(), and replaced gfc_free() with free(), we can fix this. Committed as obvious. Index: frontend-passes.c === --- frontend-passes.c (revision 172727) +++

Re: [Patch, fortran] Use xcalloc instead of gfc_getmem

2011-04-19 Thread Janne Blomqvist
On Tue, Apr 19, 2011 at 20:53, Jakub Jelinek wrote: > On Tue, Apr 19, 2011 at 08:46:17PM +0300, Janne Blomqvist wrote: >> Oh, those macros are nice. I updated the patch to use them instead, >> except for one case where the usage didn't fit the XCNEW(VEC) API and >> I used xcalloc directly instead.

Go patch committed: Use backend interface for blocks

2011-04-19 Thread Ian Lance Taylor
This patch to the Go frontend uses the backend interface for blocks. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2011-04-19 Ian Lance Taylor * go-gcc.cc (class Bblock): Define. (Gcc_backend::if_statement): Change then_block and el

[patch, fortran] PR 48405 - Front end expressions in DO loops

2011-04-19 Thread Thomas Koenig
Hello world, this patch fixes the enhancement PR, plus probably a few regressions. The basic problem was that the code walker got confused when *c, the pointer to the current gfc_code statement, was changed by inserting additional code. Currently regression-testing. OK for trunk if the tests

[RFA] [PowerPC]

2011-04-19 Thread edmar
This patch fixes some test cases for PowerPC. The tests pr39902-2.c, dfp-dd.c, and dfp-td.c reports as errors when gcc is configured without dfp support. This patch will make the tests to be reported as unsupported. The test and-1.c has wrong logic. In the formula: y & ~(y & -y) The part (y & -

Re: Inliner heuristics facelift

2011-04-19 Thread H.J. Lu
On Tue, Apr 19, 2011 at 11:30 AM, Xinliang David Li wrote: > Is change tested this with SPEC?  5 or 6 SPEC2k programs ICE with the > following error when built with FDO. > > internal compiler error: in inline_small_functions, at ipa-inline.c:1361 > Please submit a full bug report, > with prep

Re: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-19 Thread Anatoly Sokolov
Please use ASM_OUTPUT_ALIGNED_DECL_COMMON and ASM_OUTPUT_ALIGNED_DECL_LOCAL macros here. Confused. These macros are used. Johann Sorry... Im look on function name not on macro definition. I agree with the patch. Please wait day or two if Denis would not object, commit patch. Anatoly.

[google]Pass --save-temps to the assembler (issue4436049)

2011-04-19 Thread Easwaran Raman
This makes the gcc driver pass the --save-temps option to the assembler or assembler wrapper so that post-assembly tools like MAO can be integrated. Bootstraps on x86_64. Ok for google/main? 2011-04-19 Easwaran Raman * gcc/gcc.c (static const char *asm_options): Pass --save-t

Re: [google]Pass --save-temps to the assembler (issue4436049)

2011-04-19 Thread Diego Novillo
On Tue, Apr 19, 2011 at 15:02, Easwaran Raman wrote: > This makes the gcc driver pass the --save-temps option to the assembler or > assembler wrapper so that post-assembly tools like MAO can be integrated. > Bootstraps on x86_64. Ok for google/main? > > 2011-04-19  Easwaran Raman   > >        *

Re: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-19 Thread Denis Chertykov
2011/4/19 Anatoly Sokolov : > > >>> >>> Please use >>> ASM_OUTPUT_ALIGNED_DECL_COMMON and ASM_OUTPUT_ALIGNED_DECL_LOCAL macros >>> here. >> >> Confused. These macros are used. >> >> Johann >> > > Sorry... Im look on function name not on macro definition. > > I agree with the patch. Please wait day

Re: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-19 Thread Richard Henderson
On 04/18/2011 10:20 AM, Georg-Johann Lay wrote: > +avr_asm_named_section (const char *name, unsigned int flags, tree decl) > +{ > + if (!avr_need_copy_data_p) > +avr_need_copy_data_p = ((0 == strncmp (name, ".data", 5) > + || 0 == strncmp (name, ".rodata", 7) > +

Re: [google]Pass --save-temps to the assembler (issue4436049)

2011-04-19 Thread Easwaran Raman
On Tue, Apr 19, 2011 at 12:19 PM, Diego Novillo wrote: > On Tue, Apr 19, 2011 at 15:02, Easwaran Raman wrote: >> This makes the gcc driver pass the --save-temps option to the assembler or >> assembler wrapper so that post-assembly tools like MAO can be integrated. >> Bootstraps on x86_64. Ok fo

RE: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-19 Thread Weddington, Eric
> -Original Message- > From: Richard Henderson [mailto:r...@redhat.com] > Sent: Tuesday, April 19, 2011 1:31 PM > To: Georg-Johann Lay > Cc: gcc-patches@gcc.gnu.org; Weddington, Eric; Denis Chertykov; Anatoly > Sokolov > Subject: Re: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only

Re: FDO usability patch -- cfg and lineno checksum

2011-04-19 Thread Xinliang David Li
The attached is the revised patch with a warning suggested for cases when CFG matches, but source locations change. Ok for trunk? thanks, David On Sun, Apr 17, 2011 at 8:36 AM, Jan Hubicka wrote: >> Hi,  in current FDO implementation, the source file version used in >> profile-generate needs t

better wpa [1/n]: merge types during read-in

2011-04-19 Thread Michael Matz
Hi, I have a backlog of random improvements to the WPA phase of LTO compilations, all with the common goal of reducing peak memory usage. I was basically dumping all trees that the WPA phase read in, and then tried to think about which trees can be merged with already existing ones very early

FDO usability: pid handling

2011-04-19 Thread Xinliang David Li
Hi, Insane value profile data may contain indirect call targets with wrong (corrupted) pids. r172276 solves the problem when the pid refers to a bogus target that is still 'alive'. This patch addresses the issue when the bogus target is already eliminated or pid is too large. OK after testing? (S

Re: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-19 Thread Georg-Johann Lay
Weddington, Eric schrieb: -Original Message- From: Richard Henderson [mailto:r...@redhat.com] Sent: Tuesday, April 19, 2011 1:31 PM To: Georg-Johann Lay Cc: gcc-patches@gcc.gnu.org; Weddington, Eric; Denis Chertykov; Anatoly Sokolov Subject: Re: [Patch,AVR]: PR18145: do_copy_data & do_c

[m32c] Various patches to fix build errors.

2011-04-19 Thread DJ Delorie
The stage 1 work had broken m32c-elf. This at least fixes it so the build works, along with a few performance tweaks I had sitting around in my build. Applied. 2011-04-19 DJ Delorie * config/m32c/m32c.c (m32c_emit_epilogue): Don't try to push registers if we already know the

Re: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-19 Thread Georg-Johann Lay
Georg-Johann Lay schrieb: When I wrote this patch I looked at the default linker script to see what goes into .data resp .bss; the hard-coded section maned reflect .names that. For the linkonce stuff I found no explanation (grepping the we

Re: better wpa [1/n]: merge types during read-in

2011-04-19 Thread Eric Botcazou
> What do people think? (regstrapped with and without LTO bootstrap, the > latter with all languages, the former without Ada, on x86_64-linux). It would be nice to LTO bootstrap it with Ada as well because this involves different kinds of type merging. You just need the one-liner at: http://gc

  1   2   >