Re: [Patch] PR c++/26256

2011-03-04 Thread Fabien Chêne
Hi, Sorry for the looong delay, 2010/12/22 Jason Merrill : > On 12/20/2010 07:02 AM, Fabien Chêne wrote: >> >> +           { >> +             tree using_decl = USING_DECL_DECLS (field); >> +             if ((TREE_CODE (using_decl) == FIELD_DECL >> +                  || TREE_CODE (using_decl) == T

Re: [Patch, AVR]: PR42240 - Fix epilogue of naked functions

2011-03-04 Thread Georg-Johann Lay
Weddington, Eric schrieb: > >> -Original Message- From: Georg-Johann Lay >> [mailto:a...@gjlay.de] Sent: Thursday, March 03, 2011 11:01 AM To: >> Denis Chertykov Cc: gcc-patches@gcc.gnu.org; Anatoly Sokolov; >> Weddington, Eric Subject: Re: [Patch, AVR]: PR42240 - Fix >> epilogue of naked

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-04 Thread Tristan Gingold
On Mar 3, 2011, at 10:59 PM, Michael Snyder wrote: > Jakub Jelinek wrote: >> On Thu, Mar 03, 2011 at 01:20:28PM -0800, Michael Snyder wrote: >>> 2011-03-03 Michael Snyder >>> >>> * libiberty/cplus-dem.c (ada_demangle): Stop memory leak. >>> Also fix a one line indent problem. >> No li

Re: build_function_call and TREE_ADDRESSABLE

2011-03-04 Thread Richard Guenther
On Fri, Mar 4, 2011 at 5:58 AM, Alan Modra wrote: > Warn off anyone trying to do as I did, and the bit about inlines is > no longer relevant.  OK to apply? > >        * tree.h (TREE_ADDRESSABLE): Note that direct calls set the >        flag on FUNCTION_DECLs. > > Index: gcc/tree.h > ==

Re: build_function_call and TREE_ADDRESSABLE

2011-03-04 Thread Richard Guenther
On Fri, Mar 4, 2011 at 12:29 AM, Alan Modra wrote: > On Thu, Mar 03, 2011 at 04:43:15PM +0100, Richard Guenther wrote: >> On Thu, Mar 3, 2011 at 4:42 PM, Richard Guenther >> wrote: >> > On Thu, Mar 3, 2011 at 3:33 PM, Alan Modra wrote: >> >> TREE_ADDRESSABLE comment says "In a FUNCTION_DECL, non

[PATCH][ARM] Fix RVCT interoperation issue

2011-03-04 Thread Andrew Stubbs
The attached patch, submitted on behalf of Dan Jacobowitz, fixes an unwind bug when using RealView and libgcc. It's an old patch that has been in CodeSourcery and Linaro toolchains for sometime, but somehow escaped being posted here. OK? (For stage 1?) Andrew 2008-09-08 Daniel Jacobowitz

Re: [ping] Re: [patch, powerpc] #undef LINK_EH_SPEC before defining it

2011-03-04 Thread Alan Modra
On Fri, Mar 04, 2011 at 08:38:18AM +0100, Jakub Jelinek wrote: > We see it because we add --no-add-needed to linux LINK_EH_SPECs. OK. Adding the #undef is then required.. > Including freebsd-spec.h in a Linux configuration is certainly very > questionable and undefining LINK_EH_SPEC and other ma

Re: [ping] Re: [patch, powerpc] #undef LINK_EH_SPEC before defining it

2011-03-04 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 10:13:02PM +1030, Alan Modra wrote: > > Including freebsd-spec.h in a Linux configuration is certainly very > > questionable and undefining LINK_EH_SPEC and other macros before defining > > them would be certainly cleaner if the freebsd-spec.h include can't be just > > kille

[PATCH] recog.c: Fix RTX unsharing in change groups

2011-03-04 Thread Andreas Krebbel
Hi, we currently miss to do RTX unsharing in some cases when mixing validate_change requests with and without rtx unsharing in the same change group. Debugging a setjmp testcase on s390 I've seen the following behaviour: In an insn like A = B + C B is replaced with D in fold_rtx. Unsharing is re

Re: [doc, PATCH] Remove redundant word "See" before @xref

2011-03-04 Thread Gerald Pfeifer
On Thu, 3 Mar 2011, Mingjie Xing wrote: > 2011-03-03 Mingjie Xing > > * doc/cfg.texi: Remove "See" before @ref. > * doc/invoke.texi: Likewise. This is fine, thank you. If you want to apply this to the GCC 4.5 branch as well, that's fine, too. Gerald

Re: [4.7] Avoid global state in m32r_handle_option

2011-03-04 Thread Nick Clifton
Hi Joseph, Tested building cc1 and xgcc for cross to m32r-elf. Will commit to trunk for 4.7 in the absence of target maintainer objections. No objections - please commit. Cheers Nick

Re: [4.7] Avoid global state in iq2000_handle_option

2011-03-04 Thread Nick Clifton
Hi Joseph, Tested building cc1 and xgcc for cross to iq2000-elf. Will commit to trunk for 4.7 in the absence of target maintainer objections. No objections - please commit. Cheers Nick

Re: [PATCH, ARM] VSHL, VSHR, VLSHR immediate values support

2011-03-04 Thread Dmitry Plotnikov
On 03/02/2011 05:27 PM, Dmitry Plotnikov wrote: On 02/28/2011 02:49 AM, Ramana Radhakrishnan wrote: Hi Dmitry, Sorry about the delayed review of this patch. Can you please correct the formatting according to a few comments inline below ? Can you add some tests to check for the genera

Fix PowerPC64 non-delegitimized UNSPEC

2011-03-04 Thread Alan Modra
gcc.c-torture/execute/20040709-1.c has been failing for a while when regression testing cmodel medium powerpc64 gcc. Details of the failure in the PR. This cures the problem by teaching rs6000_delegitimize_address a few more tricks. Bootstrap and regression test in progress. OK to apply assumin

[1/2] Reducing the overhead of dwarf2 location trracking

2011-03-04 Thread Richard Sandiford
A typo in dwarf2out.c:compare_loc_operands means that we fail to detect equivalent addresses in location lists. On this ARM testcase: https://bugs.launchpad.net/gcc-linaro/+bug/714921/+attachment/1837418/+files/gcc-oom.i the patch below reduces the number of lines of assembly from 39,230,55

Re: [Patch, libfortran] PR 47802 Update documentation for CTIME and FDATE

2011-03-04 Thread Tobias Burnus
On 03/01/2011 10:26 PM, Janne Blomqvist wrote: Ok for trunk? @code{CTIME} converts a system time value, such as returned by -@code{TIME8}, to a string of the form @samp{Sat Aug 19 18:13:14 1995}. +@code{TIME8}, to a localized string. Unless the application has called +@code{setlocale}, the out

[2/2] Reducing the overhead of dwarf2 location tracking

2011-03-04 Thread Richard Sandiford
Suppose we have a function F that is inlined several times. Suppose too that F has a local variable X, and that no "real" (as opposed to debug) references to X remain after pre-inlining optimisations. In this case, we will add X to BLOCK_NONLOCALIZED_VARS rather than duplicate it each time F is i

Re: ivopts improvement

2011-03-04 Thread Tom de Vries
On 03/04/2011 08:37 AM, Paolo Bonzini wrote: > On 03/03/2011 03:28 PM, Tom de Vries wrote: >> reg-tested on x86_64. Better? > > Yes, very much so Great. Thanks for the review. > (talking about patch 6.5; the other one is an > optimization but not essential based on the new comments). > > Just

Re: ivopts improvement

2011-03-04 Thread Paolo Bonzini
On 03/04/2011 02:57 PM, Tom de Vries wrote: The MAX_EXPR however expands into control flow, and is not hoisted out of the outer loop, while the rest of the bound calculation is. That looks like a pass-ordering problem too (both on the tree level, for ivopts versus invariant motion, and on the

Re: [1/2] Reducing the overhead of dwarf2 location trracking

2011-03-04 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 01:53:30PM +, Richard Sandiford wrote: > A typo in dwarf2out.c:compare_loc_operands means that we fail to > detect equivalent addresses in location lists. On this ARM testcase: > > > https://bugs.launchpad.net/gcc-linaro/+bug/714921/+attachment/1837418/+files/gcc-

Re: [1/2] Reducing the overhead of dwarf2 location trracking

2011-03-04 Thread Richard Sandiford
Jakub Jelinek writes: > On Fri, Mar 04, 2011 at 01:53:30PM +, Richard Sandiford wrote: >> A typo in dwarf2out.c:compare_loc_operands means that we fail to >> detect equivalent addresses in location lists. On this ARM testcase: >> >> >> https://bugs.launchpad.net/gcc-linaro/+bug/714921/+

Re: [2/2] Reducing the overhead of dwarf2 location tracking

2011-03-04 Thread Richard Guenther
On Fri, Mar 4, 2011 at 2:56 PM, Richard Sandiford wrote: > Suppose we have a function F that is inlined several times.  Suppose too > that F has a local variable X, and that no "real" (as opposed to debug) > references to X remain after pre-inlining optimisations.  In this case, > we will add X to

Re: [2/2] Reducing the overhead of dwarf2 location tracking

2011-03-04 Thread Richard Sandiford
Richard Guenther writes: > On Fri, Mar 4, 2011 at 2:56 PM, Richard Sandiford > wrote: >> Suppose we have a function F that is inlined several times.  Suppose too >> that F has a local variable X, and that no "real" (as opposed to debug) >> references to X remain after pre-inlining optimisations.

Re: [2/2] Reducing the overhead of dwarf2 location tracking

2011-03-04 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 03:30:34PM +0100, Richard Guenther wrote: > On Fri, Mar 4, 2011 at 2:56 PM, Richard Sandiford > > Jakub confirms that this indeed the intended behaviour, and I haven't > > seen any problem with the output. > > Hm, but isn't it incorrect debug info? I would have expected th

Re: [2/2] Reducing the overhead of dwarf2 location tracking

2011-03-04 Thread Richard Guenther
On Fri, Mar 4, 2011 at 3:49 PM, Jakub Jelinek wrote: > On Fri, Mar 04, 2011 at 03:30:34PM +0100, Richard Guenther wrote: >> On Fri, Mar 4, 2011 at 2:56 PM, Richard Sandiford >> > Jakub confirms that this indeed the intended behaviour, and I haven't >> > seen any problem with the output. >> >> Hm,

[PATCH] fix broken -finstrument-functions implementation

2011-03-04 Thread Nathan Froyd
Paul Wörgerer noticed that -finstrument-functions does do what it says on the tin; it's been broken for the last three months due to a silly thinko while gimplifying. Expanding __builtin_return_address doesn't complain, as builtins.c thinks appropriate warnings would have been issued earlier, and

Re: [PATCH] fix broken -finstrument-functions implementation

2011-03-04 Thread Nathan Froyd
On Fri, Mar 04, 2011 at 10:00:15AM -0500, Nathan Froyd wrote: > Paul Wörgerer noticed that -finstrument-functions does do what it says > on the tin That's Paul *Wögerer*, fixed in the ChangeLog entries as well; sorry about that! -Nathan

Re: [2/2] Reducing the overhead of dwarf2 location tracking

2011-03-04 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 04:00:06PM +0100, Richard Guenther wrote: > But then location lists for those variables depend on the function context > and cannot be shared for different callers. Am I missing something? Sure, they can't be shared between different functions. If Richard's patch does tha

Re: [2/2] Reducing the overhead of dwarf2 location tracking

2011-03-04 Thread Richard Guenther
On Fri, Mar 4, 2011 at 4:10 PM, Jakub Jelinek wrote: > On Fri, Mar 04, 2011 at 04:00:06PM +0100, Richard Guenther wrote: >> But then location lists for those variables depend on the function context >> and cannot be shared for different callers.  Am I missing something? > > Sure, they can't be sha

Re: [2/2] Reducing the overhead of dwarf2 location tracking

2011-03-04 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 01:56:55PM +, Richard Sandiford wrote: > * dwarf2out.c (dw_loc_list_node): Add resolved_addr and replaced. > (cached_dw_loc_list_def): New structure. > (cached_dw_loc_list): New typedef. > (cached_dw_loc_list_table): New variable. > (cached_

Re: [4.7] Avoid global state in microblaze_handle_option

2011-03-04 Thread Michael Eager
Joseph S. Myers wrote: This patch, for 4.7 and relative to a tree with applied, stops the Microblaze handle_option hook from using global state. Everything the hook does - warnings and setting a variable also set by another option - can be

Re: ObjC/ObjC++: Fix property encoding on Apple

2011-03-04 Thread Nicola Pero
With your patch and Dominique's change both the objc and obj-c++ testsuites pass without regressions at -m32/-m64. Updating the objc/c++ testcase is obvious if everyone is on the same page. :-) Yes. Thanks a lot to Jack and Dominique for the helpful review/ testing. :-) I committed

Re: ObjC/ObjC++: Fix property encoding on Apple

2011-03-04 Thread Nicola Pero
With your patch and Dominique's change both the objc and obj-c++ testsuites pass without regressions at -m32/-m64. Updating the objc/c++ testcase is obvious if everyone is on the same page. :-) Yes. Thanks a lot to Jack and Dominique for the helpful review/ testing. :-) I committed

Re: [2/2] Reducing the overhead of dwarf2 location tracking

2011-03-04 Thread Richard Sandiford
Jakub Jelinek writes: > On Fri, Mar 04, 2011 at 04:00:06PM +0100, Richard Guenther wrote: >> But then location lists for those variables depend on the function context >> and cannot be shared for different callers. Am I missing something? > > Sure, they can't be shared between different functions

Re: [ping] Re: [patch, powerpc] #undef LINK_EH_SPEC before defining it

2011-03-04 Thread Joseph S. Myers
On Fri, 4 Mar 2011, Alan Modra wrote: > On Fri, Mar 04, 2011 at 08:38:18AM +0100, Jakub Jelinek wrote: > > We see it because we add --no-add-needed to linux LINK_EH_SPECs. > > OK. Adding the #undef is then required.. > > > Including freebsd-spec.h in a Linux configuration is certainly very > >

C++ PATCH for c++/47971 (ICE with pseudo-dtor call in template)

2011-03-04 Thread Jason Merrill
Another case of wrongly treating a type as an expression. I've also changed tsubst_copy to only abort when this happens in checking mode; simply returning the argument worked OK in previous releases. Tested x86_64-pc-linux-gnu, applied to trunk. commit 45546accfd674ac13c8a469c616f1abcfb96743a

C++ PATCH for c++/46220 (overly strict covariant return checking)

2011-03-04 Thread Jason Merrill
When the pointer target type differs in a virtual override, the standard requires the type in the derived class method to be complete. But that shouldn't be necessary if the types only differ in cv-quals; this seems like a wording bug, and EDG seems to agree. Tested x86_64-pc-linux-gnu, appli

Re: ObjC/ObjC++: Fix property encoding on Apple

2011-03-04 Thread Dominique Dhumieres
Nicola, obj-c++.dg/property/property-encoding-1.mm fails to compile with: /opt/gcc/work/gcc/testsuite/obj-c++.dg/property/property-encoding-1.mm: In function 'char* concat(char*, char*, char*)':^M /opt/gcc/work/gcc/testsuite/obj-c++.dg/property/property-encoding-1.mm:95:40: error: invalid conve

Re: [4.7, RFC, Fortran] Coarray: Moving towards real parallelization

2011-03-04 Thread Ralf Wildenhues
* Tobias Burnus wrote on Thu, Mar 03, 2011 at 12:04:12AM CET: > Ralf Wildenhues wrote: > >The library will depend on the MPI installation, obviously. > >You can make a new target directory and overwrite CC with MPICC > >for that directory. For choosing the latter, the AX_MPI macro from > >the Auto

Re: Fix PowerPC64 non-delegitimized UNSPEC

2011-03-04 Thread David Edelsohn
On Fri, Mar 4, 2011 at 8:45 AM, Alan Modra wrote: > gcc.c-torture/execute/20040709-1.c has been failing for a while when > regression testing cmodel medium powerpc64 gcc.  Details of the > failure in the PR.  This cures the problem by teaching > rs6000_delegitimize_address a few more tricks.  Boot

Re: ivopts improvement

2011-03-04 Thread Tom de Vries
Hi Zdenek, On 03/04/2011 02:57 PM, Tom de Vries wrote: > On 03/04/2011 08:37 AM, Paolo Bonzini wrote: >> On 03/03/2011 03:28 PM, Tom de Vries wrote: >>> reg-tested on x86_64. Better? >> >> Yes, very much so > > Great. Thanks for the review. > >> (talking about patch 6.5; the other one is an >>

Re: [Patch, libfortran] PR 47802 Update documentation for CTIME and FDATE

2011-03-04 Thread Janne Blomqvist
On Fri, Mar 4, 2011 at 15:56, Tobias Burnus wrote: > On 03/01/2011 10:26 PM, Janne Blomqvist wrote: >> >> Ok for trunk? > >  @code{CTIME} converts a system time value, such as returned by > -@code{TIME8}, to a string of the form @samp{Sat Aug 19 18:13:14 1995}. > +@code{TIME8}, to a localized stri

Re: [4.7, RFC, Fortran] Coarray: Moving towards real parallelization

2011-03-04 Thread Tobias Burnus
On 03/04/2011 05:57 PM, Ralf Wildenhues wrote: MPI_Init (argc, argv); If you're relying on MPI2 anyway, I suggest you try to not limit your users to not use MPI themselves. So please use MPI_Initialized, and don't finalize if the library isn't responsible. Well, the current implementation r

[Patch, libfortran, committed] PR 47802 Hack around POSIX draft localtime_r

2011-03-04 Thread Janne Blomqvist
This should fix the problem reported on HP-UX 10.2. Committed as obvious: Index: intrinsics/ctime.c === --- intrinsics/ctime.c (revision 170679) +++ intrinsics/ctime.c (working copy) @@ -39,9 +39,13 @@ static size_t strctime (char

[PATCH] PR 47862: Fix caller-save vector spill on PowerPC

2011-03-04 Thread Pat Haugen
Fix subject PR by defining HARD_REGNO_CALLER_SAVE_MODE to return V2DFmode for vectors in FP regs. Bootstrap/regtest on powerpc with no new failures. Ok for trunk and 4.5 (after successful 4.5 bootstrap/regtest)? -Pat 2011-03-04 Pat Haugen * config/rs6000/rs6000.h (HARD_REGNO_CALL

Re: [Patch, libfortran, committed] PR 47802 Hack around POSIX draft localtime_r

2011-03-04 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 07:54:29PM +0200, Janne Blomqvist wrote: > This should fix the problem reported on HP-UX 10.2. Committed as obvious: Well, it is not so obvious, you shouldn't be ignoring the return value from strftime, because if it fails, ltm will contain raondom undefined values. If ther

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-04 Thread Michael Snyder
Tristan Gingold wrote: On Mar 3, 2011, at 10:59 PM, Michael Snyder wrote: Jakub Jelinek wrote: On Thu, Mar 03, 2011 at 01:20:28PM -0800, Michael Snyder wrote: 2011-03-03 Michael Snyder * libiberty/cplus-dem.c (ada_demangle): Stop memory leak. Also fix a one line indent pro

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-04 Thread Tom Tromey
> "Michael" == Michael Snyder writes: Michael> Are you sure? There is a path to "goto unknown" from before the Michael> call to the alloc function. It might actually be null. Some Michael> versions of 'free' don't like that. This isn't an issue with free any more. Jim Meyering did some r

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-04 Thread Michael Snyder
Tom Tromey wrote: "Michael" == Michael Snyder writes: Michael> Are you sure? There is a path to "goto unknown" from before the Michael> call to the alloc function. It might actually be null. Some Michael> versions of 'free' don't like that. This isn't an issue with free any more. Jim Meye

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-04 Thread Tom Tromey
Michael> How come 'xfree' in gdb/utils.c still checks for null? I don't know, but I assume just because nobody has bothered to remove the check. I think we also still have code doing `if (x) xfree (x);', which is kind of doubly wrong :) Tom

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-04 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/04/11 11:36, Tom Tromey wrote: > Michael> How come 'xfree' in gdb/utils.c still checks for null? > > I don't know, but I assume just because nobody has bothered to remove > the check. I think we also still have code doing `if (x) xfree (x);', >

Re: [Patch, libfortran, committed] PR 47802 Hack around POSIX draft localtime_r

2011-03-04 Thread Janne Blomqvist
On Fri, Mar 4, 2011 at 20:06, Jakub Jelinek wrote: > On Fri, Mar 04, 2011 at 07:54:29PM +0200, Janne Blomqvist wrote: >> This should fix the problem reported on HP-UX 10.2. Committed as obvious: > > Well, it is not so obvious, you shouldn't be ignoring the return value from > strftime, because if

Re: ObjC/ObjC++: Fix property encoding on Apple

2011-03-04 Thread Nicola Pero
On 4 Mar 2011, at 16:41, Dominique Dhumieres wrote: Nicola, obj-c++.dg/property/property-encoding-1.mm fails to compile with: [...] You need to use the right C++ incantations, [...] Apologies. I now did the obvious changes that should make it work in both the ObjC and ObjC++ testsuite

Re: ObjC/ObjC++: Fix property encoding on Apple

2011-03-04 Thread Dominique Dhumieres
> Please let me know if it still doesn't work! I have regtested obj(c|-c++) on x86_64-apple-darwin10 without any failure. Thanks for the work. Dominique

[Committed] S/390: Fix problems with literal pools refs

2011-03-04 Thread Andreas Krebbel
Hi, the attached patch fixes a problem with literal pool relative references. Only if these themself reference literal pool slots using these values as displacement in addresses is valid. CSE sometimes tries to pull such values out of the literal pool. This patch rejects non-literal pool refere

[PATCH] Avoid IPA-CP versioning if type mismatch prevents it (PR tree-optimization/47967)

2011-03-04 Thread Jakub Jelinek
Hi! If conversion between parameter type and passed argument is not useless, is not fold convertible and has different size, then even VCE is not appropriate, but for something so undefined we shouldn't be IMHO trying to optimize anything. Bootstrapped/regtested on x86_64-linux and i686-linux, ok

[PATCH] Teach var-tracking about some targets setmem/movmem patterns (PR debug/47991)

2011-03-04 Thread Jakub Jelinek
Hi! s390 uses (set (mem:BLK ...) (reg:DI ...)) pattern for setmem, but even i?86 uses (set (mem:BLK ...) (const_int ...)). Telling var-tracking in that case that (mem:BLK) has the (reg:DI) resp. (const_int) value is wrong and leads to mode mismatches. So, the following patch fixes it by returning

[v3] --enable-extern-template

2011-03-04 Thread Benjamin Kosnik
C++0x linkage audit for "extern template" usage. There is no behavior change here, just an additional group in the src Makefile. The previous macro, _GLIBCXX_EXTERN_TEMPLATE is used as before. This patch allows building libstdc++.so/libstdc++.a without extern template and the instantation files

[4.7][google] Use sysroot from --with-build-sysroot during 'make check' (issue4248059)

2011-03-04 Thread Diego Novillo
When running tests in a toolchain configure --with-build-sysroot, we need to execute the testsuite pointing every compiler invocation to the build sysroot (which in our case is different than the sysroot that the compiler is configured with). This patch adds a new global variable TEST_SYSROOT th

Re: [4.7][google] Use sysroot from --with-build-sysroot during 'make check' (issue4248059)

2011-03-04 Thread Diego Novillo
On Fri, Mar 4, 2011 at 13:48, Diego Novillo wrote: > > When running tests in a toolchain configure --with-build-sysroot, we > need to execute the testsuite pointing every compiler invocation to > the build sysroot (which in our case is different than the sysroot > that the compiler is configured w

Re: [PATCH] Avoid IPA-CP versioning if type mismatch prevents it (PR tree-optimization/47967)

2011-03-04 Thread Richard Guenther
On Fri, Mar 4, 2011 at 9:48 PM, Jakub Jelinek wrote: > Hi! > > If conversion between parameter type and passed argument is not useless, > is not fold convertible and has different size, then even VCE is not > appropriate, but for something so undefined we shouldn't be IMHO > trying to optimize any

Re: [4.7][google] Use sysroot from --with-build-sysroot during 'make check' (issue4248059)

2011-03-04 Thread Ralf Wildenhues
Hello Diego, * Diego Novillo wrote on Fri, Mar 04, 2011 at 10:48:36PM CET: > ChangeLog.google-integration > > * Makefile.in (GCC_FOR_TARGET): Remove use of > $(SYSROOT_CFLAGS_FOR_TARGET). > (site.exp): Add definition of TEST_SYSROOT. > --- a/gcc/Makefile.in > +++ b/gcc/Makefile

Re: ivopts improvement

2011-03-04 Thread Zdenek Dvorak
Hi, >/* Whether the loop body includes any function calls. */ >bool body_includes_call; > + > + /* Whether the loop body includes any function calls that possibly have > side > + effects. */ > + bool body_includes_side_effect_call; > }; > > /* An assignment of iv candidates to

[PATCH] Fix gcc.dg/torture/pr47968.c testcase on i?86

2011-03-04 Thread Jakub Jelinek
Hi! This testcase fails on i686-linux, because of: gcc.dg/torture/pr47968.c:6:7: note: The ABI for passing parameters with 16-byte alignment has changed in GCC 4.6 gcc.dg/torture/pr47968.c:6:7: warning: SSE vector argument without SSE enabled changes the ABI [enabled by default] This patch fixe

Re: [4.7][google] Use sysroot from --with-build-sysroot during 'make check' (issue4248059)

2011-03-04 Thread Diego Novillo
On Fri, Mar 4, 2011 at 14:01, Ralf Wildenhues wrote: > No comment on the rest, but shouldn't toplevel Makefile.tpl and > configure machinery not also be updated to reflect this > (e.g., so you can run 'make check-gcc' from the toplevel)? Yeah, that's why I mentioned that the 4.7 patch would be s

Re: [ping] Re: [patch, powerpc] #undef LINK_EH_SPEC before defining it

2011-03-04 Thread Alan Modra
On Fri, Mar 04, 2011 at 03:50:48PM +, Joseph S. Myers wrote: > I'd certainly like to see the -mcall-* code that pretends to support > linking for one target using another target's compiler removed. That way > non-FreeBSD targets wouldn't need freebsd-spec.h, rs6000/sysv4.h wouldn't > need l

Re: [PATCH] Fix gcc.dg/torture/pr47968.c testcase on i?86

2011-03-04 Thread Richard Guenther
On Sat, Mar 5, 2011 at 12:10 AM, Jakub Jelinek wrote: > Hi! > > This testcase fails on i686-linux, because of: > gcc.dg/torture/pr47968.c:6:7: note: The ABI for passing parameters with > 16-byte alignment has changed in GCC 4.6 > gcc.dg/torture/pr47968.c:6:7: warning: SSE vector argument without

[x32] PATCH: Use long long to check rt_sigreturn syscall

2011-03-04 Thread H.J. Lu
Hi, I checked this patch into x32 branch. H.J. --- commit f8dd1a34cd51d52589cac5833dbf60e99e258504 Author: H.J. Lu Date: Fri Mar 4 15:22:45 2011 -0800 Use long long to check rt_sigreturn syscall. diff --git a/gcc/ChangeLog.x32 b/gcc/ChangeLog.x32 index a3b7364..1bee1d9 100644 --- a/gcc/

Re: [PATCH] Fix gcc.dg/torture/pr47968.c testcase on i?86

2011-03-04 Thread Jakub Jelinek
On Sat, Mar 05, 2011 at 12:47:18AM +0100, Richard Guenther wrote: > On Sat, Mar 5, 2011 at 12:10 AM, Jakub Jelinek wrote: > > This testcase fails on i686-linux, because of: > > gcc.dg/torture/pr47968.c:6:7: note: The ABI for passing parameters with > > 16-byte alignment has changed in GCC 4.6 > >

Re: [4.7][google] Use sysroot from --with-build-sysroot during 'make check' (issue4248059)

2011-03-04 Thread Mike Stump
On Mar 4, 2011, at 1:48 PM, Diego Novillo wrote: > When running tests in a toolchain configure --with-build-sysroot, we > need to execute the testsuite pointing every compiler invocation to > the build sysroot (which in our case is different than the sysroot > that the compiler is configured with)

[pph] Add preprocessor validation

2011-03-04 Thread Lawrence Crowl
Add preprocessor symbol verification to PPH. Write the used symbol table instead of a dummy PPH file. Reuse PTH code for verifying these symbols are correct. Modify verification to allow a preprocessor symbol to match the PPH file's after value as well as its before value. Stop stori

Re: [pph] Add preprocessor validation

2011-03-04 Thread Diego Novillo
On 03/04/2011 05:46 PM, Lawrence Crowl wrote: Add preprocessor symbol verification to PPH. Write the used symbol table instead of a dummy PPH file. Reuse PTH code for verifying these symbols are correct. Modify verification to allow a preprocessor symbol to match the PPH file's af

Re: configure oddity

2011-03-04 Thread Ralf Wildenhues
[ http://gcc.gnu.org/ml/gcc-patches/2011-02/msg01716.html ] * Ralf Wildenhues wrote on Mon, Feb 28, 2011 at 07:38:50AM CET: > This patch doesn't change at all the semantics of whether you need to > run autoconf or not. Only when you run it, no matter whether triggered > by make or run manually, i