Re: update_vtable_references segfault

2015-12-16 Thread Jan Hubicka
> On 12/12/15 09:44, Nathan Sidwell wrote: > >On 12/11/15 13:15, Jan Hubicka wrote: > >>>Jan, > > > >>>b) augment can_replace_by_local_alias_in_vtable to check whether > >>>aliases can be created? > >> > >>I think this is best: can_replace_by_local_alias_in_vtable exists to > >>prevent the > >>bod

Re: update_vtable_references segfault

2015-12-16 Thread Nathan Sidwell
On 12/12/15 09:44, Nathan Sidwell wrote: On 12/11/15 13:15, Jan Hubicka wrote: Jan, b) augment can_replace_by_local_alias_in_vtable to check whether aliases can be created? I think this is best: can_replace_by_local_alias_in_vtable exists to prevent the body walk in cases we are not going t

Re: update_vtable_references segfault

2015-12-12 Thread Nathan Sidwell
On 12/11/15 13:15, Jan Hubicka wrote: Jan, b) augment can_replace_by_local_alias_in_vtable to check whether aliases can be created? I think this is best: can_replace_by_local_alias_in_vtable exists to prevent the body walk in cases we are not going to create the alias. This is because in LT

Re: update_vtable_references segfault

2015-12-11 Thread Jan Hubicka
> Jan, > it looks like your recent changes to > function_and_variable_visibility and friends causes regressions in > targets that do not support aliases (PTX for example). > > specifically, we get a segfault in update_vtable_references > (ipa-visibility.c) at > *tp = symtab_node::get (*tp)

update_vtable_references segfault

2015-12-11 Thread Nathan Sidwell
Jan, it looks like your recent changes to function_and_variable_visibility and friends causes regressions in targets that do not support aliases (PTX for example). specifically, we get a segfault in update_vtable_references (ipa-visibility.c) at *tp = symtab_node::get (*tp)->noninterp