Re: std::regex: inserting std::wregex to std::vector loses some std::wregex values

2014-10-02 Thread Jonathan Wakely
On 01/10/14 23:44 -0700, Tim Shen wrote: This just copies but we could still make it slightly more efficient by moving _M_original_str (then resetting __rhs to an empty state). basic_regex(basic_regex&& __rhs) : _M_flags(__rhs._M_flags), _M_original_str(std::move(_M_original_str))

Re: std::regex: inserting std::wregex to std::vector loses some std::wregex values

2014-10-01 Thread Tim Shen
On Tue, Sep 30, 2014 at 5:15 AM, Jonathan Wakely wrote: > Please put the PR number in the ChangeLog, so it updates Bugzilla > automatically. Good catch ;) > You've spelled it "ompatibility" everywhere. I think we only need the > note once, maybe on the move constructor or rvalue basic_regex::ass

Re: std::regex: inserting std::wregex to std::vector loses some std::wregex values

2014-09-25 Thread Tim Shen
On Wed, Sep 24, 2014 at 6:48 AM, Jonathan Wakely wrote: > OK for trunk - thanks. Submitted -- Regards, Tim Shen

Re: std::regex: inserting std::wregex to std::vector loses some std::wregex values

2014-09-24 Thread Jonathan Wakely
On 23/09/14 23:11 -0700, Tim Shen wrote: So I'll change the patch to move _M_traits to _NFA, and add a new basic_regex::_M_loc member. Here it is :). Bootstrapped and tested with debug flag. OK for trunk - thanks.

Re: std::regex: inserting std::wregex to std::vector loses some std::wregex values

2014-09-23 Thread Tim Shen
On Tue, Sep 16, 2014 at 5:28 PM, Tim Shen wrote: > So I'll change the patch to move _M_traits to _NFA, and add a new > basic_regex::_M_loc member. Here it is :). Bootstrapped and tested with debug flag. > Should the abi compatible fix be another patch for branch 4.9? In > which the move ctor is