Re: [EXTERNAL] Re: rs6000: Fix typos in float128 ISA3.1 support

2021-06-28 Thread Segher Boessenkool
On Mon, Jun 28, 2021 at 04:15:15PM +0800, Kewen.Lin wrote: > on 2021/6/25 上午3:36, Segher Boessenkool wrote: > > mode(__TI__) is just the more portable way of writing mode(TI), the > > latter will not work if something #define's TI (you cannot do that with > > __TI__, you are not allowed to by the C

Re: [EXTERNAL] Re: rs6000: Fix typos in float128 ISA3.1 support

2021-06-28 Thread Kewen.Lin via Gcc-patches
on 2021/6/25 上午3:36, Segher Boessenkool wrote: > On Thu, Jun 24, 2021 at 05:32:20PM +0800, Kewen.Lin wrote: >> on 2021/6/24 上午12:58, Segher Boessenkool wrote: >>> On Wed, Jun 23, 2021 at 12:17:07PM +0800, Kewen.Lin wrote: >> +#ifdef FLOAT128_HW_INSNS_ISA3_1 >> TFtype __floattikf (TItype_pp

Re: [EXTERNAL] Re: rs6000: Fix typos in float128 ISA3.1 support

2021-06-24 Thread Segher Boessenkool
On Thu, Jun 24, 2021 at 05:32:20PM +0800, Kewen.Lin wrote: > on 2021/6/24 上午12:58, Segher Boessenkool wrote: > > On Wed, Jun 23, 2021 at 12:17:07PM +0800, Kewen.Lin wrote: > +#ifdef FLOAT128_HW_INSNS_ISA3_1 > TFtype __floattikf (TItype_ppc) > __attribute__ ((__ifunc__ ("__floatti

Re: [EXTERNAL] Re: rs6000: Fix typos in float128 ISA3.1 support

2021-06-24 Thread Kewen.Lin via Gcc-patches
on 2021/6/24 上午12:58, Segher Boessenkool wrote: > On Wed, Jun 23, 2021 at 12:17:07PM +0800, Kewen.Lin wrote: +#ifdef FLOAT128_HW_INSNS_ISA3_1 TFtype __floattikf (TItype_ppc) __attribute__ ((__ifunc__ ("__floattikf_resolve"))); >>> >>> I wonder if we now need TItype_ppc at all any

Re: [EXTERNAL] Re: rs6000: Fix typos in float128 ISA3.1 support

2021-06-23 Thread Segher Boessenkool
On Wed, Jun 23, 2021 at 12:17:07PM +0800, Kewen.Lin wrote: > >> +#ifdef FLOAT128_HW_INSNS_ISA3_1 > >> TFtype __floattikf (TItype_ppc) > >>__attribute__ ((__ifunc__ ("__floattikf_resolve"))); > > > > I wonder if we now need TItype_ppc at all anymore, btw? > > Sorry that I don't quite follow t

Re: [EXTERNAL] Re: rs6000: Fix typos in float128 ISA3.1 support

2021-06-22 Thread Kewen.Lin via Gcc-patches
Hi Segher, Thanks for the prompt review! on 2021/6/23 上午2:56, Segher Boessenkool wrote: > Hi! > > On Mon, Jun 21, 2021 at 05:27:06PM +0800, Kewen.Lin wrote: >> Recently if we build gcc on Power with the assembler which doesn't >> have Power10 support, the build will fail when building libgcc wit

Re: rs6000: Fix typos in float128 ISA3.1 support

2021-06-22 Thread Segher Boessenkool
Hi! On Mon, Jun 21, 2021 at 05:27:06PM +0800, Kewen.Lin wrote: > Recently if we build gcc on Power with the assembler which doesn't > have Power10 support, the build will fail when building libgcc with > one error message like: > > Error: invalid switch -mpower10 > Error: unrecognized option -mpo

rs6000: Fix typos in float128 ISA3.1 support

2021-06-21 Thread Kewen.Lin via Gcc-patches
Hi, Recently if we build gcc on Power with the assembler which doesn't have Power10 support, the build will fail when building libgcc with one error message like: Error: invalid switch -mpower10 Error: unrecognized option -mpower10 make[2]: *** [...gcc/gcc-base/libgcc/shared-object.mk:14: float12