[PATCHv2] i386: Quote user-defined symbols in assembly in Intel syntax

2025-02-21 Thread LIU Hao
From f6c09e9397d5fe9c0dd1f7a02c90536732aed3df Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Sat, 22 Feb 2025 13:11:51 +0800 Subject: [PATCH] i386: Quote user-defined symbols in assembly in Intel syntax With `-masm=intel`, GCC generates registers without % prefixes. If a user-declared symbol happens to match a register, it will confus

[PATCH] i386: Quote user-defined symbols in assembly in Intel syntax

2025-02-20 Thread LIU Hao
From: LIU Hao Date: Thu, 20 Feb 2025 18:12:14 +0800 Subject: [PATCH] i386: Quote user-defined symbols in assembly in Intel syntax With `-masm=intel`, GCC generates registers without % prefixes. If a user-declared symbol happens to match a register, it will confuse the assembler. User-defined sym

[pushed: r15-6284] sarif-replay: quote source from artifact contents [PR117943]

2024-12-16 Thread David Malcolm
ext_jstr + = get_optional_property (*content_obj, +prop_text)) + file.set_buffered_content (text_jstr->get_string (), + text_jstr->get_length ()); +} +} + /* Process a tool object (SARIF v2.1.0

[pushed] doc: Quote singular '=' signs

2024-05-26 Thread Gerald Pfeifer
Based on a conversation with Joseph years ago. gcc: * doc/extend.texi (Attribute Syntax): Use @samp{=} instead of @code{=}. (Extended Asm): Ditto. --- gcc/doc/extend.texi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/doc/extend.texi b/gcc/doc/extend

quote

2024-05-10 Thread Jessie
We are the industrial hose supplier in China. Do you need that kind hose? More information and catalog can be send if you need. Waiting for your news. Best regards Jessie

[COMMITTED] Fix the build: error message `quote`

2024-04-30 Thread Andrew Pinski
The problem here is the quote mark is for English's possessiveness rather than a quote but the error message format detection is too simple so it warns which causes -Werror to fail. Committed as obvious after a quick build. gcc/ChangeLog: * tree-cfg.cc (verify_gimple_assign): R

[COMMITTED] bpf: quote section names whenever necessary in assembly output

2023-12-01 Thread Jose E. Marchesi
ct pt_regs *ctx) { uretprobe_byname_res = 6; return 0; } The above requires to quote the section name in the output assembly file, since otherwise the // in the name would be interpreted by the assembler lexer as the beginning of a line comment. This patch makes the BPF backe

[committed] contrib: Quote variable in test expression [PR111360]

2023-09-12 Thread Jonathan Wakely via Gcc-patches
Committed as obvious. -- >8 -- Without the quotes some shells will always return true and some will print an error. It should be quoted so that a null variable works as intended. contrib/ChangeLog: PR other/111360 * gcc_update: Quote variable. --- contrib/gcc_update | 2 +-

[committed] Use single quote rather than backquote in RISC-V diagnostic

2023-07-24 Thread Jeff Law via Gcc-patches
Similar to the other patch this morning, this fixes a warning that was causing the RISC-V bootstrap to fail. In this case the diagnostic used a backquote. This changes it to a simple single quote which the diagnostic framework won't complain about. Committed to the trunk. Jeff c

Re: [PATCH] lto: Always quote path to touch

2022-10-24 Thread Torbjorn SVENSSON via Gcc-patches
rans0.o" "T:\ccGEvdDp.ltrans0.o.tem" > /dev/null 2>&1 && mv "T:\ccGEvdDp.ltrans0.o.tem" "T:\ccGEvdDp.ltrans0.o" gcc/ChangeLog: OK. Thanks, Richard. * lto-wrapper.cc: Quote paths in makefile. Co-Authored-By: Yvan ROUX Signed-off-by: Torbj?rn

Re: [PATCH] lto: Always quote path to touch

2022-10-24 Thread Richard Biener via Gcc-patches
gt; > @-touch -r "T:\ccGEvdDp.ltrans0.o" "T:\ccGEvdDp.ltrans0.o.tem" > /dev/null > 2>&1 && mv "T:\ccGEvdDp.ltrans0.o.tem" "T:\ccGEvdDp.ltrans0.o" > > gcc/ChangeLog: OK. Thanks, Richard. > * lto-wrapper.cc: Quote p

[PATCH] lto: Always quote path to touch

2022-10-21 Thread Torbjörn SVENSSON via Gcc-patches
mv T:\ccGEvdDp.ltrans0.o.tem T:\ccGEvdDp.ltrans0.o .PHONY: all all: \ T:\ccGEvdDp.ltrans0.ltrans.o With the patch, the touch line would be replace with: @-touch -r "T:\ccGEvdDp.ltrans0.o" "T:\ccGEvdDp.ltrans0.o.tem" > /dev/null 2>&1 && mv "T:\ccGE

Re: [PATCH] libgcc: Quote variable in Makefile.in

2022-10-12 Thread Jeff Law via Gcc-patches
(or has been removed by 'make clean') then the command to print the multilib dir fails, and so the MULTIOSDIR variable is empty. That then causes: /bin/sh: line 0: test: !=: unary operator expected We can avoid it by quoting the variable. libgcc/ChangeLog: * Makefile.in: Quote variable. OK jeff

[PATCH] libgcc: Quote variable in Makefile.in

2022-10-12 Thread Jonathan Wakely via Gcc-patches
d to print the multilib dir fails, and so the MULTIOSDIR variable is empty. That then causes: /bin/sh: line 0: test: !=: unary operator expected We can avoid it by quoting the variable. libgcc/ChangeLog: * Makefile.in: Quote variable. --- libgcc/Makefile.in | 2 +- 1 file changed, 1 i

Re: [PATCH v2] c++: Don't quote nothrow in diagnostic

2022-09-27 Thread Jason Merrill via Gcc-patches
org/pipermail/gcc-patches/2022-September/602057.html> Jason noticed that we quote "nothrow" in diagnostics even though it's not a keyword in C++. Just removing the quotes didn't work because then -Wformat-diag complains, so this patch replaces it with "no-throw".

Re: [PATCH v2] c++: Don't quote nothrow in diagnostic

2022-09-27 Thread Marek Polacek via Gcc-patches
022 at 8:41 PM Marek Polacek via Gcc-patches > > > > wrote: > > > > > > > > > > In > > > > > <https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602057.html> > > > > > Jason noticed that we quote "

Re: [PATCH v2] c++: Don't quote nothrow in diagnostic

2022-09-27 Thread Richard Biener via Gcc-patches
; > > > > In > > > > <https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602057.html> > > > > Jason noticed that we quote "nothrow" in diagnostics even though it's > > > > not a keyword in C++. Just removin

[PATCH v2] c++: Don't quote nothrow in diagnostic

2022-09-26 Thread Marek Polacek via Gcc-patches
57.html> > > > Jason noticed that we quote "nothrow" in diagnostics even though it's > > > not a keyword in C++. Just removing the quotes didn't work because > > > then -Wformat-diag complains, so this patch replaces it with "no-throw".

Re: [PATCH] c++: Don't quote nothrow in diagnostic

2022-09-26 Thread Jason Merrill via Gcc-patches
On 9/26/22 03:50, Richard Biener wrote: On Fri, Sep 23, 2022 at 8:41 PM Marek Polacek via Gcc-patches wrote: In <https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602057.html> Jason noticed that we quote "nothrow" in diagnostics even though it's not a keyword in C+

Re: [PATCH] c++: Don't quote nothrow in diagnostic

2022-09-26 Thread Richard Biener via Gcc-patches
On Fri, Sep 23, 2022 at 8:41 PM Marek Polacek via Gcc-patches wrote: > > In <https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602057.html> > Jason noticed that we quote "nothrow" in diagnostics even though it's > not a keyword in C++. Just removing the

[PATCH] c++: Don't quote nothrow in diagnostic

2022-09-23 Thread Marek Polacek via Gcc-patches
In <https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602057.html> Jason noticed that we quote "nothrow" in diagnostics even though it's not a keyword in C++. Just removing the quotes didn't work because then -Wformat-diag complains, so this patch replaces it with

Go patch committed: Don't quote ampersand in gccgo.texi

2021-05-27 Thread Ian Lance Taylor via Gcc-patches
This patch removes HTML quoting from the Texinfo file gccgo.html. Committed to mainline. Ian diff --git a/gcc/go/gccgo.texi b/gcc/go/gccgo.texi index ce6b518bb7b..fa0e4882403 100644 --- a/gcc/go/gccgo.texi +++ b/gcc/go/gccgo.texi @@ -495,7 +495,7 @@ like (after importing the @code{os} package):

Re: Go testsuite patch committed: Don't quote quoted parentheses

2020-12-09 Thread Ian Lance Taylor via Gcc-patches
On Wed, Dec 9, 2020 at 2:39 AM Andreas Schwab wrote: > > This breaks make -C gcc check-go RUNTESTFLAGS="go-test.exp=chan.go": > > ERROR: tcl error sourcing > /opt/gcc/gcc-20201209/gcc/testsuite/go.test/go-test.exp. > ERROR: couldn't compile regular expression pattern: parentheses () not > balanc

Re: Go testsuite patch committed: Don't quote quoted parentheses

2020-12-09 Thread Andreas Schwab
This breaks make -C gcc check-go RUNTESTFLAGS="go-test.exp=chan.go": ERROR: tcl error sourcing /opt/gcc/gcc-20201209/gcc/testsuite/go.test/go-test.exp. ERROR: couldn't compile regular expression pattern: parentheses () not balanced while executing "regsub -all "(^|\n)(\[^\n\]+$line\[^\n\]*($p

Go testsuite patch committed: Don't quote quoted parentheses

2020-12-07 Thread Ian Lance Taylor via Gcc-patches
This patch fixes go-test.exp to not backslash quote parentheses that are already backslash quoted. This regexp quoting isn't fully general, it just has to handle the cases that arise in the testsuite. This change fixes a case in a new test, not yet committed. (It would be nice to have a ge

[doc] Update reference to elm-lang.org quote in ux.texi

2019-08-17 Thread Gerald Pfeifer
Committed. Gerald 2019-08-17 Gerald Pfeifer * doc/ux.texi (User Experience Guidelines): Update reference. Index: doc/ux.texi === --- doc/ux.texi (revision 274599) +++ doc/ux.texi (working copy) @@ -9,7 +9,7 @@ @cindex

[Ada] Missing escape of the double quote in JSON output

2019-07-09 Thread Pierre-Marie de Rodat
. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-09 Eric Botcazou gcc/ada/ * repinfo.adb (List_Entities): Disregard formals altogether. (List_Name): Properly escape the double quote in the JSON output.--- gcc/ada/repinfo.adb +++ gcc/ada/repinfo.adb @@ -525,9

[patch,avr,committed] Fix PR79883: Quote key words in diagnostics.

2017-07-12 Thread Georg-Johann Lay
warns for functions named "ISR", "SIGNAL" and "INTERRUPT". Such names indicate missing system include. Applied as obvious. Johann PR target/79883 * config/avr/avr.c (avr_set_current_function): In diagnostic messages: Quote keywords and (parts of) i

Re: [PATCH] libgcc: quote ARM macro parameters

2015-10-03 Thread Andreas Schwab
ation (though they are part of the >> Level 1 >> > interface). Quote the macro parameters, as otherwise, a complex >> parameter may >> > be ambiguously mis-expanded. >> > --- >> > libgcc/config/arm/unwind-arm.h | 4 ++-- >> > 1 file chan

Re: [PATCH] libgcc: quote ARM macro parameters

2015-10-03 Thread Andreas Schwab
Saleem Abdulrasool writes: > For ARM EHABI _Unwind_{G,S}setIP are macros rather than proper functions as > they > are extensions to the EHABI specification (though they are part of the Level 1 > interface). Quote the macro parameters, as otherwise, a complex parameter may > be

[PATCH] libgcc: quote ARM macro parameters

2015-10-03 Thread Saleem Abdulrasool
For ARM EHABI _Unwind_{G,S}setIP are macros rather than proper functions as they are extensions to the EHABI specification (though they are part of the Level 1 interface). Quote the macro parameters, as otherwise, a complex parameter may be ambiguously mis-expanded. --- libgcc/config/arm/unwind

Re: PR c++/64626 - C++14 single quote should not always be a digit separator

2015-03-16 Thread Jason Merrill
OK. Jason

Re: PR c++/64626 - C++14 single quote should not always be a digit separator

2015-03-15 Thread Ed Smith-Rowland
OK, Here is a new try at PR c++/64626 - C++14 single quote should not always be a digit separator. I decided to look for multiple terminating single quotes. The test cases have bee adjusted and debugged. Built and tested on x86_64-linux. Ed libcpp/ 2015-03-16 Edward Smith-Rowland <

Re: PR c++/64626 - C++14 single quote should not always be a digit separator

2015-03-09 Thread Jason Merrill
OK, thanks. Jason

Re: PR c++/64626 - C++14 single quote should not always be a digit separator

2015-03-09 Thread Ed Smith-Rowland
Forget this last patch. The syntax of my dg lines was wrong and I'm seeing errors I'm not sure I like. I need to look at this further. I'm sorry for the noise.

Re: PR c++/64626 - C++14 single quote should not always be a digit separator

2015-03-09 Thread Ed Smith-Rowland
On 03/08/2015 02:52 PM, Jakub Jelinek wrote: On Sun, Mar 08, 2015 at 02:33:03PM -0400, Ed Smith-Rowland wrote: I just look to see if a lexed number in libcpp ends in a '. If so, back up one character and let string processing handle it. I get one warning and one error for each instance but I'd

Re: PR c++/64626 - C++14 single quote should not always be a digit separator

2015-03-08 Thread Jakub Jelinek
On Sun, Mar 08, 2015 at 02:33:03PM -0400, Ed Smith-Rowland wrote: > I just look to see if a lexed number in libcpp ends in a '. > If so, back up one character and let string processing handle it. > > I get one warning and one error for each instance but I'd rather not error > when it should pass.

PR c++/64626 - C++14 single quote should not always be a digit separator

2015-03-08 Thread Ed Smith-Rowland
I just look to see if a lexed number in libcpp ends in a '. If so, back up one character and let string processing handle it. I get one warning and one error for each instance but I'd rather not error when it should pass. Built and tests clean on x86_64-linux. OK? libcpp/ 2015-03-09 Edwa

Re: [PATCH] Windows libibery: Don't quote args unnecessarily

2014-05-08 Thread Ian Lance Taylor
On Tue, May 6, 2014 at 11:56 PM, Ray Donnelly wrote: > We only quote arguments that contain spaces, \t or " > characters to prevent wasting 2 characters per > argument of the CreateProcess() 32,768 limit. This is OK. Thanks. Ian > libiberty

Re: [PATCH] Windows libibery: Don't quote args unnecessarily

2014-05-08 Thread Kai Tietz
Ah, that was my mail-client. Patch is ok IMO. I add Ian CC for a second look at it. Cheers, Kai

Re: [PATCH] Windows libiberty: Don't quote args unnecessarily (v2)

2014-05-08 Thread Kai Tietz
2014-05-07 8:55 GMT+02:00 Ray Donnelly : > We only quote arguments that contain spaces, \t or " > characters to prevent wasting 2 characters per > argument of the CreateProcess() 32,768 limit. > > libiberty/ > * pex-win32.c (argv_to_cmdline): Don't quote

[PATCH] Windows libibery: Don't quote args unnecessarily

2014-05-06 Thread Ray Donnelly
We only quote arguments that contain spaces, \t or " characters to prevent wasting 2 characters per argument of the CreateProcess() 32,768 limit. --- libiberty/pex-win32.c | 46 +- 1 file changed, 37 insertions(+), 9 deletions(-) diff --git a/libi

[PATCH] Windows libiberty: Don't quote args unnecessarily (v2)

2014-05-06 Thread Ray Donnelly
We only quote arguments that contain spaces, \t or " characters to prevent wasting 2 characters per argument of the CreateProcess() 32,768 limit. libiberty/ * pex-win32.c (argv_to_cmdline): Don't quote args unnecessarily Ray Donnelly (1): Windows libibery: Don&#x

Re: [PATCH 1/2] Windows libibery: Don't quote args unnecessarily

2014-04-21 Thread Joel Brobecker
> Changelog libiberty/ > * pex-win32.c (argv_to_cmdline): Don't quote > args unnecessarily Some minor comments... > > diff --git a/libiberty/pex-win32.c b/libiberty/pex-win32.c > > index eae72c5..775b53c 100644 > > --- a/libiberty/pex-win32.c

Re: [PATCH 1/2] Windows libibery: Don't quote args unnecessarily

2014-04-19 Thread Eli Zaretskii
> Date: Sat, 19 Apr 2014 16:23:33 -0400 (EDT) > From: Kai Tietz > Cc: gcc-patches@gcc.gnu.org, ktiet...@gmail.com, > "binut...@sourceware.org Development" , > gdb-patc...@sourceware.org > > > + /* We only quote arguments that contain spa

Re: [PATCH 1/2] Windows libibery: Don't quote args unnecessarily

2014-04-19 Thread Kai Tietz
Hello Ray, Patches to libiberty need to be cross-posted to binutils, gdb, and gcc ML. I did so for you now. - Original Message - > We only quote arguments that contain spaces, \n \t \v > or " characters to prevent wasting 2 characters per > argument of the CreateProcess(

[PATCH 1/2] Windows libibery: Don't quote args unnecessarily

2014-04-19 Thread Ray Donnelly
We only quote arguments that contain spaces, \n \t \v or " characters to prevent wasting 2 characters per argument of the CreateProcess() 32,768 limit. libiberty/ * pex-win32.c (argv_to_cmdline): Don't quote args unnecessarily --- libiberty/ChangeLog | 5 + lib

[ping^2][PATCH] configure.ac: Also quote '$' in tbaseargs

2012-09-07 Thread Maciej W. Rozycki
Hi, This small change: http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00044.html still awaits review. Please help. Thanks. Maciej

Go patch committed: Quote package paths with tabs

2012-06-13 Thread Ian Lance Taylor
In my patch yesterday to quote package paths in reflection strings, I managed to overlook the fact that quotes are already used for struct field tags in reflection strings. This patch changes the compiler and the reflect package to quote using tabs instead, since tabs will never appear in struct

[ping][PATCH] configure.ac: Also quote '$' in tbaseargs

2012-05-16 Thread Maciej W. Rozycki
Hi, Would anyone please have a look at: http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00044.html I know this is trivial boring stuff, but perhaps especially because of this let's get rid of it ASAP? Thanks. Maciej

[PATCH] configure.ac: Also quote '$' in tbaseargs

2012-05-01 Thread Maciej W. Rozycki
variables, $baseargs and $tbaseargs, that we handle almost identically, except some bits are omitted from $tbaseargs only, based on $skip_targ. However, at the point we decide to quote '$' in any of the options collected we only do so for $baseargs. As a result, '$' won'

[Ada] Improve flag positioning for missing quote when comma present

2011-08-05 Thread Arnaud Charlet
This patch improves the positioning for the case of a missing string quote when a comma is the likely intended end of the string, as shown by this example: 1. procedure mquote is 2. begin 3.Error_Msg_NE ("this is a string with missing quote,

Re: [Patch] fixinclude: shell-quote testing file

2011-05-16 Thread Bruce Korb
Hi Tristan, On Mon, May 16, 2011 at 6:39 AM, Tristan Gingold wrote: > Sure.  [If] The patch below is ok for 'make check', is it also ok for you ? Yes, thank you.

Re: [Patch] fixinclude: shell-quote testing file

2011-05-16 Thread Tristan Gingold
eck.tpl >> @@ -87,7 +87,7 @@ FOR fix =][= >> ELSE =] >> -cat >> [= >> - IF (exist? "files") =][= >> - files[0] =][= >> - ELSE =]testing.h[= >> - ENDIF =] <<_HACK_EOF_ > > Easier would be to just single (apostrophe) quo

Re: [Patch] fixinclude: shell-quote testing file

2011-05-16 Thread Tristan Gingold
On May 16, 2011, at 3:26 PM, Andreas Schwab wrote: > Tristan Gingold writes: > >> 2011-05-16 Tristan Gingold >> >> * check.tpl: Shell-quote testing file. >> >> diff --git a/fixincludes/check.tpl b/fixincludes/check.tpl >> index b239d8b..0f3

Re: [Patch] fixinclude: shell-quote testing file

2011-05-16 Thread Bruce Korb
;files") =][= > -      files[0] =][= > -   ELSE =]testing.h[= > -   ENDIF =] <<_HACK_EOF_ Easier would be to just single (apostrophe) quote the string: cat >> '[= (if (exist? "files") (get "files[0]") "testing.h") =]' <<_HACK_EOF_ Or, as Andreas said after I typed the above:) cat >> [= (raw-shell-str (if (exist? ...))) =] <<_HACK_EOF_

Re: [Patch] fixinclude: shell-quote testing file

2011-05-16 Thread Andreas Schwab
Tristan Gingold writes: > 2011-05-16 Tristan Gingold > > * check.tpl: Shell-quote testing file. > > diff --git a/fixincludes/check.tpl b/fixincludes/check.tpl > index b239d8b..0f3937a 100644 > --- a/fixincludes/check.tpl > +++ b/fixincludes/check.tpl >

[Patch] fixinclude: shell-quote testing file

2011-05-16 Thread Tristan Gingold
ixincludes/ Ok for trunk ? Tristan. fixincludes/ 2011-05-16 Tristan Gingold * check.tpl: Shell-quote testing file. diff --git a/fixincludes/check.tpl b/fixincludes/check.tpl index b239d8b..0f3937a 100644 --- a/fixincludes/check.tpl +++ b/fixincludes/check.tpl @@ -87,7 +87,7