Re: powerpc compare_and_swap fails

2011-11-18 Thread Richard Henderson
On 11/17/2011 03:58 PM, Alan Modra wrote: > Thanks! This, along with my mutex.h rewrite plus adding a > memory_barrier insn gets me down to just one libgomp failure. The memory_barrier thing should be fixed now as well... r~

Re: powerpc compare_and_swap fails

2011-11-17 Thread Alan Modra
On Thu, Nov 17, 2011 at 12:24:08PM -1000, Richard Henderson wrote: > On 11/17/2011 10:25 AM, Richard Henderson wrote: > > so that we don't write back into the subreg. > > Like so. Tested on ppc64-linux and committed. Thanks! This, along with my mutex.h rewrite plus adding a memory_barrier insn

Re: powerpc compare_and_swap fails

2011-11-17 Thread Richard Henderson
On 11/17/2011 10:25 AM, Richard Henderson wrote: > On 11/17/2011 12:37 AM, Alan Modra wrote: >> - oldval = convert_modes (SImode, mode, oldval, 1); >> + oldval = gen_reg_rtx (SImode); >> + convert_move (oldval, orig, 1); >>oldval = expand_simple_binop (SImode, ASHIFT, oldval,