Re: patches to detect GCC diagnostics

2019-05-17 Thread Roland Illig
Am 16.05.2019 um 22:24 schrieb Martin Sebor: > On 5/16/19 8:58 AM, Roland Illig wrote: >> -  error ("#pragma GCC target string... is badly formed"); >> +  error ("%<#pragma GCC target%> string is badly formed"); >> -  error ("#pragma GCC optimize string... is badly formed"); >> + 

Re: patches to detect GCC diagnostics

2019-05-16 Thread Martin Sebor
On 5/16/19 8:58 AM, Roland Illig wrote: Hi Martin, I'm impressed how much work you have put into the patches for detecting nonoptimal diagnostics. It takes a long time to read through the patches, but it's worth it, knowing that it took much longer for you to prepare the patch, and that I won't

Re: patches to detect GCC diagnostics

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 04:58:08PM +0200, Roland Illig wrote: > - error ("#pragma GCC target string... is badly formed"); > + error ("%<#pragma GCC target%> string is badly formed"); > - error ("#pragma GCC optimize string... is badly formed"); > + error ("%<#pragma GCC opti

patches to detect GCC diagnostics

2019-05-16 Thread Roland Illig
Hi Martin, I'm impressed how much work you have put into the patches for detecting nonoptimal diagnostics. It takes a long time to read through the patches, but it's worth it, knowing that it took much longer for you to prepare the patch, and that I won't have to submit i18n bug reports in the for