Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-30 Thread Jeff Law
On 10/30/13 16:50, Steven Bosscher wrote: On Tue, Oct 29, 2013 at 4:12 PM, Vladimir Makarov wrote: Tomorrow I'd like commit the following patch. The patch removes regmove pass. I can barely hold my tears... of joy :-) Attached patch cleans up some left-overs. Nothing to test, really, a

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-30 Thread Vladimir Makarov
On 10/30/2013, 7:40 PM, David Edelsohn wrote: Where was this patch bootstrapped? This appears to have broken bootstrap on PowerPC (Linux and AIX) /nasfarm/edelsohn/src/src/libgcc/libgcov.c: In function 'gcov_exit': /nasfarm/edelsohn/src/src/libgcc/libgcov.c:827:1: internal compiler error: in up

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-30 Thread Vladimir Makarov
On 10/30/2013, 6:50 PM, Steven Bosscher wrote: On Tue, Oct 29, 2013 at 4:12 PM, Vladimir Makarov wrote: Tomorrow I'd like commit the following patch. The patch removes regmove pass. I can barely hold my tears... of joy :-) Attached patch cleans up some left-overs. Nothing to test, reall

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-30 Thread David Edelsohn
Where was this patch bootstrapped? This appears to have broken bootstrap on PowerPC (Linux and AIX) /nasfarm/edelsohn/src/src/libgcc/libgcov.c: In function 'gcov_exit': /nasfarm/edelsohn/src/src/libgcc/libgcov.c:827:1: internal compiler error: in up date_costs_from_allocno, at ira-color.c:1334 -

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-30 Thread Marc Glisse
On Wed, 30 Oct 2013, Steven Bosscher wrote: Attached patch cleans up some left-overs. Nothing to test, really, as it's just comments and NOPs. OK for trunk? -would be better to run a full CSE/propogation pass on it through, or -re-run regmove, but that has not yet been attempted. +would be be

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-30 Thread Steven Bosscher
On Tue, Oct 29, 2013 at 4:12 PM, Vladimir Makarov wrote: > Tomorrow I'd like commit the following patch. > > The patch removes regmove pass. I can barely hold my tears... of joy :-) Attached patch cleans up some left-overs. Nothing to test, really, as it's just comments and NOPs. OK for trunk

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-29 Thread Jeff Law
On 10/29/13 10:46, Vladimir Makarov wrote: On 10/29/2013 12:26 PM, Jeff Law wrote: On 10/29/13 09:12, Vladimir Makarov wrote: I've found only one useful transformations in regmove pass: dst = srcdst = src (src dies) ... no dst or src

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-29 Thread Vladimir Makarov
On 10/29/2013 12:44 PM, Joseph S. Myers wrote: > Please change the .opt entries to > > foptimize-register-move > Common Ignore > Does nothing. Preserved for backward compatibility. > > and > > fregmove > Common Ignore > Does nothing. Preserved for backward compatibility. > > rather than removing th

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-29 Thread Vladimir Makarov
On 10/29/2013 12:43 PM, Alexander Monakov wrote: > Hello, > > A very minor nit: in common.opt, entries for the options should be changed to > > fregmove > Common Ignore > Does nothing. Preserved for backward compatibility. > > instead of removing them altogether, so the compiler does not start reje

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-29 Thread Vladimir Makarov
On 10/29/2013 12:26 PM, Jeff Law wrote: > On 10/29/13 09:12, Vladimir Makarov wrote: >>I've found only one useful transformations in regmove pass: >> >>dst = srcdst = src (src dies) >>... no dst or src modification => src changed on

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-29 Thread Joseph S. Myers
Please change the .opt entries to foptimize-register-move Common Ignore Does nothing. Preserved for backward compatibility. and fregmove Common Ignore Does nothing. Preserved for backward compatibility. rather than removing them completely. In general, when removing an option that's purely ab

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-29 Thread Alexander Monakov
Hello, A very minor nit: in common.opt, entries for the options should be changed to fregmove Common Ignore Does nothing. Preserved for backward compatibility. instead of removing them altogether, so the compiler does not start rejecting build commands with such options. There are now a few suc

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-29 Thread Jeff Law
On 10/29/13 09:12, Vladimir Makarov wrote: Tomorrow I'd like commit the following patch. The patch removes regmove pass. I'm buying next time we get together :-) You have my eternal gratitude. I've found only one useful transformations in regmove pass: dst = src