Re: open acc default data attribute

2015-11-12 Thread Nathan Sidwell
On 11/12/15 15:22, David Edelsohn wrote: Nathan, The ChangeLog was placed in the wrong files. gcc/ * gimplify.c (oacc_default_clause): New. (omp_notice_variable): Call it. Fixed. I placed the entries in the other files, but failed to cleanup the above one. natha

Re: open acc default data attribute

2015-11-12 Thread David Edelsohn
Nathan, The ChangeLog was placed in the wrong files. gcc/ * gimplify.c (oacc_default_clause): New. (omp_notice_variable): Call it. Should go in gcc/ChangeLog without "gcc/" gcc/testsuite/ * c-c++-common/goacc/data-default-1.c: New. should go in gcc/tests

Re: open acc default data attribute

2015-11-12 Thread Nathan Sidwell
On 11/12/15 03:53, Jakub Jelinek wrote: + error ("%qE not specified in enclosing OpenACC %s construct", +DECL_NAME (lang_hooks.decls.omp_report_decl (decl)), rkind); + error_at (ctx->location, "enclosing OpenACC %s construct", rkind); I'd use %qs instead of %s. thanks,

Re: open acc default data attribute

2015-11-12 Thread Jakub Jelinek
On Wed, Nov 11, 2015 at 12:19:55PM -0500, Nathan Sidwell wrote: > this patch implements default data attribute determination. The current > behaviour defaults to 'copy' and ignores 'default(none)'. The patch > corrects that. > > 1) We emit a diagnostic when 'default(none)' is in effect. The for

open acc default data attribute

2015-11-11 Thread Nathan Sidwell
Jakub, this patch implements default data attribute determination. The current behaviour defaults to 'copy' and ignores 'default(none)'. The patch corrects that. 1) We emit a diagnostic when 'default(none)' is in effect. The fortran FE emits some artificial decls that it doesn't otherwise a