Re: module_column not initialized in write_module()

2019-05-01 Thread Andrew Benson
Thanks Thomas, committed as r270777. On Wednesday, May 1, 2019 9:35:13 PM PDT Thomas Koenig wrote: > Hi Andrew, > > > Fixing this seems to be simple: > > > > --- gcc/fortran/module.c(revision 270772) > > +++ gcc/fortran/module.c(working copy) > > @@ -6052,6 +6052,9 @@ write_modul

Re: module_column not initialized in write_module()

2019-05-01 Thread Thomas Koenig
Hi Andrew, Fixing this seems to be simple: --- gcc/fortran/module.c(revision 270772) +++ gcc/fortran/module.c(working copy) @@ -6052,6 +6052,9 @@ write_module (void) { int i; + /* Initialize the column counter. */ + module_column = 1; + /* Write the operator inte

module_column not initialized in write_module()

2019-05-01 Thread Andrew Benson
The value of 'module_column' is not initialized in write_module() before a module file is written. As a result, the first line break in the module file can occur at an arbitrary column, depending on what value 'module_column' happens to have. While this doesn't affect the behavior of the module