Re: mem_attrs_htab

2011-08-22 Thread Michael Matz
Hi, On Mon, 22 Aug 2011, Richard Guenther wrote: > > Some functions are extremely large though.  Do you mean that MEM > > itself would be enlarged to have the MEM_ATTRS field so that one > > operand is the address, then expr, then HWI size, offset, etc.? > >  Because if the mem attrs aren't sh

Re: mem_attrs_htab

2011-08-22 Thread Richard Guenther
On Mon, Aug 22, 2011 at 12:07 PM, Jakub Jelinek wrote: > On Mon, Aug 22, 2011 at 11:57:18AM +0200, Richard Guenther wrote: >> And at some point the idea popped up to just dump this whole re-using >> mem-attrs.  There is at most a single function in RTL but the whole program >> is available in SSA,

Re: mem_attrs_htab

2011-08-22 Thread Jakub Jelinek
On Mon, Aug 22, 2011 at 11:57:18AM +0200, Richard Guenther wrote: > And at some point the idea popped up to just dump this whole re-using > mem-attrs. There is at most a single function in RTL but the whole program > is available in SSA, so the memory overhead must be small. Some functions are ex

Re: mem_attrs_htab

2011-08-22 Thread Richard Guenther
On Mon, Aug 22, 2011 at 10:04 AM, Jakub Jelinek wrote: > On Mon, Aug 22, 2011 at 10:58:48AM +0300, Dimitrios Apostolou wrote: >> the future. I didn't like hashing addresses either, and I was >> surprised I saw no regressions. > > Hashing on the expr address as well just results in smaller sharing

Re: mem_attrs_htab

2011-08-22 Thread Jakub Jelinek
On Mon, Aug 22, 2011 at 10:58:48AM +0300, Dimitrios Apostolou wrote: > the future. I didn't like hashing addresses either, and I was > surprised I saw no regressions. Hashing on the expr address as well just results in smaller sharing in the hash table (i.e. if the expr has different address, but

Re: mem_attrs_htab

2011-08-22 Thread Dimitrios Apostolou
Hi Jakub, I forgot to mention that all patches are against mid-July trunk, I was hoping I'd have no conflicts. Anyway thanks for letting me know, if there are conflicts with my other patches please let me know, and I'll post an updated version at a later date. All your other concerns are val

Re: mem_attrs_htab

2011-08-22 Thread Jakub Jelinek
On Mon, Aug 22, 2011 at 10:32:35AM +0300, Dimitrios Apostolou wrote: > --- gcc/emit-rtl.c2011-05-29 17:40:05 + > +++ gcc/emit-rtl.c2011-08-21 04:44:25 + > @@ -256,11 +256,10 @@ mem_attrs_htab_hash (const void *x) > { >const mem_attrs *const p = (const mem_attrs *) x; > > - r

mem_attrs_htab

2011-08-22 Thread Dimitrios Apostolou
collisions/searches ratio from 8 to 0.8 for some cases. (init_emit_once): Slightly increase the mem_attrs_htab initial size because it's frequently used and expanded many times. === modified file 'gcc/emit-rtl.c' --- gcc/emit-rtl.c 2011-05-29 17:40:05 +00