Re: [PATCH v3] Re: libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-09 Thread Giuseppe D'Angelo
x, I've also added some comments... Thanks, -- Giuseppe D'Angelo From 22dec25f64efe0f4516c0a561a9a900964d5a51f Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Wed, 2 Oct 2024 18:14:34 +0200 Subject: [PATCH] libstdc++: use is_virtual_base_of in std::weak_ptr operations Conver

Re: [PATCH v2] Re: libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-04 Thread Jonathan Wakely
On Wed, 4 Dec 2024 at 12:20, Giuseppe D'Angelo wrote: > > On 03/12/2024 18:02, Jonathan Wakely wrote: > > On Tue, 3 Dec 2024 at 16:56, Jonathan Wakely wrote: > >> > >> On Tue, 3 Dec 2024 at 16:19, Giuseppe D'Angelo > >> wrote: > >>> > >>> Hello, > >>> > >>> The attached patch changes std::weak_p

[PATCH v2] Re: libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-04 Thread Giuseppe D'Angelo
;Angelo From 196185cb2b1526719b2cc8719d252bf050eea2d9 Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Wed, 2 Oct 2024 18:14:34 +0200 Subject: [PATCH] libstdc++: use is_virtual_base_of in std::weak_ptr operations Converting a weak_ptr to a weak_ptr requires calling lock() on the source

Re: libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-03 Thread Jonathan Wakely
On Tue, 3 Dec 2024 at 16:56, Jonathan Wakely wrote: > > On Tue, 3 Dec 2024 at 16:19, Giuseppe D'Angelo > wrote: > > > > Hello, > > > > The attached patch changes std::weak_ptr "converting move > > constructor/assignment" -- that is, from a rvalue weak_ptr to a > > weak_ptr. > > > > In the general

Re: libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-03 Thread Jonathan Wakely
On Tue, 3 Dec 2024 at 16:19, Giuseppe D'Angelo wrote: > > Hello, > > The attached patch changes std::weak_ptr "converting move > constructor/assignment" -- that is, from a rvalue weak_ptr to a > weak_ptr. > > In the general case, such conversion requires lock()ing the weak_ptr > because the pointe

libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-03 Thread Giuseppe D'Angelo
s far as I know, no ABI requires dereferencing the pointer in the non-virtual inheritance case. Thanks, -- Giuseppe D'Angelo From c67349ec3ac53573a5a36edeedaea9e8f5e41c97 Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Wed, 2 Oct 2024 18:14:34 +0200 Subject: [PATCH] libstdc