Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-10 Thread Jonathan Wakely via Gcc-patches
On 10/06/20 18:40 +0200, François Dumont wrote: On 10/06/20 4:49 pm, Jonathan Wakely wrote: On 10/06/20 08:18 +0200, François Dumont via Libstdc++ wrote: On 09/06/20 10:53 pm, Jonathan Wakely wrote: This reminds me that I was going to extend the condition for using memcmp to also apply to

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-10 Thread François Dumont via Gcc-patches
On 10/06/20 4:49 pm, Jonathan Wakely wrote: On 10/06/20 08:18 +0200, François Dumont via Libstdc++ wrote: On 09/06/20 10:53 pm, Jonathan Wakely wrote: This reminds me that I was going to extend the condition for using memcmp to also apply to unsigned integers with sizeof(T) > 1 on big endian t

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-10 Thread Jonathan Wakely via Gcc-patches
On 10/06/20 08:18 +0200, François Dumont via Libstdc++ wrote: On 09/06/20 10:53 pm, Jonathan Wakely wrote: This reminds me that I was going to extend the condition for using memcmp to also apply to unsigned integers with sizeof(T) > 1 on big endian targets. This illustrates what I tried to avo

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-09 Thread François Dumont via Gcc-patches
On 09/06/20 10:53 pm, Jonathan Wakely wrote: On 09/06/20 22:42 +0200, François Dumont via Libstdc++ wrote: On 09/06/20 6:11 pm, Jonathan Wakely wrote: On 09/06/20 00:02 +0100, Jonathan Wakely wrote: On 08/06/20 22:08 +0100, Jonathan Wakely wrote: On 08/06/20 19:20 +0100, Jonathan Wakely wrot

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-09 Thread Jonathan Wakely via Gcc-patches
a9d81d7e1999ced2c1b01df70b3f6047b7ebd Author: Fran??ois Dumont Date: Tue Jun 9 00:01:51 2020 +0100 libstdc++: Extend memcmp optimization in std::lexicographical_compare Make the memcmp optimization work for std::deque iterators and safe iterators. Co-auth

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-09 Thread Jonathan Wakely via Gcc-patches
On 09/06/20 22:35 +0200, François Dumont via Libstdc++ wrote: On 09/06/20 12:24 pm, Jonathan Wakely wrote: On 08/06/20 19:20 +0100, Jonathan Wakely wrote: On 05/06/20 22:24 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the last of my algo patches this time to extend

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-09 Thread François Dumont via Gcc-patches
On 09/06/20 6:11 pm, Jonathan Wakely wrote: On 09/06/20 00:02 +0100, Jonathan Wakely wrote: On 08/06/20 22:08 +0100, Jonathan Wakely wrote: On 08/06/20 19:20 +0100, Jonathan Wakely wrote: On 05/06/20 22:24 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the last of my algo pat

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-09 Thread Jonathan Wakely via Gcc-patches
On 09/06/20 22:20 +0200, François Dumont via Libstdc++ wrote: On 08/06/20 8:20 pm, Jonathan Wakely wrote: On 05/06/20 22:24 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the last of my algo patches this time to extend the memcmp optimization to std::deque iterators a

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-09 Thread François Dumont via Gcc-patches
On 09/06/20 12:24 pm, Jonathan Wakely wrote: On 08/06/20 19:20 +0100, Jonathan Wakely wrote: On 05/06/20 22:24 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the last of my algo patches this time to extend the memcmp optimization to std::deque iterators and _GLIBCXX_DEBUG mode

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-09 Thread François Dumont via Gcc-patches
On 08/06/20 8:20 pm, Jonathan Wakely wrote: On 05/06/20 22:24 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the last of my algo patches this time to extend the memcmp optimization to std::deque iterators and _GLIBCXX_DEBUG mode.     To do so I had to return int in impleme

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-09 Thread Jonathan Wakely via Gcc-patches
ba840194a28799cb83bcd8aaecd0eec5304 Author: Fran??ois Dumont Date: Tue Jun 9 00:01:51 2020 +0100 libstdc++: Extend memcmp optimization in std::lexicographical_compare Make the memcmp optimization work for std::deque iterators and safe iterators. Co-authored

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-09 Thread Jonathan Wakely via Gcc-patches
On 09/06/20 00:02 +0100, Jonathan Wakely wrote: On 08/06/20 22:08 +0100, Jonathan Wakely wrote: On 08/06/20 19:20 +0100, Jonathan Wakely wrote: On 05/06/20 22:24 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the last of my algo patches this time to extend the memcmp optimiza

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-09 Thread Jonathan Wakely via Gcc-patches
On 08/06/20 19:20 +0100, Jonathan Wakely wrote: On 05/06/20 22:24 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the last of my algo patches this time to extend the memcmp optimization to std::deque iterators and _GLIBCXX_DEBUG mode.     To do so I had to return int in imp

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-08 Thread Jonathan Wakely via Gcc-patches
On 08/06/20 22:08 +0100, Jonathan Wakely wrote: On 08/06/20 19:20 +0100, Jonathan Wakely wrote: On 05/06/20 22:24 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the last of my algo patches this time to extend the memcmp optimization to std::deque iterators and _GLIBCXX_DEBUG

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-08 Thread Jonathan Wakely via Gcc-patches
loop bug. This seems simpler and less invasive. Please take a look. commit b7c4d633e875ccd2b3141f1b74d062fea11ab2c0 Author: Fran??ois Dumont Date: Mon Jun 8 21:58:14 2020 +0100 libstdc++: Extend memcmp optimization in std::lexicographical_compare Make the memcmp optimizati

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-08 Thread Jonathan Wakely via Gcc-patches
On 08/06/20 21:07 +0100, Jonathan Wakely wrote: On 05/06/20 22:24 +0200, François Dumont via Libstdc++ wrote: diff --git a/libstdc++-v3/include/debug/safe_iterator.tcc b/libstdc++-v3/include/debug/safe_iterator.tcc index 888ac803ae5..ca4e2d52d1d 100644 --- a/libstdc++-v3/include/debug/safe_ite

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-08 Thread Jonathan Wakely via Gcc-patches
On 05/06/20 22:24 +0200, François Dumont via Libstdc++ wrote: diff --git a/libstdc++-v3/include/debug/safe_iterator.tcc b/libstdc++-v3/include/debug/safe_iterator.tcc index 888ac803ae5..ca4e2d52d1d 100644 --- a/libstdc++-v3/include/debug/safe_iterator.tcc +++ b/libstdc++-v3/include/debug/safe_i

Re: libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-08 Thread Jonathan Wakely via Gcc-patches
On 05/06/20 22:24 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the last of my algo patches this time to extend the memcmp optimization to std::deque iterators and _GLIBCXX_DEBUG mode.     To do so I had to return int in implementation details of lexicographical_compare t

libstdc++: Extend memcmp optimization in std::lexicographical_compare

2020-06-05 Thread François Dumont via Gcc-patches
Hi     Here is the last of my algo patches this time to extend the memcmp optimization to std::deque iterators and _GLIBCXX_DEBUG mode.     To do so I had to return int in implementation details of lexicographical_compare to make sure we can treat a deque iterator range by chunk in a perform