Yes, this looks good. I've added some tests and committed to
compiler-rt. Thanks!
On Tue, Feb 12, 2013 at 5:46 PM, Jakub Jelinek wrote:
> On Tue, Feb 12, 2013 at 05:28:53PM +0400, Evgeniy Stepanov wrote:
>> Hey,
>>
>> seems like that last of the scanf changes are in.
>> We're intercepting __isoc9
On Tue, Feb 12, 2013 at 05:28:53PM +0400, Evgeniy Stepanov wrote:
> Hey,
>
> seems like that last of the scanf changes are in.
> We're intercepting __isoc99_*scanf irrespective of the glibc version,
> because (a) it does not hurt (and with the static runtime, even
> interceptor itself is thrown ou
Hey,
seems like that last of the scanf changes are in.
We're intercepting __isoc99_*scanf irrespective of the glibc version,
because (a) it does not hurt (and with the static runtime, even
interceptor itself is thrown out by the linker), and (b) user program
and tool's runtime can be built with di
On Mon, Feb 11, 2013 at 12:38:00PM +0100, Jakub Jelinek wrote:
> On Wed, Jan 23, 2013 at 04:24:01PM +0400, Evgeniy Stepanov wrote:
> > > > What if glibc adds a scanf hook (like it has already printf hooks), apps
> > > > could then register their own stuff and the above would then break. It
> > > >
On Mon, Feb 11, 2013 at 04:00:50PM +0400, Evgeniy Stepanov wrote:
> > I've tested various glibc *scanf testcases with the GCC libsanitizer
> > + enabling of # define SANITIZER_INTERCEPT_SCANF SI_NOT_WINDOWS
> > + llvm svn diff between last merge point to GCC and current llvm trunk
> > + this patch,
On Mon, Feb 11, 2013 at 3:38 PM, Jakub Jelinek wrote:
> On Wed, Jan 23, 2013 at 04:24:01PM +0400, Evgeniy Stepanov wrote:
>> > > What if glibc adds a scanf hook (like it has already printf hooks), apps
>> > > could then register their own stuff and the above would then break. It
>> > > really sho
On Wed, Jan 23, 2013 at 04:24:01PM +0400, Evgeniy Stepanov wrote:
> > > What if glibc adds a scanf hook (like it has already printf hooks), apps
> > > could then register their own stuff and the above would then break. It
> > > really should be very conservative, and should be checked e.g. with al
On Wed, Jan 23, 2013 at 04:49:04PM +0400, Evgeniy Stepanov wrote:
> On Wed, Jan 23, 2013 at 4:39 PM, Jakub Jelinek wrote:
> > On Wed, Jan 23, 2013 at 04:24:01PM +0400, Evgeniy Stepanov wrote:
> >> > So, e.g. whenever match_spec
> >> > > returns 0, it should break out of the loop, rather than cont
On Wed, Jan 23, 2013 at 4:39 PM, Jakub Jelinek wrote:
> On Wed, Jan 23, 2013 at 04:24:01PM +0400, Evgeniy Stepanov wrote:
>> > So, e.g. whenever match_spec
>> > > returns 0, it should break out of the loop, rather than continue.
>> > > And for %hh it doesn't check following letters, no match_spec
On Wed, Jan 23, 2013 at 04:24:01PM +0400, Evgeniy Stepanov wrote:
> > So, e.g. whenever match_spec
> > > returns 0, it should break out of the loop, rather than continue.
> > > And for %hh it doesn't check following letters, no match_spec at all.
>
> That's cause they don't change the write size.
On Wed, Jan 23, 2013 at 3:28 PM, Konstantin Serebryany
wrote:
>
> On Wed, Jan 23, 2013 at 3:13 PM, Jakub Jelinek wrote:
> > On Wed, Jan 23, 2013 at 02:31:57PM +0400, Konstantin Serebryany wrote:
> >> The attached patch is the libsanitizer merge from upstream r173241.
>
On Wed, Jan 23, 2013 at 3:13 PM, Jakub Jelinek wrote:
> On Wed, Jan 23, 2013 at 02:31:57PM +0400, Konstantin Serebryany wrote:
>> The attached patch is the libsanitizer merge from upstream r173241.
>>
>> Lots of changes. Among other things:
>> - slow CFI-based un
On Wed, Jan 23, 2013 at 02:31:57PM +0400, Konstantin Serebryany wrote:
> The attached patch is the libsanitizer merge from upstream r173241.
>
> Lots of changes. Among other things:
> - slow CFI-based unwinder is on by default for fatal errors
> (fast_unwind_on_fatal=0, Linux-o
Rubber stamp LGTM
On Wed, Jan 23, 2013 at 2:31 PM, Konstantin Serebryany
wrote:
> Hi,
>
> The attached patch is the libsanitizer merge from upstream r173241.
>
> Lots of changes. Among other things:
> - slow CFI-based unwinder is on by default for fatal errors
> (fast_unw
14 matches
Mail list logo
