Re: libsanitizer mege from upstream r171973

2013-01-10 Thread Jack Howarth
On Thu, Jan 10, 2013 at 11:01:30AM +0400, Konstantin Serebryany wrote: > Hi, > > The attached patch is the libsanitizer merge from upstream r171973. > > Lots of changes. Among other things: > - slow CFI-based unwinder (off by default for now) > - more interceptors in asan (read, pread, etc) >

Re: libsanitizer mege from upstream r171973

2013-01-10 Thread Konstantin Serebryany
On Thu, Jan 10, 2013 at 4:23 PM, Jakub Jelinek wrote: > On Thu, Jan 10, 2013 at 03:57:44PM +0400, Konstantin Serebryany wrote: >> > That is not sufficient. You can have PR_SET_NAME defined in the headers, >> > but still the underlying kernel doesn't need to handle it. >> > >> Like this? >> http:/

Re: libsanitizer mege from upstream r171973

2013-01-10 Thread Jakub Jelinek
On Thu, Jan 10, 2013 at 03:57:44PM +0400, Konstantin Serebryany wrote: > > That is not sufficient. You can have PR_SET_NAME defined in the headers, > > but still the underlying kernel doesn't need to handle it. > > > Like this? > http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/tests

Re: libsanitizer mege from upstream r171973

2013-01-10 Thread Jakub Jelinek
On Thu, Jan 10, 2013 at 03:27:41PM +0400, Konstantin Serebryany wrote: > > So, I'd guard the prctl call with additional > > #ifdef PR_SET_NAME > > Ok. > I'd prefer to guard the whole test with #if defined(__linux__) && > defined(PR_SET_NAME). That is not sufficient. You can have PR_SET_NAME defi

Re: libsanitizer mege from upstream r171973

2013-01-10 Thread Konstantin Serebryany
On Thu, Jan 10, 2013 at 2:59 PM, Jakub Jelinek wrote: > On Thu, Jan 10, 2013 at 11:07:26AM +0400, Konstantin Serebryany wrote: >> >> Our internal LLVM bots (Linux, Mac and Android) are also green, but >> >> since the changes are large something may potentially break on other >> >> platforms. >> >>

Re: libsanitizer mege from upstream r171973

2013-01-10 Thread Jakub Jelinek
On Thu, Jan 10, 2013 at 11:07:26AM +0400, Konstantin Serebryany wrote: > >> Our internal LLVM bots (Linux, Mac and Android) are also green, but > >> since the changes are large something may potentially break on other > >> platforms. > >> > >> Ok to commit? Ok, but it would be nice if the prctl st

Re: libsanitizer mege from upstream r171973

2013-01-09 Thread Dmitry Vyukov
On Thu, Jan 10, 2013 at 11:01 AM, Konstantin Serebryany wrote: > Hi, > > The attached patch is the libsanitizer merge from upstream r171973. > > Lots of changes. Among other things: > - slow CFI-based unwinder (off by default for now) > - more interceptors in asan (read, pread, etc) > - prec