Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-04 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/04/11 11:36, Tom Tromey wrote: > Michael> How come 'xfree' in gdb/utils.c still checks for null? > > I don't know, but I assume just because nobody has bothered to remove > the check. I think we also still have code doing `if (x) xfree (x);', >

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-04 Thread Tom Tromey
Michael> How come 'xfree' in gdb/utils.c still checks for null? I don't know, but I assume just because nobody has bothered to remove the check. I think we also still have code doing `if (x) xfree (x);', which is kind of doubly wrong :) Tom

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-04 Thread Michael Snyder
Tom Tromey wrote: "Michael" == Michael Snyder writes: Michael> Are you sure? There is a path to "goto unknown" from before the Michael> call to the alloc function. It might actually be null. Some Michael> versions of 'free' don't like that. This isn't an issue with free any more. Jim Meye

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-04 Thread Tom Tromey
> "Michael" == Michael Snyder writes: Michael> Are you sure? There is a path to "goto unknown" from before the Michael> call to the alloc function. It might actually be null. Some Michael> versions of 'free' don't like that. This isn't an issue with free any more. Jim Meyering did some r

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-04 Thread Michael Snyder
Tristan Gingold wrote: On Mar 3, 2011, at 10:59 PM, Michael Snyder wrote: Jakub Jelinek wrote: On Thu, Mar 03, 2011 at 01:20:28PM -0800, Michael Snyder wrote: 2011-03-03 Michael Snyder * libiberty/cplus-dem.c (ada_demangle): Stop memory leak. Also fix a one line indent pro

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-04 Thread Tristan Gingold
On Mar 3, 2011, at 10:59 PM, Michael Snyder wrote: > Jakub Jelinek wrote: >> On Thu, Mar 03, 2011 at 01:20:28PM -0800, Michael Snyder wrote: >>> 2011-03-03 Michael Snyder >>> >>> * libiberty/cplus-dem.c (ada_demangle): Stop memory leak. >>> Also fix a one line indent problem. >> No li

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-03 Thread Michael Snyder
Jakub Jelinek wrote: On Thu, Mar 03, 2011 at 01:20:28PM -0800, Michael Snyder wrote: 2011-03-03 Michael Snyder * libiberty/cplus-dem.c (ada_demangle): Stop memory leak. Also fix a one line indent problem. No libiberty/ in libiberty/ChangeLog. @@ -1129,10 +1129,11 @@ ada_d

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-03 Thread Jakub Jelinek
On Thu, Mar 03, 2011 at 01:20:28PM -0800, Michael Snyder wrote: > 2011-03-03 Michael Snyder > > * libiberty/cplus-dem.c (ada_demangle): Stop memory leak. > Also fix a one line indent problem. No libiberty/ in libiberty/ChangeLog. > @@ -1129,10 +1129,11 @@ ada_demangle (const char

libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-03 Thread Michael Snyder
We don't have a separate libiberty list, do we? 2011-03-03 Michael Snyder * libiberty/cplus-dem.c (ada_demangle): Stop memory leak. Also fix a one line indent problem. Index: cplus-dem.c === RCS file: /cvs/src/sr