Re: libgomp: with USM, init 'link' variables with host address

2024-09-24 Thread Tobias Burnus
emory, but I might be wrong.) - Documenting how GCC handles this in libgomp.texi BTW: See https://gcc.gnu.org/onlinedocs/libgomp/Offload-Target-Specifics.html for how USM is detected for nvptx + gcn devices. * * * For completeness, I also intent to look at Andrew's pinned memory

Re: libgomp: with USM, init 'link' variables with host address

2024-09-17 Thread Tobias Burnus
Hi Thomas, short version: I think the patch as posted is fine and no action beyond is needed for this one issue. See below for the long version. Possibly modifications (now or as follow up): - using memcpy + or let the plugin do it - not adding link variables to the splay tree with 'USM'. Th

Re: libgomp: with USM, init 'link' variables with host address

2024-09-17 Thread Thomas Schwinge
ified-shared memory. > > Tested on x86-64-gnu-linux and nvptx offloading (that supports USM). (I yet have to set up such a USM configuration...) > Remarks/comments/suggestions before I commit it? > libgomp: with USM, init 'link' variables with host address > > I

libgomp: with USM, init 'link' variables with host address

2024-09-14 Thread Tobias Burnus
. libgomp: with USM, init 'link' variables with host address If requires unified_shared_memory is set, make 'declare target link' variables to point initially to the host pointer. libgomp/ChangeLog: * target.c (gomp_load_image_to_device): For requires unified_shared_memory,