Re: libgo patch RFA: Fix printing of names in stack dumps

2012-06-07 Thread Richard Guenther
On Thu, Jun 7, 2012 at 8:35 AM, Ian Lance Taylor wrote: > Go strings are not necessarily NUL terminated.  The stack dump code was > erroneously using %s to print the contents of a Go string.  The > runtime_printf function that it uses supports %S to print a Go string. > This patch fixes the code t

libgo patch RFA: Fix printing of names in stack dumps

2012-06-06 Thread Ian Lance Taylor
Go strings are not necessarily NUL terminated. The stack dump code was erroneously using %s to print the contents of a Go string. The runtime_printf function that it uses supports %S to print a Go string. This patch fixes the code to use %S. Without this a stack dump sometimes prints random junk