Re: gimplify: Handle void BIND_EXPR as asm input [PR100501]

2024-11-30 Thread Richard Biener
> Am 29.11.2024 um 23:45 schrieb Joseph Myers : > > On Fri, 29 Nov 2024, Richard Biener wrote: > >> I think we're trying to handle errorneous cases by setting TREE_VALUE >> to error_mark_node >> before this, so how about the following instead? > > Yes, that works, and also fixes the test in

Re: gimplify: Handle void BIND_EXPR as asm input [PR100501]

2024-11-29 Thread Joseph Myers
On Fri, 29 Nov 2024, Richard Biener wrote: > I think we're trying to handle errorneous cases by setting TREE_VALUE > to error_mark_node > before this, so how about the following instead? Yes, that works, and also fixes the test in bug 100792 unlike my previous patch. Here's a full, tested patch

Re: gimplify: Handle void BIND_EXPR as asm input [PR100501]

2024-11-28 Thread Richard Biener
On Fri, Nov 29, 2024 at 3:04 AM Joseph Myers wrote: > > As reported in bug 100501 (plus duplicates), the gimplifier ICEs for C > tests involving a statement expression not returning a value as an asm > input. > > The expected diagnostic for this case (as seen for C++ input) is one > coming from th

gimplify: Handle void BIND_EXPR as asm input [PR100501]

2024-11-28 Thread Joseph Myers
As reported in bug 100501 (plus duplicates), the gimplifier ICEs for C tests involving a statement expression not returning a value as an asm input. The expected diagnostic for this case (as seen for C++ input) is one coming from the gimplifier and so it seems reasonable to fix the gimplifier to h