Re: driver: do not check input file existence here [PR 98452]

2021-01-22 Thread Nathan Sidwell
On 1/21/21 3:20 PM, Joseph Myers wrote: On Thu, 21 Jan 2021, Nathan Sidwell wrote: Do you want expandargv altered alongs the lines you mention? Or a bug filed? [in order for my patch to be acceptable] The patch is OK as-is. Filing a bug for expandargv handling of missing files might be a go

Re: driver: do not check input file existence here [PR 98452]

2021-01-21 Thread Joseph Myers
On Thu, 21 Jan 2021, Nathan Sidwell wrote: > Do you want expandargv altered alongs the lines you mention? Or a bug filed? > [in order for my patch to be acceptable] The patch is OK as-is. Filing a bug for expandargv handling of missing files might be a good idea; it seems very arbitrary that @

Re: driver: do not check input file existence here [PR 98452]

2021-01-21 Thread Nathan Sidwell
On 1/21/21 12:59 PM, Joseph Myers wrote: On Wed, 20 Jan 2021, Nathan Sidwell wrote: Unspecified non-existent response file: OLD: (1)devvm293:282>g++ -c @nothing g++: error: nothing: No such file or directory g++: fatal error: no input files compilation terminated. NEW: (1)devvm293:284>./xg+

Re: driver: do not check input file existence here [PR 98452]

2021-01-21 Thread Joseph Myers
On Wed, 20 Jan 2021, Nathan Sidwell wrote: > On 1/19/21 6:27 PM, Joseph Myers wrote: > > On Tue, 19 Jan 2021, Nathan Sidwell wrote: > > > > > Joseph, > > > I was relying on this patch on the modules branch, but didn't realize the > > > implications when merging and thought it was just a cleanup.

Re: driver: do not check input file existence here [PR 98452]

2021-01-20 Thread Nathan Sidwell
On 1/19/21 6:27 PM, Joseph Myers wrote: On Tue, 19 Jan 2021, Nathan Sidwell wrote: Joseph, I was relying on this patch on the modules branch, but didn't realize the implications when merging and thought it was just a cleanup. I'm not sure why the driver wants to check here, rather than leave i

Re: driver: do not check input file existence here [PR 98452]

2021-01-19 Thread Joseph Myers
On Tue, 19 Jan 2021, Nathan Sidwell wrote: > Joseph, > I was relying on this patch on the modules branch, but didn't realize the > implications when merging and thought it was just a cleanup. I'm not sure why > the driver wants to check here, rather than leave it to the compiler. Seems > optimiz

driver: do not check input file existence here [PR 98452]

2021-01-19 Thread Nathan Sidwell
Joseph, I was relying on this patch on the modules branch, but didn't realize the implications when merging and thought it was just a cleanup. I'm not sure why the driver wants to check here, rather than leave it to the compiler. Seems optimizing for failure? The only difference I can think