Re: default omp clause

2015-07-24 Thread Nathan Sidwell
On 07/24/15 11:22, Jakub Jelinek wrote: On Fri, Jul 24, 2015 at 11:10:59AM -0400, Nathan Sidwell wrote: +case OMP_CLAUSE_DEFAULT_NONE: + { + const char *accn; Can you rename this variable to something that makes sense? kind, or construct, or name, or directive? Hm, yeah, tha

Re: default omp clause

2015-07-24 Thread Jakub Jelinek
On Fri, Jul 24, 2015 at 11:10:59AM -0400, Nathan Sidwell wrote: > 2015-07-24 Nathan Sidwell > > * gimplify.c (omp_default_clause): New function. Reorganize flow > for clarity. Broken out of ... > (omp_notice_variable): ... here. Ok, except: > +case OMP_CLAUSE_DEFAULT_NO

default omp clause

2015-07-24 Thread Nathan Sidwell
Jakub, in working on openacc default clause handling, I found the logic in omp_notice_variable a little hard to follow, due to the size of function and depth of nesting. I broke out the existing default handling to a separate function, and made the control flow a bit clearer (IMHO). ok for