Re: cleanup of CONST_DOUBLE.

2012-08-02 Thread Kenneth Zadeck
bootstrapped and regression tested on x86-64. committed as revision 190105 2012-08-02 Kenneth Zadeck * cfgexpand.c (expand_debug_locations): Encapsulate test for CONST_DOUBLE in macro. * combine.c (try_combine, gen_lowpart_for_combine): Ditto. * cprop.c (implicit_set_cond_p):

Re: cleanup of CONST_DOUBLE.

2012-07-29 Thread Kenneth Zadeck
I will add the comment. However, my hope is that will be short lived knowledge, but i am a couple of patches away from that. kenny On 07/29/2012 05:31 PM, Steven Bosscher wrote: On Sun, Jul 29, 2012 at 6:11 PM, Kenneth Zadeck wrote: * rtl.h (CONST_DOUBLE_AS_INT_P, CONST_DOUBLE_AS_FLOAT

Re: cleanup of CONST_DOUBLE.

2012-07-29 Thread Steven Bosscher
On Sun, Jul 29, 2012 at 6:11 PM, Kenneth Zadeck wrote: > * rtl.h (CONST_DOUBLE_AS_INT_P, CONST_DOUBLE_AS_FLOAT_P): New > macros. Hello Kenny, Thanks for doing this! Can you please also update the comment before CONST_DOUBLE in rtl.def? According to rtl.def CONST_DOUBLEs are only for flo

Re: cleanup of CONST_DOUBLE.

2012-07-29 Thread Kenneth Zadeck
sorry, will fix all of this. thanks. On 07/29/2012 12:33 PM, Richard Sandiford wrote: Kenneth Zadeck writes: Given that Richard Sandiford advised on all of the non trivial changes, I am going to check this patch in in the next few days unless i hear some comments otherwise. TBH I'd only look

Re: cleanup of CONST_DOUBLE.

2012-07-29 Thread Eric Botcazou
> Given that Richard Sandiford advised on all of the non trivial changes, > I am going to check this patch in in the next few days unless i hear > some comments otherwise. This patch has been fully tested on the x86-64. Pasto in the rtl.h change. Please also avoid the long lines in there. --

Re: cleanup of CONST_DOUBLE.

2012-07-29 Thread Richard Sandiford
Kenneth Zadeck writes: > Given that Richard Sandiford advised on all of the non trivial changes, > I am going to check this patch in in the next few days unless i hear > some comments otherwise. TBH I'd only looked at the ones you flagged. This time... > diff -puNr '--exclude=.git' '--exclude

cleanup of CONST_DOUBLE.

2012-07-29 Thread Kenneth Zadeck
This patch is a minor, mostly mechanical cleanup of CONST_DOUBLE. It wraps all of the checks of CONST_DOUBLE in one of three macros: CONST_DOUBLE_AS_INT_P, CONST_DOUBLE_AS_FLOAT_P, or CONST_DOUBLE_P is it used for both. There were some non obvious changes that Richard Sandiford told me the