Re: [PATCH v2] check initializer to be zero in .bss-like sections

2016-07-01 Thread Bernd Schmidt
On 07/01/2016 03:57 PM, Jan Beulich wrote: Do I need to re-submit, or can I take the above as approved-with- that-change? Ok with that change. Bernd

Re: [PATCH v2] check initializer to be zero in .bss-like sections

2016-07-01 Thread Jan Beulich
>>> On 01.07.16 at 15:44, wrote: > On 07/01/2016 03:42 PM, Jan Beulich wrote: > On 01.07.16 at 15:36, wrote: > >>> Looks ok, except why the empty dg-options string in the testcase? >> >> Because I've seen in it that way in various other test cases (and >> yes, yet others don't have it). I ha

Re: [PATCH v2] check initializer to be zero in .bss-like sections

2016-07-01 Thread Bernd Schmidt
On 07/01/2016 03:42 PM, Jan Beulich wrote: On 01.07.16 at 15:36, wrote: Looks ok, except why the empty dg-options string in the testcase? Because I've seen in it that way in various other test cases (and yes, yet others don't have it). I had to decide for one of the variants, and if it's no

Re: [PATCH v2] check initializer to be zero in .bss-like sections

2016-07-01 Thread Jan Beulich
>>> On 01.07.16 at 15:36, wrote: > On 07/01/2016 10:21 AM, Jan Beulich wrote: >> Just like gas, which has recently learned to reject such initializers, >> gcc shouldn't accept such either. >> --- >> v2: Use dg-require-named-sections. >> >> gcc/ >> 2016-07-01 Jan Beulich >> >> * varasm.c (g

Re: [PATCH v2] check initializer to be zero in .bss-like sections

2016-07-01 Thread Bernd Schmidt
On 07/01/2016 10:21 AM, Jan Beulich wrote: Just like gas, which has recently learned to reject such initializers, gcc shouldn't accept such either. --- v2: Use dg-require-named-sections. gcc/ 2016-07-01 Jan Beulich * varasm.c (get_variable_section): Validate initializer in na

[PATCH v2] check initializer to be zero in .bss-like sections

2016-07-01 Thread Jan Beulich
Just like gas, which has recently learned to reject such initializers, gcc shouldn't accept such either. --- v2: Use dg-require-named-sections. gcc/ 2016-07-01 Jan Beulich * varasm.c (get_variable_section): Validate initializer in named .bss-like sections. gcc/testsuite/ 2016-

Re: Ping: check initializer to be zero in .bss-like sections

2016-01-14 Thread Jeff Law
On 01/12/2016 03:01 AM, Jan Beulich wrote: On 10.12.15 at 08:21, wrote: Just like gas, which has recently learned to reject such initializers, gcc shouldn't accept such either. --- The only question really is whether the new test case should be limited to certain targets - I haven't been able t

Ping: check initializer to be zero in .bss-like sections

2016-01-12 Thread Jan Beulich
>>> On 10.12.15 at 08:21, wrote: > Just like gas, which has recently learned to reject such initializers, > gcc shouldn't accept such either. > --- > The only question really is whether the new test case should be limited > to certain targets - I haven't been able to figure out possible valid > qu

check initializer to be zero in .bss-like sections

2015-12-09 Thread Jan Beulich
p;& !bss_initializer_p (decl)) + { + error_at (DECL_SOURCE_LOCATION (decl), + "only zero initializers are allowed in section %qs", + sect->named.name); + DECL_INITIAL (decl) = error_mark_node; + } + return sect; +