Re: bb-reorder maintenance [3/n]

2011-07-20 Thread Ulrich Weigand
Richard Henderson wrote: > On 07/20/2011 11:24 AM, Ulrich Weigand wrote: > >> >BB_HEAD (new_bb) = new_label; > > new_bb is now always NULL at this point, and the assignment crashes. > > > > I guess that assignment should now be just deleted as well, since > > this is done by cr

Re: bb-reorder maintenance [3/n]

2011-07-20 Thread Richard Henderson
On 07/20/2011 11:24 AM, Ulrich Weigand wrote: >> > BB_HEAD (new_bb) = new_label; > new_bb is now always NULL at this point, and the assignment crashes. > > I guess that assignment should now be just deleted as well, since > this is done by create_basic_block later? Doh. Yes, that's

Re: bb-reorder maintenance [3/n]

2011-07-20 Thread Ulrich Weigand
Richard Henderson wrote: > The create_basic_block function will do the right thing > with ordering the block label and the block note. No > need for us to work hard at that within bb-reorder. This causes: FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE (internal co

bb-reorder maintenance [3/n]

2011-07-18 Thread Richard Henderson
The create_basic_block function will do the right thing with ordering the block label and the block note. No need for us to work hard at that within bb-reorder. r~ * bb-reorder.c (fix_crossing_conditional_branches): Emit all insns before calling create_basic_block. diff --git