Re: [patch] backwards threader cleanups

2017-11-17 Thread Aldy Hernandez
On 11/15/2017 08:06 AM, Pedro Alves wrote: On 11/15/2017 07:34 AM, Aldy Hernandez wrote: On 11/14/2017 02:38 PM, David Malcolm wrote: On Tue, 2017-11-14 at 14:08 -0500, Aldy Hernandez wrote: https://gcc.gnu.org/codingconventions.html#Class_Form says that: "When defining a class, fir

Re: [patch] backwards threader cleanups

2017-11-17 Thread Jeff Law
On 11/15/2017 12:34 AM, Aldy Hernandez wrote: > > > On 11/14/2017 02:38 PM, David Malcolm wrote: >> On Tue, 2017-11-14 at 14:08 -0500, Aldy Hernandez wrote: > >>    https://gcc.gnu.org/codingconventions.html#Class_Form >> says that: >> >> "When defining a class, first [...] >> declare all public

Re: [patch] backwards threader cleanups

2017-11-15 Thread Pedro Alves
On 11/15/2017 07:34 AM, Aldy Hernandez wrote: > > > On 11/14/2017 02:38 PM, David Malcolm wrote: >> On Tue, 2017-11-14 at 14:08 -0500, Aldy Hernandez wrote: > >>https://gcc.gnu.org/codingconventions.html#Class_Form >> says that: >> >> "When defining a class, first [...] >> declare all public

Re: [patch] backwards threader cleanups

2017-11-14 Thread Aldy Hernandez
On 11/14/2017 02:38 PM, David Malcolm wrote: On Tue, 2017-11-14 at 14:08 -0500, Aldy Hernandez wrote: https://gcc.gnu.org/codingconventions.html#Class_Form says that: "When defining a class, first [...] declare all public member functions, [...] then declare all non-public member functio

Re: [patch] backwards threader cleanups

2017-11-14 Thread David Malcolm
On Tue, 2017-11-14 at 14:08 -0500, Aldy Hernandez wrote: > Howdy! > > For some upcoming work I need some pass local data that I don't want > to > be passing around as an argument. We have enough of those in the > threader as it is. So I moved the current pass local data into its > own > class

[patch] backwards threader cleanups

2017-11-14 Thread Aldy Hernandez
Howdy! For some upcoming work I need some pass local data that I don't want to be passing around as an argument. We have enough of those in the threader as it is. So I moved the current pass local data into its own class, and basically classified the entire pass, thus avoiding a lot of argu

Re: backwards threader cleanups

2017-09-11 Thread Jeff Law
On 09/02/2017 11:43 AM, Aldy Hernandez wrote: > On Fri, Sep 1, 2017 at 6:11 PM, Jeff Law wrote: >> On 09/01/2017 02:18 PM, Aldy Hernandez wrote: >>> Hi. >>> >>> Attached are misc cleanups to tree-ssa-threadbackwards.c and friends. >>> The main gist of the patch is making the path vectors live in t

Re: backwards threader cleanups

2017-09-11 Thread Aldy Hernandez
PING. An this time with an actual patch ;-). Aldy On Sat, Sep 2, 2017 at 1:43 PM, Aldy Hernandez wrote: > On Fri, Sep 1, 2017 at 6:11 PM, Jeff Law wrote: >> On 09/01/2017 02:18 PM, Aldy Hernandez wrote: >>> Hi. >>> >>> Attached are misc cleanups to tree-ssa-threadbackwards.c and friends. >>> Th

Re: backwards threader cleanups

2017-09-02 Thread Aldy Hernandez
On Fri, Sep 1, 2017 at 6:11 PM, Jeff Law wrote: > On 09/01/2017 02:18 PM, Aldy Hernandez wrote: >> Hi. >> >> Attached are misc cleanups to tree-ssa-threadbackwards.c and friends. >> The main gist of the patch is making the path vectors live in the >> heap, not GC. But I also cleaned up some comme

Re: backwards threader cleanups

2017-09-02 Thread Aldy Hernandez
On Fri, Sep 1, 2017 at 10:16 PM, Trevor Saunders wrote: > On Fri, Sep 01, 2017 at 04:18:20PM -0400, Aldy Hernandez wrote: >> Hi. >> >> Attached are misc cleanups to tree-ssa-threadbackwards.c and friends. >> The main gist of the patch is making the path vectors live in the >> heap, not GC. But I

Re: backwards threader cleanups

2017-09-01 Thread Trevor Saunders
On Fri, Sep 01, 2017 at 04:18:20PM -0400, Aldy Hernandez wrote: > Hi. > > Attached are misc cleanups to tree-ssa-threadbackwards.c and friends. > The main gist of the patch is making the path vectors live in the > heap, not GC. But I also cleaned up some comments to reflect reality, > and renamed

Re: backwards threader cleanups

2017-09-01 Thread Jeff Law
On 09/01/2017 02:18 PM, Aldy Hernandez wrote: > Hi. > > Attached are misc cleanups to tree-ssa-threadbackwards.c and friends. > The main gist of the patch is making the path vectors live in the > heap, not GC. But I also cleaned up some comments to reflect reality, > and renamed VAR_BB which coul

backwards threader cleanups

2017-09-01 Thread Aldy Hernandez
Hi. Attached are misc cleanups to tree-ssa-threadbackwards.c and friends. The main gist of the patch is making the path vectors live in the heap, not GC. But I also cleaned up some comments to reflect reality, and renamed VAR_BB which could use a more meaningful name. Finally, I abstracted some