Re: Walk pointer_to and reference_to chain in free_lang_data

2018-08-23 Thread Jan Hubicka
> On Thu, 23 Aug 2018, Jan Hubicka wrote: > > > Hi > > this patch takes care of gcov. There are two oddities. First that gcov uses > > langhook to produce new records while asan gets around with make_node. > > I think both are middle-end types and in the direction of separating > > front-ends >

Re: Walk pointer_to and reference_to chain in free_lang_data

2018-08-23 Thread Richard Biener
On Thu, 23 Aug 2018, Jan Hubicka wrote: > Hi > this patch takes care of gcov. There are two oddities. First that gcov uses > langhook to produce new records while asan gets around with make_node. > I think both are middle-end types and in the direction of separating > front-ends > and middle-end

Re: Walk pointer_to and reference_to chain in free_lang_data

2018-08-23 Thread Jan Hubicka
Hi this patch takes care of gcov. There are two oddities. First that gcov uses langhook to produce new records while asan gets around with make_node. I think both are middle-end types and in the direction of separating front-ends and middle-ends better the langhooks are not desirable. The TYPE_ST

Re: Walk pointer_to and reference_to chain in free_lang_data

2018-08-23 Thread Richard Biener
On Thu, 23 Aug 2018, Jan Hubicka wrote: > > > tree type_decl = build_decl (input_location, TYPE_DECL, > > > > > >get_identifier ("__asan_global"), ret); > > > > > > DECL_IGNORED_P (type_decl) = 1;

Re: Walk pointer_to and reference_to chain in free_lang_data

2018-08-23 Thread Jan Hubicka
> > tree type_decl = build_decl (input_location, TYPE_DECL, > > > >get_identifier ("__asan_global"), ret); > > > > DECL_IGNORED_P (type_decl) = 1; > > > > DECL_ARTIFICIAL (type_d

Re: Walk pointer_to and reference_to chain in free_lang_data

2018-08-22 Thread Jan Hubicka
> > tree type_decl = build_decl (input_location, TYPE_DECL, > > > >get_identifier ("__asan_global"), ret); > > > > DECL_IGNORED_P (type_decl) = 1; > > > > DECL_ARTIFICIAL (type_d

Re: Walk pointer_to and reference_to chain in free_lang_data

2018-08-22 Thread Richard Biener
On Wed, 22 Aug 2018, Jan Hubicka wrote: > > On Tue, 21 Aug 2018, Jan Hubicka wrote: > > > > > Hi, > > > extra sanity checking I am going to send in followup patch noticed that we > > > stream pointer types that was never seen by free_lang_data. This is > > > because > > > they are referenced by

Re: Walk pointer_to and reference_to chain in free_lang_data

2018-08-22 Thread Jan Hubicka
> On Tue, 21 Aug 2018, Jan Hubicka wrote: > > > Hi, > > extra sanity checking I am going to send in followup patch noticed that we > > stream pointer types that was never seen by free_lang_data. This is because > > they are referenced by TYPE_POINTER_TO list and are inserted into the gimple > > s

Re: Walk pointer_to and reference_to chain in free_lang_data

2018-08-22 Thread Richard Biener
On Tue, 21 Aug 2018, Jan Hubicka wrote: > Hi, > extra sanity checking I am going to send in followup patch noticed that we > stream pointer types that was never seen by free_lang_data. This is because > they are referenced by TYPE_POINTER_TO list and are inserted into the gimple > statements late

Walk pointer_to and reference_to chain in free_lang_data

2018-08-21 Thread Jan Hubicka
Hi, extra sanity checking I am going to send in followup patch noticed that we stream pointer types that was never seen by free_lang_data. This is because they are referenced by TYPE_POINTER_TO list and are inserted into the gimple statements later when we wrap everything in MEM_REF (by make_point