Re: V8 [PATCH] C/C++: Add -Waddress-of-packed-member

2018-12-19 Thread H.J. Lu
On Tue, Dec 18, 2018 at 7:19 PM Sandra Loosemore wrote: > > On 12/18/18 2:12 PM, H.J. Lu wrote: > > > > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > > index ac2ee59d92c..47f2fc3f518 100644 > > --- a/gcc/doc/invoke.texi > > +++ b/gcc/doc/invoke.texi > > @@ -358,6 +358,7 @@ Objective-C a

Re: V8 [PATCH] C/C++: Add -Waddress-of-packed-member

2018-12-19 Thread H.J. Lu
On Tue, Dec 18, 2018 at 2:14 PM Jason Merrill wrote: > > On 12/18/18 4:12 PM, H.J. Lu wrote: > > On Tue, Dec 18, 2018 at 12:36 PM Jason Merrill wrote: > >> > >> On 12/18/18 9:10 AM, H.J. Lu wrote: > >>> + switch (TREE_CODE (rhs)) > >>> +{ > >>> +case ADDR_EXPR: > >>> + base = TREE_O

Re: V8 [PATCH] C/C++: Add -Waddress-of-packed-member

2018-12-18 Thread Sandra Loosemore
On 12/18/18 2:12 PM, H.J. Lu wrote: diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index ac2ee59d92c..47f2fc3f518 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -358,6 +358,7 @@ Objective-C and Objective-C++ Dialects}. -Wuseless-cast -Wvariadic-macros -Wvector-operation

Re: V8 [PATCH] C/C++: Add -Waddress-of-packed-member

2018-12-18 Thread Jason Merrill
On 12/18/18 4:12 PM, H.J. Lu wrote: On Tue, Dec 18, 2018 at 12:36 PM Jason Merrill wrote: On 12/18/18 9:10 AM, H.J. Lu wrote: + switch (TREE_CODE (rhs)) +{ +case ADDR_EXPR: + base = TREE_OPERAND (rhs, 0); + while (handled_component_p (base)) + { + if (TREE_CODE (b

V8 [PATCH] C/C++: Add -Waddress-of-packed-member

2018-12-18 Thread H.J. Lu
On Tue, Dec 18, 2018 at 12:36 PM Jason Merrill wrote: > > On 12/18/18 9:10 AM, H.J. Lu wrote: > > + switch (TREE_CODE (rhs)) > > +{ > > +case ADDR_EXPR: > > + base = TREE_OPERAND (rhs, 0); > > + while (handled_component_p (base)) > > + { > > + if (TREE_CODE (base) == C