On Wed, Jul 22, 2015 at 05:49:13PM +0300, Maxim Blumental wrote:
> 2015-07-22 Maxim Blumenthal
>
> PR libgomp/66950
> * testsuite/libgomp.c/examples-4/simd-7.c(N): Change to 30 from 45.
Space before (N):
> (fib_ref): New function.
> (fib): Correct corner cases in the r
Corrected log and patch.
2015-07-22 17:12 GMT+03:00 Jakub Jelinek :
> On Wed, Jul 22, 2015 at 04:55:09PM +0300, Maxim Blumental wrote:
>> 2015-07-22 Maxim Blumenthal
>>
>> PR libgomp/66950
>> * testsuite/libgomp.c/examples-4/simd-7.c: Lower the defined constant
>> N to 30. A
On Wed, Jul 22, 2015 at 04:55:09PM +0300, Maxim Blumental wrote:
> 2015-07-22 Maxim Blumenthal
>
> PR libgomp/66950
> * testsuite/libgomp.c/examples-4/simd-7.c: Lower the defined constant
> N to 30. Add iterative reference function for Fibonacci numbers
> - fib_ref.
In
Changed simd-7 test for C and Fortran to lower the execution time to
~0.6 and ~1 second respectively while keeping the test representative.
Measured the time like:
$ time make check-target-libgomp RUNTESTFLAGS="c.exp"=simd-7.c
on a Linux x86-64 machine. (Without the patch I also had a very long
t
On Tue, Jul 14, 2015 at 11:04 AM, Jakub Jelinek wrote:
> On Tue, Jul 14, 2015 at 08:40:50PM +0300, Maxim Blumental wrote:
>> The patch replaces all FP comparisons with inequalities and epsilons
>> in those tests for libgomp.
>
libgomp.fortran/examples-4/simd-7.f90 takes a very long time to
run o
On Wed, Jul 15, 2015 at 12:29:53 +0200, Dominique d'Humières wrote:
> > The patch replaces all FP comparisons with inequalities and epsilons
> > in those tests for libgomp.
> In libgomp/testsuite/libgomp.fortran/examples-4/simd-8.f90
>
> integer, parameter :: EPS = 0.005
>
> should be
>
> real,
> The patch replaces all FP comparisons with inequalities and epsilons
> in those tests for libgomp.
In libgomp/testsuite/libgomp.fortran/examples-4/simd-8.f90
integer, parameter :: EPS = 0.005
should be
real, parameter :: EPS = 0.005
TIA
Dominique
On Tue, Jul 14, 2015 at 08:40:50PM +0300, Maxim Blumental wrote:
> The patch replaces all FP comparisons with inequalities and epsilons
> in those tests for libgomp.
Ok, thanks.
Jakub
The patch replaces all FP comparisons with inequalities and epsilons
in those tests for libgomp.
2015-07-14 20:37 GMT+03:00 Maxim Blumental :
> Sorry, a little misunderstanding between me and Ilya ) I'll send the
> new patch now.
>
> 2015-07-14 20:29 GMT+03:00 Jakub Jelinek :
>> On Tue, Jul 14, 2
Hi!
Note Richard reported that simd-8.c and simd-8.f90 tests fail on i686,
can you please adjust them so that they don't perform direct comparison of
floating point values, but allow some small epsilon (0.00390625
or something similar)? The last iteration multiplies 998 by 1.8, adds
that to 1498.
On Thu, Jul 09, 2015 at 05:23:36PM +0300, Maxim Blumental wrote:
> Now the patch is corrected (according to the previous letter) and
> ready to be reviewed. I'm looking forward to your feedback.
Ok, I guess while the filenames are still different, it is quite easily
possible to find corresponding
Now the patch is corrected (according to the previous letter) and
ready to be reviewed. I'm looking forward to your feedback.
2015-07-09 15:56 GMT+03:00 Maxim Blumental :
> > I'll have a look, that is supposed to work.
> I checked the case with 'simd collapse' and found out that the problem
> wa
> I'll have a look, that is supposed to work.
I checked the case with 'simd collapse' and found out that the problem
was in a typo in the directive in OpenMP Examples whose code I used.
There was a redundant 'for' word in it which the parser detected and
considered to be an unclassifiable OpenMP d
>The Examples-4/
>directory is supposed to only contain the tests from the 4.0.* examples
>document and no other tests.
All right: everything I added in it was only tests from the examples
document. Renamings were made in accordance with filenames from
GitHub.
> Any new tests that aren't in Example
Updated the attached files: renamed also libgomp.c++ tests, corrected
ChangeLog.
2015-07-07 21:29 GMT+03:00 Ilya Verbin :
> On Tue, Jul 07, 2015 at 20:17:48 +0200, Jakub Jelinek wrote:
>> On Tue, Jul 07, 2015 at 08:08:16PM +0300, Maxim Blumental wrote:
>> > > Added 16 tests for simd construct and
On Tue, Jul 07, 2015 at 20:17:48 +0200, Jakub Jelinek wrote:
> On Tue, Jul 07, 2015 at 08:08:16PM +0300, Maxim Blumental wrote:
> > > Added 16 tests for simd construct and 10 for depend clause.
>
> Any new tests that aren't in Examples 4.0.* document should go one level
> higher, to libgomp.{c,c++
ve a look, that is supposed to work.
> 2015-07-07 19:48 GMT+03:00 Maxim Blumental :
> > With this letter I propose a patch with tests for libgomp based on
> > OpenMP Examples 4.0.2 both for C and Fortran.
> >
> > The changes are:
> >
> > Renamed existing
Comment on the patch:
simd-5.f90 file is marked as xfail since the test fails because 'simd
collapse' is an unsupported combination for Fortran (which though is
valid in OpenMP API).
2015-07-07 19:48 GMT+03:00 Maxim Blumental :
> With this letter I propose a patch with tests for lib
With this letter I propose a patch with tests for libgomp based on
OpenMP Examples 4.0.2 both for C and Fortran.
The changes are:
Renamed existing tests based on OpenMP Examples to make the names more clear.
Added 16 tests for simd construct and 10 for depend clause
19 matches
Mail list logo
