Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-11 Thread Jonathan Wakely
On 10/06/19 18:46 -0400, Ed Smith-Rowland via libstdc++ wrote: On 6/10/19 2:43 AM, Ville Voutilainen wrote: On Mon, 10 Jun 2019 at 02:53, Ed Smith-Rowland <3dw...@verizon.net> wrote: Darn it, I had those constexpr lib patches in tree. Attached are what I just committed to gcc-9 and passes ther

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-10 Thread Ed Smith-Rowland via gcc-patches
On 6/10/19 2:43 AM, Ville Voutilainen wrote: On Mon, 10 Jun 2019 at 02:53, Ed Smith-Rowland <3dw...@verizon.net> wrote: Darn it, I had those constexpr lib patches in tree. Attached are what I just committed to gcc-9 and passes there. Those std::copy didn't really add anything anyway. They adde

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-09 Thread Ville Voutilainen
On Mon, 10 Jun 2019 at 02:53, Ed Smith-Rowland <3dw...@verizon.net> wrote: > Darn it, I had those constexpr lib patches in tree. > Attached are what I just committed to gcc-9 and passes there. Those > std::copy didn't really add anything anyway. They added a test that *i++ = *j++ works, and that

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-09 Thread Ed Smith-Rowland via gcc-patches
On 6/9/19 6:28 PM, Jonathan Wakely wrote: On 10/06/19 00:03 +0200, Rainer Orth wrote: Hi Ed, I had supplied the option for gnu++2a by hand and they passed.?? They were not UNSUPPORTED. I just added the dg-options (at very top) and reran the testsuite without fancy tricks (except for gnu++2a).

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-09 Thread Jonathan Wakely
On 10/06/19 00:03 +0200, Rainer Orth wrote: Hi Ed, I had supplied the option for gnu++2a by hand and they passed.?? They were not UNSUPPORTED. I just added the dg-options (at very top) and reran the testsuite without fancy tricks (except for gnu++2a). I also took out the #if __cplusplus.?? I

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-09 Thread Ville Voutilainen
On Mon, 10 Jun 2019 at 01:03, Rainer Orth wrote: > > Hi Ed, > > >>> I had supplied the option for gnu++2a by hand and they passed.?? They > >>> were not UNSUPPORTED. > >>> > >>> I just added the dg-options (at very top) and reran the testsuite > >>> without fancy tricks (except for gnu++2a). > >>>

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-09 Thread Rainer Orth
Hi Ed, >>> I had supplied the option for gnu++2a by hand and they passed.?? They >>> were not UNSUPPORTED. >>> >>> I just added the dg-options (at very top) and reran the testsuite >>> without fancy tricks (except for gnu++2a). >>> >>> I also took out the #if __cplusplus.?? I was just playing arou

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-09 Thread Ed Smith-Rowland via gcc-patches
); } Ok, third time's a charm. I was brain dead about the constexpr patch.?? I'm now setting a constexpr variable from test() in a caller. But static_assert is a constexpr context no? Ed 2019-06-03?? Edward Smith-Rowland <3dw...@verizon.net> Test for C++20 p0858

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-08 Thread Jonathan Wakely
brain dead about the constexpr patch.?? I'm now setting a constexpr variable from test() in a caller. But static_assert is a constexpr context no? Ed 2019-06-03?? Edward Smith-Rowland <3dw...@verizon.net> Test for C++20 p0858 - ConstexprIterator requirements. * testsu

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-08 Thread Ed Smith-Rowland via gcc-patches
ting a constexpr variable from test() in a caller. But static_assert is a constexpr context no? Ed 2019-06-03?? Edward Smith-Rowland <3dw...@verizon.net> Test for C++20 p0858 - ConstexprIterator requirements. * testsuite/21_strings/basic_string_view/requirements/cons

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-07 Thread Jonathan Wakely
ting a constexpr variable from test() in a caller. But static_assert is a constexpr context no? Ed 2019-06-03 Edward Smith-Rowland <3dw...@verizon.net> Test for C++20 p0858 - ConstexprIterator requirements. * testsuite/21_strings/basic_string_view/requirements/con

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-07 Thread Jonathan Wakely
. But static_assert is a constexpr context no? Ed 2019-06-03 Edward Smith-Rowland <3dw...@verizon.net> Test for C++20 p0858 - ConstexprIterator requirements. * testsuite/21_strings/basic_string_view/requirements/constexpr_iter.cc: New test. * testsuite/

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-01 Thread Ville Voutilainen
On Sat, 1 Jun 2019 at 22:40, Ed Smith-Rowland <3dw...@verizon.net> wrote: > Ok, third time's a charm. > > I was brain dead about the constexpr patch.?? I'm now setting a constexpr > variable from test() in a caller. Looks good. Jonathan needs to approve it, though. > But static_assert is a const

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-01 Thread Ed Smith-Rowland via gcc-patches
6-03 Edward Smith-Rowland <3dw...@verizon.net> Test for C++20 p0858 - ConstexprIterator requirements. * testsuite/21_strings/basic_string_view/requirements/constexpr_iter.cc: New test. * testsuite/23_containers/array/requirements/constexpr_iter.cc: New te

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-01 Thread Ville Voutilainen
On Sat, 1 Jun 2019 at 21:09, Ed Smith-Rowland <3dw...@verizon.net> wrote: > > On 5/31/19 6:29 PM, Ville Voutilainen wrote: > > On Sat, 1 Jun 2019 at 01:24, Ed Smith-Rowland via libstdc++ > > wrote: > >> Greetings, > >> > >> Iterators for and are usabe in a constexpr context > >> since C++2017. >

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-06-01 Thread Ed Smith-Rowland via gcc-patches
DR though. Anyway, that should do it. Built and tested clean on x86_64-linux. Ok? Ed 2019-06-03 Edward Smith-Rowland <3dw...@verizon.net> Test for C++20 p0858 - ConstexprIterator requirements. * testsuite/21_strings/basic_string_view/requirements/constexpr

Re: Test for C++20 p0858 - ConstexprIterator requirements.

2019-05-31 Thread Ville Voutilainen
On Sat, 1 Jun 2019 at 01:24, Ed Smith-Rowland via libstdc++ wrote: > > Greetings, > > Iterators for and are usabe in a constexpr context > since C++2017. > > This just adds a compile test to make sure and check a box for C++20 > p0858 - ConstexprIterator requirements. Those tests don't use the

Test for C++20 p0858 - ConstexprIterator requirements.

2019-05-31 Thread Ed Smith-Rowland via gcc-patches
Greetings, Iterators for and are usabe in a constexpr context since C++2017. This just adds a compile test to make sure and check a box for C++20 p0858 - ConstexprIterator requirements. Ed 2019-06-03 Edward Smith-Rowland <3dw...@verizon.net> Test for C++20