Re: Strengthen ICF hash

2015-03-06 Thread Joseph Myers
On Wed, 4 Mar 2015, Jan Hubicka wrote: > But yes, I do not think we need to significantly slow things down in current > implemetnation when this feature does not work. Just perhaps keep track of > changes that introduce host specific stuff and not introduce these when it is > easily avoidable. K

Re: Strengthen ICF hash

2015-03-04 Thread Jan Hubicka
> On March 4, 2015 9:22:24 PM CET, Jan Hubicka wrote: > >> On Wed, Mar 4, 2015 at 2:20 PM, Andi Kleen > >wrote: > >> > Hi Honza, > >> > > >> > Regarding modern hash functions, as far as I understand the trend > >> > is to just stop doing anything fancy and just use the CRC > >instructions > >> >

Re: Strengthen ICF hash

2015-03-04 Thread Richard Biener
On March 4, 2015 9:22:24 PM CET, Jan Hubicka wrote: >> On Wed, Mar 4, 2015 at 2:20 PM, Andi Kleen >wrote: >> > Hi Honza, >> > >> > Regarding modern hash functions, as far as I understand the trend >> > is to just stop doing anything fancy and just use the CRC >instructions >> > in modern CPUs >>

Re: Strengthen ICF hash

2015-03-04 Thread Jan Hubicka
> On Wed, Mar 4, 2015 at 2:20 PM, Andi Kleen wrote: > > Hi Honza, > > > > Regarding modern hash functions, as far as I understand the trend > > is to just stop doing anything fancy and just use the CRC instructions > > in modern CPUs > > I wonder if we can use intrinsics for CRC in place of the >

Re: Strengthen ICF hash

2015-03-04 Thread Richard Biener
On Wed, Mar 4, 2015 at 2:20 PM, Andi Kleen wrote: > Hi Honza, > > Regarding modern hash functions, as far as I understand the trend > is to just stop doing anything fancy and just use the CRC instructions > in modern CPUs I wonder if we can use intrinsics for CRC in place of the existing iterativ

Re: Strengthen ICF hash

2015-03-04 Thread Andi Kleen
Hi Honza, Regarding modern hash functions, as far as I understand the trend is to just stop doing anything fancy and just use the CRC instructions in modern CPUs (unless you need a somewhat cryto hash to guard against DoS attacks). spooky doesn't do that though, it's just a highly optimized classi

Re: Strengthen ICF hash

2015-03-03 Thread Mikhail Maltsev
03.03.2015 10:25, Jan Hubicka writes: >>> >>> The hash itself is quite simple (borrowing incremental hash for constants >>> adding >>> very simple match for other stuff + logic to skip things that may match >>> even if >>> they are syntactticaly different). The hash can be strenghtened >>> sign

Re: Strengthen ICF hash

2015-03-02 Thread Jan Hubicka
Andi, > Jan Hubicka writes: > > > > The hash itself is quite simple (borrowing incremental hash for constants > > adding > > very simple match for other stuff + logic to skip things that may match > > even if > > they are syntactticaly different). The hash can be strenghtened > > significantly,

Re: Strengthen ICF hash

2015-03-01 Thread Andi Kleen
Jan Hubicka writes: > > The hash itself is quite simple (borrowing incremental hash for constants > adding > very simple match for other stuff + logic to skip things that may match even > if > they are syntactticaly different). The hash can be strenghtened significantly, > but I suppose we may d

Strengthen ICF hash

2015-03-01 Thread Jan Hubicka
Hi, getting more familiar with ipa-icf I start to understand why it is a compile time hog for firefox. I assumed it spends most of time streaming in bodies and comparing them to see they are equivalent (after all about 10% of all symbols turns out to be and each of that needs to be read to memory)