Re: Small fix for walking constructors

2014-09-22 Thread Richard Biener
On Mon, Sep 22, 2014 at 11:52 AM, Bernd Schmidt wrote: > On 09/22/2014 11:00 AM, Richard Biener wrote: >>> >>> It seems to me that walk_stmt_load_store_addr_ops is called on >>> bogus input. The function is supposed to be called on GIMPLE >>> stmts and in GIMPLE stmts CONSTRUCTORs may _not_ have

Re: Small fix for walking constructors

2014-09-22 Thread Richard Biener
On Mon, Sep 22, 2014 at 11:00 AM, Richard Biener wrote: > On Mon, Sep 22, 2014 at 10:58 AM, Richard Biener > wrote: >> On Thu, Sep 18, 2014 at 10:38 PM, Jeff Law wrote: >>> On 09/18/14 13:01, Bernd Schmidt wrote: This fixes an issue on ptx where we fail to output a declaration for a >>

Re: Small fix for walking constructors

2014-09-22 Thread Bernd Schmidt
On 09/22/2014 11:00 AM, Richard Biener wrote: It seems to me that walk_stmt_load_store_addr_ops is called on bogus input. The function is supposed to be called on GIMPLE stmts and in GIMPLE stmts CONSTRUCTORs may _not_ have conversions in their elements. Please revert if you have applied alread

Re: Small fix for walking constructors

2014-09-22 Thread Richard Biener
On Mon, Sep 22, 2014 at 10:58 AM, Richard Biener wrote: > On Thu, Sep 18, 2014 at 10:38 PM, Jeff Law wrote: >> On 09/18/14 13:01, Bernd Schmidt wrote: >>> >>> This fixes an issue on ptx where we fail to output a declaration for a >>> variable. The testcase is c-torture/compile/pr34856.c, and the

Re: Small fix for walking constructors

2014-09-22 Thread Richard Biener
On Thu, Sep 18, 2014 at 10:38 PM, Jeff Law wrote: > On 09/18/14 13:01, Bernd Schmidt wrote: >> >> This fixes an issue on ptx where we fail to output a declaration for a >> variable. The testcase is c-torture/compile/pr34856.c, and the cause of >> the problem is that the variable g is never inserte

Re: Small fix for walking constructors

2014-09-18 Thread Jeff Law
On 09/18/14 13:01, Bernd Schmidt wrote: This fixes an issue on ptx where we fail to output a declaration for a variable. The testcase is c-torture/compile/pr34856.c, and the cause of the problem is that the variable g is never inserted into the varpool, which is where a future patch will look for

Small fix for walking constructors

2014-09-18 Thread Bernd Schmidt
This fixes an issue on ptx where we fail to output a declaration for a variable. The testcase is c-torture/compile/pr34856.c, and the cause of the problem is that the variable g is never inserted into the varpool, which is where a future patch will look for references to variables not defined i