Re: Simplify _Rb_tree instantiation

2018-05-27 Thread François Dumont
On 25/05/2018 21:19, Ville Voutilainen wrote: On 25 May 2018 at 22:16, Jonathan Wakely wrote: Why is this patch removing _Compare() calls? That changes the initialization of _Compare from value-initialization to default-initialization, which is a breaking change. The _Rb_tree_key_compare base

Re: Simplify _Rb_tree instantiation

2018-05-25 Thread Ville Voutilainen
On 25 May 2018 at 22:16, Jonathan Wakely wrote: >> Why is this patch removing _Compare() calls? That changes the >> initialization >> of _Compare from value-initialization to default-initialization, which >> is a breaking change. > > > The _Rb_tree_key_compare base class will still value-initializ

Re: Simplify _Rb_tree instantiation

2018-05-25 Thread Jonathan Wakely
On 25/05/18 21:35 +0300, Ville Voutilainen wrote: On 25 May 2018 at 19:50, François Dumont wrote: Hi As we are at working on associative containers I'd like to propose this last patch to remove the copy constructible constraint on the _Compare functor when it is supposed to be default construc

Re: Simplify _Rb_tree instantiation

2018-05-25 Thread Ville Voutilainen
On 25 May 2018 at 19:50, François Dumont wrote: > Hi > > As we are at working on associative containers I'd like to propose this last > patch to remove the copy constructible constraint on the _Compare functor > when it is supposed to be default constructed. > > This way the _Compare is built dire

Simplify _Rb_tree instantiation

2018-05-25 Thread François Dumont
Hi As we are at working on associative containers I'd like to propose this last patch to remove the copy constructible constraint on the _Compare functor when it is supposed to be default constructed. This way the _Compare is built directly at its final place.     * include/bits/stl_tree.h (