On 05/29/14 06:07, Richard Sandiford wrote:
Can't really approve it, but it looks obviously correct to me.
Thanks for the fix.
Is that something you'd like to see changed?
Jeff
) \
this information to avoid recomputing it. Finally, this allows
space for
the target to store more than one bit of information, as with
SYMBOL_REF_FLAG. */
-#define SYMBOL_REF_FLAGS(RTX)X0INT ((RTX), 1)
+#define SYMBOL_REF_FLAGS(RTX) \
+ (RTL_FLAG_CHECK1 ("SYMBOL_REF_FLAGS&q
ine SYMBOL_REF_CONSTANT(RTX) \
>> this information to avoid recomputing it. Finally, this allows space
>> for
>> the target to store more than one bit of information, as with
>> SYMBOL_REF_FLAG. */
>> -#define SYMBOL_REF_FLAGS(RTX) X0INT ((RTX), 1)
&
recomputing it. Finally, this allows space for
the target to store more than one bit of information, as with
SYMBOL_REF_FLAG. */
-#define SYMBOL_REF_FLAGS(RTX) X0INT ((RTX), 1)
+#define SYMBOL_REF_FLAGS(RTX) \
+ (RTL_FLAG_CHECK1 ("SYMBOL_REF_FLAGS", (RTX), SYMBOL_REF) \
+ ->u2.sym
I think you would have seen the same failure before the patch with
> --enable-checking=yes,rtl.
>
> The reason my patch broke the bootstrap is that SYMBOL_REF_FLAGS now
> checks based on ENABLE_RTL_FLAG_CHECKING rather than ENABLE_RTL_CHECKING.
> I'd done that because u2 is part
David Edelsohn writes:
> Richard,
>
> Your SYMBOL_REF_FLAGS RTX patches broke bootstrap on AIX.
>
> - David
>
> /nasfarm/edelsohn/src/src/libgcc/libgcc2.c: In function '__eprintf':
> /nasfarm/edelsohn/src/src/libgcc/libgcc2.c:2126:1: internal compiler error:
&g
Richard,
Your SYMBOL_REF_FLAGS RTX patches broke bootstrap on AIX.
- David
/nasfarm/edelsohn/src/src/libgcc/libgcc2.c: In function '__eprintf':
/nasfarm/edelsohn/src/src/libgcc/libgcc2.c:2126:1: internal compiler error: RTL
flag check: SYMBOL_REF_FLAGS used with unexpected rtx code
/
* rtl.def (SYMBOL_REF): Remove middle "0" field.
* rtl.h (block_symbol): Reduce number of fields to 2.
(rtx_def): Add u2.symbol_ref_flags.
(SYMBOL_REF_FLAGS): Use it.
(SYMBOL_REF_DATA, SET_SYMBOL_REF_DECL, SYMBOL_REF_DECL)
(SET_SYMBOL_RE
On 05/12/14 05:00, Richard Sandiford wrote:
Michael Matz writes:
Hi,
On Sat, 10 May 2014, Richard Sandiford wrote:
@@ -362,6 +362,9 @@ struct GTY((chain_next ("RTX_NEXT (&%h)"
/* The INSN_UID of an RTX_INSN-class code. */
int insn_uid;
+/* The SYMBOL_
Hi,
On Mon, 12 May 2014, Richard Sandiford wrote:
> > Also I'm idly wondering if the explicit sizing of
> > the fields via a bit-field as originally would be better here or just
> > confusing. I guess unsigned and enums are 32bit for all hosts we care
> > about, but if we ever have one where
Michael Matz writes:
> Hi,
>
> On Sat, 10 May 2014, Richard Sandiford wrote:
>
>> @@ -362,6 +362,9 @@ struct GTY((chain_next ("RTX_NEXT (&%h)"
>> /* The INSN_UID of an RTX_INSN-class code. */
>> int insn_uid;
>>
>> +/* Th
Hi,
On Sat, 10 May 2014, Richard Sandiford wrote:
> @@ -362,6 +362,9 @@ struct GTY((chain_next ("RTX_NEXT (&%h)"
> /* The INSN_UID of an RTX_INSN-class code. */
> int insn_uid;
>
> +/* The SYMBOL_REF_FLAGS of a SYMBOL_REF. */
> + unsigned in
uot; field.
* rtl.h (block_symbol): Reduce number of fields to 2.
(rtx_def): Add u2.symbol_ref_flags.
(SYMBOL_REF_FLAGS): Use it.
(SYMBOL_REF_DATA, SET_SYMBOL_REF_DECL, SYMBOL_REF_DECL)
(SET_SYMBOL_REF_CONSTANT, SYMBOL_REF_CONSTANT): Lower index.
*
13 matches
Mail list logo
