etter Tomner; gcc-patches@gcc.gnu.org; j...@gcc.gnu.org
Ämne: Re: SV: [PATCH v2] jit: Add support for global rvalue initialization and
ctors
On Sun, 2021-12-12 at 20:39 -0500, Antoni Boucher wrote:
> Yes, this patch works for rustc_codegen_gcc perfectly.
> It even fixes one issue tha
On Sun, 2021-12-12 at 20:39 -0500, Antoni Boucher wrote:
> Yes, this patch works for rustc_codegen_gcc perfectly.
> It even fixes one issue that was in my patch, so that's nice!
Excellent - thanks Antoni.
>
> Le samedi 11 décembre 2021 à 15:35 +, Petter Tomner a écrit :
> > Hi!
> >
> > > s/
Also, the LIBGCCJIT_ABI_17 will need to be updated as I merged some of
my patches.
Le samedi 11 décembre 2021 à 15:35 +, Petter Tomner a écrit :
> Hi!
>
> > s/an union/a union/
> > s/a rvalue/an rvalue/
>
> Heh no way ... and I though I knew English grammar :)
>
> Had to look that up to see
One thing I'm not sure if it is a code style issue, but worth
mentionning:
> @@ -1405,8 +1436,10 @@ private:
>
> private:
>enum gcc_jit_global_kind m_kind;
> + enum global_var_flags flags = GLOBAL_VAR_FLAGS_NONE;
^
Should it be named m_flags instead of flags?
Yes, this patch works for rustc_codegen_gcc perfectly.
It even fixes one issue that was in my patch, so that's nice!
Le samedi 11 décembre 2021 à 15:35 +, Petter Tomner a écrit :
> Hi!
>
> > s/an union/a union/
> > s/a rvalue/an rvalue/
>
> Heh no way ... and I though I knew English grammar
Hi!
> s/an union/a union/
> s/a rvalue/an rvalue/
Heh no way ... and I though I knew English grammar :)
Had to look that up to see what the deal was but it makes sense.
yunion, arevalue.
> s/wrong-field-name/wrong-field-obj/
>
> to match the struct example (given that the issue being tested f
