Hi,
On Wed, Aug 6, 2014 at 4:51 AM, Alexander Ivchenko wrote:
> We still have to remove fix for compiler.h:
Correct. Thank you.
> Bruce, I think I formally have to ask for your approval again :)
I don't think so. You've selected one of the changes we wrote about,
so "With one of the two cha
The only thing that I don't like about that, is that the user would
still have stdio.h fixed if gcc is built with sysroots older than r10.
But I guess it is not that critical :)
We still have to remove fix for compiler.h:
diff --git a/fixincludes/ChangeLog b/fixincludes/ChangeLog
index f7effee..
On Tue, Aug 5, 2014 at 5:26 PM, Bruce Korb wrote:
> Hi,
>
> Lines 42 & 43 are not needed for fixincludes, but it is your choice.
> With that change, you should not need to add that test to fixincludes
> because __gnuc_va_list will be found within the comment and satisfy
> the "bypass" expression.
Hi,
Lines 42 & 43 are not needed for fixincludes, but it is your choice.
With that change, you should not need to add that test to fixincludes
because __gnuc_va_list will be found within the comment and satisfy
the "bypass" expression.
That was the long way of saying:
Looks good to me.
On Tue
does https://android-review.googlesource.com/103445 look okay?
On Tue, Aug 5, 2014 at 12:01 PM, Bruce Korb wrote:
> Hi,
>
> On Tue, Aug 5, 2014 at 10:36 AM, enh wrote:
>> you can see the current version of bionic's stdio.h here:
>>
>> https://android.googlesource.com/platform/bionic/+/master/lib
Hi,
On Tue, Aug 5, 2014 at 10:36 AM, enh wrote:
> you can see the current version of bionic's stdio.h here:
>
> https://android.googlesource.com/platform/bionic/+/master/libc/include/stdio.h
>
> i'm happy to add any string to the header file that makes things
> easier. if you want 'x-gcc-no-fixin
On Tue, Aug 5, 2014 at 7:10 AM, Bruce Korb wrote:
> Hi,
>
> On Tue, Aug 5, 2014 at 4:35 AM, Alexander Ivchenko wrote:
>>> Testing for *android* is less than ideal, because of the possibility of
>>> configuring a *-linux* toolchain to have multilibs using various different
>>> C libraries (with -m
Hi,
On Tue, Aug 5, 2014 at 4:35 AM, Alexander Ivchenko wrote:
>> Testing for *android* is less than ideal, because of the possibility of
>> configuring a *-linux* toolchain to have multilibs using various different
>> C libraries (with -mandroid being used to select the Android multilib).
>> So,
Hi Andrew, Joseph,
thanks for looking at the patch. See my comments and updated patch below.
2014-08-05 0:54 GMT+04:00 Andrew Pinski :
> On Mon, Aug 4, 2014 at 8:29 AM, Alexander Ivchenko wrote:
>> Hi,
>>
>> The following patch disables "stdio_va_list" fix: stdio.h is already
>> good in Android a
On Mon, Aug 4, 2014 at 8:29 AM, Alexander Ivchenko wrote:
> Hi,
>
> The following patch disables "stdio_va_list" fix: stdio.h is already
> good in Android and, since ndk gcc is indented to be used with
> different Android sysroots, it is actually harmful, because without
> this fix only the versio
On Mon, 4 Aug 2014, Alexander Ivchenko wrote:
> +2014-08-04 Alexander Ivchenko
> +
> + * inclhack.def (stdio_va_list): Disable fix for *android*.
Testing for *android* is less than ideal, because of the possibility of
configuring a *-linux* toolchain to have multilibs using various different
Hi,
The following patch disables "stdio_va_list" fix: stdio.h is already
good in Android and, since ndk gcc is indented to be used with
different Android sysroots, it is actually harmful, because without
this fix only the version of stdio.h from the sysroot the compiler was
built with will be used
12 matches
Mail list logo
