Re: Remove overall growth from badness metrics

>>> >>> Those are sizes of libxul, which is the largest library of Firefox. >>> PGO is profile guided optimization. >> >> Okay. I see. >> >> looks like for LTO, the code size increase with profiling is much smaller >> than >> that without profiling when growth is increased from 20% to 40%.

Re: Remove overall growth from badness metrics

> Looks like that our current documentation has a bug in the below: > > https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html > > > -finline-functions > Consider all functions for inlining, even if they are not declared inline. > The

Re: Remove overall growth from badness metrics

> On Jan 8, 2019, at 11:53 AM, Jan Hubicka wrote: > >>> >>> In general this parameter affects primarily -O3 builds, becuase -O2 >>> hardly hits the limit. From -O3 only programs with very large units are >>> affected (-O2 units hits the limit only if you do have a lot of inline >>> hints in th

Re: Remove overall growth from badness metrics

> > > > In general this parameter affects primarily -O3 builds, becuase -O2 > > hardly hits the limit. From -O3 only programs with very large units are > > affected (-O2 units hits the limit only if you do have a lot of inline > > hints in the code). > don’t quite understand here, what’s the major

Re: Remove overall growth from badness metrics

> On Jan 8, 2019, at 5:46 AM, Jan Hubicka wrote: > >>> I plan to commit the patch tomorrow after re-testing everything after >>> the bugfixes from today and yesterday. In addition to this have found >>> that current inline-unit-growth is too small for LTO of large programs >>> (especially Fire

Re: Remove overall growth from badness metrics

> > I plan to commit the patch tomorrow after re-testing everything after > > the bugfixes from today and yesterday. In addition to this have found > > that current inline-unit-growth is too small for LTO of large programs > > (especially Firefox:) and there are important improvements when > > inc

Re: Remove overall growth from badness metrics

> On Jan 6, 2019, at 5:52 PM, Jan Hubicka wrote: > > Hi, > this patch removes overall growth from badness metrics. This code was > added at a time inliner was purely function size based to give a hint > that inlining more different functions into all callers is better than > inlining one calle

Remove overall growth from badness metrics

Hi, this patch removes overall growth from badness metrics. This code was added at a time inliner was purely function size based to give a hint that inlining more different functions into all callers is better than inlining one called very many times. With profile we now have more fine grained in