Re: Remember/restore ALLOCA_FOR_VAR_P over tuples

2011-05-10 Thread H.J. Lu
On Fri, Apr 15, 2011 at 1:20 PM, Michael Matz wrote: > Hi, > > On Thu, 14 Apr 2011, Michael Matz wrote: > >> > Btw, I don't remember why I chose ALLOCA_FOR_VAR_P over >> > CALL_ALLOCA_FOR_VAR_P but, given the name of the GIMPLE flag and >> > predicate, it's probably time to change it. >> >> Good i

Re: Remember/restore ALLOCA_FOR_VAR_P over tuples

2011-04-16 Thread Eric Botcazou
> r172516, for reference also below. I later saw that my patch causes > cxg2001 to fail. I've analyzed it enough to be sure that it's only > exposed by this patch (due to inlining now happening), in fact it's a > problem in IRA that is reproducible with a C++ testcase even without the > patch. I

Re: Remember/restore ALLOCA_FOR_VAR_P over tuples

2011-04-15 Thread Michael Matz
Hi, On Thu, 14 Apr 2011, Michael Matz wrote: > > Btw, I don't remember why I chose ALLOCA_FOR_VAR_P over > > CALL_ALLOCA_FOR_VAR_P but, given the name of the GIMPLE flag and > > predicate, it's probably time to change it. > > Good idea, I'll rename it before checking in. r172516, for referenc

Re: Remember/restore ALLOCA_FOR_VAR_P over tuples

2011-04-14 Thread Michael Matz
Hi, On Thu, 14 Apr 2011, Eric Botcazou wrote: > > We have a flag for this already on the CALL_EXPR. But we don't retain > > it over tuples, and hence we also don't look at it in > > inline_forbidden_p_stmt. This patch fixes both. (The strange testing > > of builtin-ness is because in CALL_E

Re: Remember/restore ALLOCA_FOR_VAR_P over tuples

2011-04-14 Thread Eric Botcazou
> We have a flag for this already on the CALL_EXPR. But we don't retain it > over tuples, and hence we also don't look at it in > inline_forbidden_p_stmt. This patch fixes both. (The strange testing of > builtin-ness is because in CALL_EXPR the ALLOCA_FOR_VAR_P and > CALL_FROM_THUNK_P flags are

Re: Remember/restore ALLOCA_FOR_VAR_P over tuples

2011-04-14 Thread Richard Guenther
On Thu, Apr 14, 2011 at 5:18 PM, Michael Matz wrote: > Hello, > > as my patch for stack-arrays in fortran reveals we a problem that VLA > objects basically prevent all inlining to happen.  They're transformed > into alloca calls and those are considered to disable inlining.  The > (correct) fear b

Remember/restore ALLOCA_FOR_VAR_P over tuples

2011-04-14 Thread Michael Matz
Hello, as my patch for stack-arrays in fortran reveals we a problem that VLA objects basically prevent all inlining to happen. They're transformed into alloca calls and those are considered to disable inlining. The (correct) fear being that inlining a bare alloca call into a loop leads to un