Re: [PATCH][buildrobot] tilepro/tilegx: fallout after tree.h refactoring (was: Re-factor inclusion of tree.h)

2013-10-23 Thread Jan-Benedict Glaw
On Tue, 2013-10-22 08:46:13 -0400, Diego Novillo wrote: > On Tue, Oct 22, 2013 at 4:22 AM, Jan-Benedict Glaw wrote: > > This fixes it: > > > > 2013-10-22 Jan-Benedict Glaw > > > > * config/tilepro/tilepro.c: Include "tree.h". > > Sure. It qualifies as obvious. Thanks. Also committe

Re: [PATCH][buildrobot] tilepro/tilegx: fallout after tree.h refactoring (was: Re-factor inclusion of tree.h)

2013-10-22 Thread Diego Novillo
On Tue, Oct 22, 2013 at 4:22 AM, Jan-Benedict Glaw wrote: > On Mon, 2013-10-21 15:36:49 -0400, Diego Novillo wrote: >> Can anyone think of some way that we can use to automatically block >> inclusions of tree.h from header files? Code review is the only way >> that comes to mind. > > Grep once, t

[PATCH][buildrobot] tilepro/tilegx: fallout after tree.h refactoring (was: Re-factor inclusion of tree.h)

2013-10-22 Thread Jan-Benedict Glaw
On Mon, 2013-10-21 15:36:49 -0400, Diego Novillo wrote: > Can anyone think of some way that we can use to automatically block > inclusions of tree.h from header files? Code review is the only way > that comes to mind. Grep once, then install a commit hook. > Committed both patches to trunk. I g

Re: Re-factor inclusion of tree.h

2013-10-21 Thread Diego Novillo
On Mon, Oct 21, 2013 at 12:57 PM, Jeff Law wrote: > On 10/21/13 10:52, Diego Novillo wrote: >> >> I plan to commit this by tomorrow, unless there are objections. > > I can't think of a good reason to even bother waiting :-) Heh, OK, thanks. After analyzing all the build failures in config-list.m

Re: Re-factor inclusion of tree.h

2013-10-21 Thread Jeff Law
On 10/21/13 10:52, Diego Novillo wrote: This moves tree.h out of every header. This exposes dependencies of tree.h in files that should probably not need it after tree and gimple are separated. After this change, no header should include tree.h directly. It should only be included by a .c file.

Re-factor inclusion of tree.h

2013-10-21 Thread Diego Novillo
This moves tree.h out of every header. This exposes dependencies of tree.h in files that should probably not need it after tree and gimple are separated. After this change, no header should include tree.h directly. It should only be included by a .c file. Unfortunately, I did not find an automatic