Re: three problems with stor-layout.c.

2013-11-22 Thread Kenneth Zadeck
committed as revision 205260. thanks kenny On 11/22/2013 03:58 AM, Richard Biener wrote: On Thu, 21 Nov 2013, Kenneth Zadeck wrote: Richi, Here is the patch. As you can see, i chose the unsigned option. It was bootstrapped and tested on x86 with all languages including ada. Ok to commit?

Re: three problems with stor-layout.c.

2013-11-22 Thread Richard Biener
On Thu, 21 Nov 2013, Kenneth Zadeck wrote: > Richi, > > Here is the patch. As you can see, i chose the unsigned option. > It was bootstrapped and tested on x86 with all languages including ada. > Ok to commit? Ok. Thanks, Richard. > kenny > > 2013-11-21 zad...@naturalbridge.com > * sto

Re: three problems with stor-layout.c.

2013-11-21 Thread Kenneth Zadeck
Richi, Here is the patch. As you can see, i chose the unsigned option. It was bootstrapped and tested on x86 with all languages including ada. Ok to commit? kenny 2013-11-21 zad...@naturalbridge.com * store-layout.c (place-field): Fix hwi test and accessor mismatch. On 11/21/2013

Re: three problems with stor-layout.c.

2013-11-21 Thread Eric Botcazou
> I think most of these are because in the past (yes I have fixed that!!) > all 'sizetype' constants were sign-extended (and the signedness, > that is, TYPE_UNSIGNED (sizetype), was frontend dependend (ugh) and > then later true, thus unsigned). > > So I think all _SIZE stuff should check fits_uhw

Re: three problems with stor-layout.c.

2013-11-21 Thread Richard Biener
On Wed, 20 Nov 2013, Kenneth Zadeck wrote: > Richi, > > We noticed three problems with the place_field on the wide-int branch.They > come from problems on the trunk. So i assume you want me to fix the trunk > and push back into the branch. The question is how do you want them fixed? > >