Re: rs6000_handle_option global state avoidance, part 1

2011-05-06 Thread Joseph S. Myers
On Fri, 6 May 2011, Alan Modra wrote: > On Thu, May 05, 2011 at 11:29:13AM -0400, David Edelsohn wrote: > > Alan, is mcmodel suppose to set m64? > > No, that was an accident. Thanks. I'll apply this patch to remove that fall through. Tested building cc1 and xgcc for cross to powerpc64-linux-gn

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread David Edelsohn
On Thu, May 5, 2011 at 3:34 PM, Joseph S. Myers wrote: > On Thu, 5 May 2011, Michael Eager wrote: > >> David Edelsohn wrote: >> > On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers >> > wrote: >> > >> > > Two options, -mcmodel= and -mfpu=, had cases that fell through to the >> > > next case without

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Alan Modra
On Thu, May 05, 2011 at 11:29:13AM -0400, David Edelsohn wrote: > Alan, is mcmodel suppose to set m64? No, that was an accident. -- Alan Modra Australia Development Lab, IBM

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Michael Meissner
On Thu, May 05, 2011 at 03:08:43PM -0400, Michael Meissner wrote: > Yes, it was an error on my part. Sorry. I will fix the GCC 4.6 branch. I > will hold off fixing the on trunk, on the assumption this patch will go in. I > can fix it if desired. I committed the following patch on the GCC 4.6 b

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Michael Eager
Joseph S. Myers wrote: On Thu, 5 May 2011, Michael Eager wrote: David Edelsohn wrote: On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers wrote: Two options, -mcmodel= and -mfpu=, had cases that fell through to the next case without comments to indicate if this was intended. I added comments t

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Joseph S. Myers
On Thu, 5 May 2011, Michael Eager wrote: > David Edelsohn wrote: > > On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers > > wrote: > > > > > Two options, -mcmodel= and -mfpu=, had cases that fell through to the > > > next case without comments to indicate if this was intended. I added > > > commen

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Michael Meissner
On Thu, May 05, 2011 at 10:08:24AM -0700, Michael Eager wrote: > David Edelsohn wrote: > >On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers > >wrote: > > > >>Two options, -mcmodel= and -mfpu=, had cases that fell through to the > >>next case without comments to indicate if this was intended. I add

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Michael Eager
David Edelsohn wrote: On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers wrote: Two options, -mcmodel= and -mfpu=, had cases that fell through to the next case without comments to indicate if this was intended. I added comments to make the semantics explicit. Given the documentation, it may wel

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread David Edelsohn
On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers wrote: > Two options, -mcmodel= and -mfpu=, had cases that fell through to the > next case without comments to indicate if this was intended.  I added > comments to make the semantics explicit.  Given the documentation, it > may well be intentional