Re: restore bootstrap with a C++ compiler

2011-04-28 Thread Gabriel Dos Reis
Richard Sandiford writes: | Gabriel Dos Reis writes: | > | FWIW, I prefer Andrew's patch, but since yours has been applied, | > | I suppose there's no point changing it. | > | > when we come to agree on coding style guidelines for GCC in C++, I hope we | > recommend against local extern declarat

Re: restore bootstrap with a C++ compiler

2011-04-28 Thread Richard Sandiford
Gabriel Dos Reis writes: > | FWIW, I prefer Andrew's patch, but since yours has been applied, > | I suppose there's no point changing it. > > when we come to agree on coding style guidelines for GCC in C++, I hope we > recommend against local extern declarations. Oh, for pure C++, I definitely ag

Re: restore bootstrap with a C++ compiler

2011-04-28 Thread Gabriel Dos Reis
Richard Sandiford writes: | Gabriel Dos Reis writes: | > Andrew Pinski writes: | > | > | On Wed, Apr 27, 2011 at 6:48 PM, Gabriel Dos Reis wrote: | > | > A local `extern' declaration does not give the entity an external linkage | > | > -- irrespective of the linkage of the function enclosing

Re: restore bootstrap with a C++ compiler

2011-04-28 Thread Richard Sandiford
Gabriel Dos Reis writes: > Andrew Pinski writes: > > | On Wed, Apr 27, 2011 at 6:48 PM, Gabriel Dos Reis wrote: > | > A local `extern' declaration does not give the entity an external linkage > | > -- irrespective of the linkage of the function enclosing the declaration. > | > It just makes the

Re: restore bootstrap with a C++ compiler

2011-04-27 Thread Gabriel Dos Reis
Andrew Pinski writes: | On Wed, Apr 27, 2011 at 6:48 PM, Gabriel Dos Reis wrote: | > A local `extern' declaration does not give the entity an external linkage | > -- irrespective of the linkage of the function enclosing the declaration. | > It just makes the name locally available for name looku

Re: restore bootstrap with a C++ compiler

2011-04-27 Thread Andrew Pinski
On Wed, Apr 27, 2011 at 6:48 PM, Gabriel Dos Reis wrote: > A local `extern' declaration does not give the entity an external linkage > -- irrespective of the linkage of the function enclosing the declaration. > It just makes the name locally available for name lookup > purpose.   A variable declar

Re: restore bootstrap with a C++ compiler

2011-04-27 Thread Gabriel Dos Reis
Andrew Pinski writes: | On Wed, Apr 27, 2011 at 6:30 PM, Gabriel Dos Reis wrote: | > | > Richard, | > | > Your recent patch broke --enable-build-with-cxx because internal-fn.h | > was using good 'ol C-style name lookup trick that behaves badly with | > C++ linkage rules.  Fixed thusly.  Applied

Re: restore bootstrap with a C++ compiler

2011-04-27 Thread Andrew Pinski
On Wed, Apr 27, 2011 at 6:30 PM, Gabriel Dos Reis wrote: > > Richard, > > Your recent patch broke --enable-build-with-cxx because internal-fn.h > was using good 'ol C-style name lookup trick that behaves badly with > C++ linkage rules.  Fixed thusly.  Applied as obvious. Can you explain some more