Re: preserve more debug stmts in gimple jump threading

2019-05-21 Thread Alexandre Oliva
On May 17, 2019, Jeff Law wrote: > OK. Presumably creating a reliable testcase was painful? Heh, that it might even possible didn't even cross my mind. I was happy enough to be able to exercise and inspect the before&after IR for most of the new code paths in the patch in a GCC bootstrap, by p

Re: preserve more debug stmts in gimple jump threading

2019-05-17 Thread Jeff Law
On 5/15/19 2:20 AM, Alexandre Oliva wrote: > Gimple jump threading does not duplicate forwarder blocks that might > be present before or after the second copied block. This silently > drops debug binds and markers that might be present in them. This > patch attempts to preserve them. > > For blo

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Jeff Law
On 5/16/19 12:46 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 6:14 PM Jeff Law wrote: >> >> On 5/15/19 3:03 PM, Alexandre Oliva wrote: >>> On May 15, 2019, Richard Biener wrote: >>> On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > > Gimple jump threading does not dup

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 6:14 PM Jeff Law wrote: > > On 5/15/19 3:03 PM, Alexandre Oliva wrote: > > On May 15, 2019, Richard Biener wrote: > > > >> On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > >>> > >>> Gimple jump threading does not duplicate forwarder blocks that might > >>> be pre

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Jeff Law
On 5/15/19 3:03 PM, Alexandre Oliva wrote: > On May 15, 2019, Richard Biener wrote: > >> On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: >>> >>> Gimple jump threading does not duplicate forwarder blocks that might >>> be present before or after the copied block. > >> Empty forwarder blo

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Richard Biener
On Wed, May 15, 2019 at 11:03 PM Alexandre Oliva wrote: > > On May 15, 2019, Richard Biener wrote: > > > On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > >> > >> Gimple jump threading does not duplicate forwarder blocks that might > >> be present before or after the copied block. > > >

Re: preserve more debug stmts in gimple jump threading

2019-05-15 Thread Alexandre Oliva
On May 15, 2019, Richard Biener wrote: > On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: >> >> Gimple jump threading does not duplicate forwarder blocks that might >> be present before or after the copied block. > Empty forwarder blocks I presume? Empty except for debug stmts and poss

Re: preserve more debug stmts in gimple jump threading

2019-05-15 Thread Richard Biener
On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > > Gimple jump threading does not duplicate forwarder blocks that might > be present before or after the second copied block. Empty forwarder blocks I presume? > This silently > drops debug binds and markers that might be present in them.